* [tip:locking/core 19/28] include/linux/fs.h:1422:29: error: array type has incomplete element type 'struct percpu_rw_semaphore'
@ 2020-03-21 18:11 kbuild test robot
2020-03-21 19:28 ` Thomas Gleixner
0 siblings, 1 reply; 4+ messages in thread
From: kbuild test robot @ 2020-03-21 18:11 UTC (permalink / raw)
To: Peter Zijlstra (Intel); +Cc: kbuild-all, linux-kernel, x86, Thomas Gleixner
[-- Attachment #1: Type: text/plain, Size: 2452 bytes --]
tree: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git locking/core
head: d53f2b62fcb63f6547c10d8c62bca19e957b0eef
commit: 80fbaf1c3f2926c834f8ca915441dfe27ce5487e [19/28] rcuwait: Add @state argument to rcuwait_wait_event()
config: m68k-m5275evb_defconfig (attached as .config)
compiler: m68k-linux-gcc (GCC) 9.2.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
git checkout 80fbaf1c3f2926c834f8ca915441dfe27ce5487e
# save the attached .config to linux build tree
GCC_VERSION=9.2.0 make.cross ARCH=m68k
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
In file included from include/linux/huge_mm.h:8,
from include/linux/mm.h:567,
from arch/m68k/include/asm/uaccess_no.h:8,
from arch/m68k/include/asm/uaccess.h:3,
from include/linux/uaccess.h:11,
from include/linux/sched/task.h:11,
from include/linux/sched/signal.h:9,
from include/linux/rcuwait.h:6,
from include/linux/percpu-rwsem.h:7,
from kernel/locking/percpu-rwsem.c:6:
>> include/linux/fs.h:1422:29: error: array type has incomplete element type 'struct percpu_rw_semaphore'
1422 | struct percpu_rw_semaphore rw_sem[SB_FREEZE_LEVELS];
| ^~~~~~
vim +1422 include/linux/fs.h
5accdf82ba25ca Jan Kara 2012-06-12 1418
5accdf82ba25ca Jan Kara 2012-06-12 1419 struct sb_writers {
5accdf82ba25ca Jan Kara 2012-06-12 1420 int frozen; /* Is sb frozen? */
8129ed29644bf5 Oleg Nesterov 2015-08-11 1421 wait_queue_head_t wait_unfrozen; /* for get_super_thawed() */
8129ed29644bf5 Oleg Nesterov 2015-08-11 @1422 struct percpu_rw_semaphore rw_sem[SB_FREEZE_LEVELS];
5accdf82ba25ca Jan Kara 2012-06-12 1423 };
5accdf82ba25ca Jan Kara 2012-06-12 1424
:::::: The code at line 1422 was first introduced by commit
:::::: 8129ed29644bf56ed17ec1bbbeed5c568b43d6a0 change sb_writers to use percpu_rw_semaphore
:::::: TO: Oleg Nesterov <oleg@redhat.com>
:::::: CC: Oleg Nesterov <oleg@redhat.com>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 8272 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [tip:locking/core 19/28] include/linux/fs.h:1422:29: error: array type has incomplete element type 'struct percpu_rw_semaphore'
2020-03-21 18:11 [tip:locking/core 19/28] include/linux/fs.h:1422:29: error: array type has incomplete element type 'struct percpu_rw_semaphore' kbuild test robot
@ 2020-03-21 19:28 ` Thomas Gleixner
2020-03-25 12:27 ` Geert Uytterhoeven
2020-03-28 10:48 ` [tip: locking/core] m68knommu: Remove mm.h include from uaccess_no.h tip-bot2 for Thomas Gleixner
0 siblings, 2 replies; 4+ messages in thread
From: Thomas Gleixner @ 2020-03-21 19:28 UTC (permalink / raw)
To: kbuild test robot, Peter Zijlstra (Intel)
Cc: kbuild-all, linux-kernel, x86, Greg Ungerer, Geert Uytterhoeven,
linux-m68k
kbuild test robot <lkp@intel.com> writes:
> All errors (new ones prefixed by >>):
>
> In file included from include/linux/huge_mm.h:8,
> from include/linux/mm.h:567,
> from arch/m68k/include/asm/uaccess_no.h:8,
> from arch/m68k/include/asm/uaccess.h:3,
> from include/linux/uaccess.h:11,
> from include/linux/sched/task.h:11,
> from include/linux/sched/signal.h:9,
> from include/linux/rcuwait.h:6,
> from include/linux/percpu-rwsem.h:7,
> from kernel/locking/percpu-rwsem.c:6:
>>> include/linux/fs.h:1422:29: error: array type has incomplete element type 'struct percpu_rw_semaphore'
> 1422 | struct percpu_rw_semaphore rw_sem[SB_FREEZE_LEVELS];
> | ^~~~~~
Same problem as in the other architectures and same cure.
Thanks,
tglx
---
Subject: m68knommu: Remove mm.h include from uaccess_no.h
From: Thomas Gleixner <tglx@linutronix.de>
Date: Sat, 21 Mar 2020 20:22:10 +0100
In file included
from include/linux/huge_mm.h:8,
from include/linux/mm.h:567,
from arch/m68k/include/asm/uaccess_no.h:8,
from arch/m68k/include/asm/uaccess.h:3,
from include/linux/uaccess.h:11,
from include/linux/sched/task.h:11,
from include/linux/sched/signal.h:9,
from include/linux/rcuwait.h:6,
from include/linux/percpu-rwsem.h:7,
from kernel/locking/percpu-rwsem.c:6:
include/linux/fs.h:1422:29: error: array type has incomplete element type 'struct percpu_rw_semaphore'
1422 | struct percpu_rw_semaphore rw_sem[SB_FREEZE_LEVELS];
Removing the include of linux/mm.h from the uaccess header solves the problem
and various build tests of nommu configurations still work.
Fixes: 80fbaf1c3f29 ("rcuwait: Add @state argument to rcuwait_wait_event()")
Reported-by: kbuild test robot <lkp@intel.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: Greg Ungerer <gerg@linux-m68k.org>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: linux-m68k@lists.linux-m68k.org
---
arch/m68k/include/asm/uaccess_no.h | 1 -
1 file changed, 1 deletion(-)
--- a/arch/m68k/include/asm/uaccess_no.h
+++ b/arch/m68k/include/asm/uaccess_no.h
@@ -5,7 +5,6 @@
/*
* User space memory access functions
*/
-#include <linux/mm.h>
#include <linux/string.h>
#include <asm/segment.h>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [tip:locking/core 19/28] include/linux/fs.h:1422:29: error: array type has incomplete element type 'struct percpu_rw_semaphore'
2020-03-21 19:28 ` Thomas Gleixner
@ 2020-03-25 12:27 ` Geert Uytterhoeven
2020-03-28 10:48 ` [tip: locking/core] m68knommu: Remove mm.h include from uaccess_no.h tip-bot2 for Thomas Gleixner
1 sibling, 0 replies; 4+ messages in thread
From: Geert Uytterhoeven @ 2020-03-25 12:27 UTC (permalink / raw)
To: Thomas Gleixner
Cc: kbuild test robot, Peter Zijlstra (Intel),
kbuild-all, Linux Kernel Mailing List, the arch/x86 maintainers,
Greg Ungerer, linux-m68k
Hi Thomas,
On Sat, Mar 21, 2020 at 8:29 PM Thomas Gleixner <tglx@linutronix.de> wrote:
> kbuild test robot <lkp@intel.com> writes:
> > All errors (new ones prefixed by >>):
> >
> > In file included from include/linux/huge_mm.h:8,
> > from include/linux/mm.h:567,
> > from arch/m68k/include/asm/uaccess_no.h:8,
> > from arch/m68k/include/asm/uaccess.h:3,
> > from include/linux/uaccess.h:11,
> > from include/linux/sched/task.h:11,
> > from include/linux/sched/signal.h:9,
> > from include/linux/rcuwait.h:6,
> > from include/linux/percpu-rwsem.h:7,
> > from kernel/locking/percpu-rwsem.c:6:
> >>> include/linux/fs.h:1422:29: error: array type has incomplete element type 'struct percpu_rw_semaphore'
> > 1422 | struct percpu_rw_semaphore rw_sem[SB_FREEZE_LEVELS];
> > | ^~~~~~
>
> Same problem as in the other architectures and same cure.
Indeed it does.
> ---
> Subject: m68knommu: Remove mm.h include from uaccess_no.h
> From: Thomas Gleixner <tglx@linutronix.de>
> Date: Sat, 21 Mar 2020 20:22:10 +0100
>
> In file included
> from include/linux/huge_mm.h:8,
> from include/linux/mm.h:567,
> from arch/m68k/include/asm/uaccess_no.h:8,
> from arch/m68k/include/asm/uaccess.h:3,
> from include/linux/uaccess.h:11,
> from include/linux/sched/task.h:11,
> from include/linux/sched/signal.h:9,
> from include/linux/rcuwait.h:6,
> from include/linux/percpu-rwsem.h:7,
> from kernel/locking/percpu-rwsem.c:6:
> include/linux/fs.h:1422:29: error: array type has incomplete element type 'struct percpu_rw_semaphore'
> 1422 | struct percpu_rw_semaphore rw_sem[SB_FREEZE_LEVELS];
>
> Removing the include of linux/mm.h from the uaccess header solves the problem
> and various build tests of nommu configurations still work.
>
> Fixes: 80fbaf1c3f29 ("rcuwait: Add @state argument to rcuwait_wait_event()")
> Reported-by: kbuild test robot <lkp@intel.com>
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 4+ messages in thread
* [tip: locking/core] m68knommu: Remove mm.h include from uaccess_no.h
2020-03-21 19:28 ` Thomas Gleixner
2020-03-25 12:27 ` Geert Uytterhoeven
@ 2020-03-28 10:48 ` tip-bot2 for Thomas Gleixner
1 sibling, 0 replies; 4+ messages in thread
From: tip-bot2 for Thomas Gleixner @ 2020-03-28 10:48 UTC (permalink / raw)
To: linux-tip-commits
Cc: kbuild test robot, Thomas Gleixner, Geert Uytterhoeven, x86, LKML
The following commit has been merged into the locking/core branch of tip:
Commit-ID: 9e860351550b28901a78f122b1e2dc97f78ba369
Gitweb: https://git.kernel.org/tip/9e860351550b28901a78f122b1e2dc97f78ba369
Author: Thomas Gleixner <tglx@linutronix.de>
AuthorDate: Sat, 21 Mar 2020 20:22:10 +01:00
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitterDate: Sat, 28 Mar 2020 11:45:39 +01:00
m68knommu: Remove mm.h include from uaccess_no.h
In file included
from include/linux/huge_mm.h:8,
from include/linux/mm.h:567,
from arch/m68k/include/asm/uaccess_no.h:8,
from arch/m68k/include/asm/uaccess.h:3,
from include/linux/uaccess.h:11,
from include/linux/sched/task.h:11,
from include/linux/sched/signal.h:9,
from include/linux/rcuwait.h:6,
from include/linux/percpu-rwsem.h:7,
from kernel/locking/percpu-rwsem.c:6:
include/linux/fs.h:1422:29: error: array type has incomplete element type 'struct percpu_rw_semaphore'
1422 | struct percpu_rw_semaphore rw_sem[SB_FREEZE_LEVELS];
Removing the include of linux/mm.h from the uaccess header solves the problem
and various build tests of nommu configurations still work.
Fixes: 80fbaf1c3f29 ("rcuwait: Add @state argument to rcuwait_wait_event()")
Reported-by: kbuild test robot <lkp@intel.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>
Link: https://lkml.kernel.org/r/87fte1qzh0.fsf@nanos.tec.linutronix.de
---
arch/m68k/include/asm/uaccess_no.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/m68k/include/asm/uaccess_no.h b/arch/m68k/include/asm/uaccess_no.h
index 6bc80c3..a24cfe4 100644
--- a/arch/m68k/include/asm/uaccess_no.h
+++ b/arch/m68k/include/asm/uaccess_no.h
@@ -5,7 +5,6 @@
/*
* User space memory access functions
*/
-#include <linux/mm.h>
#include <linux/string.h>
#include <asm/segment.h>
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-03-28 10:48 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-21 18:11 [tip:locking/core 19/28] include/linux/fs.h:1422:29: error: array type has incomplete element type 'struct percpu_rw_semaphore' kbuild test robot
2020-03-21 19:28 ` Thomas Gleixner
2020-03-25 12:27 ` Geert Uytterhoeven
2020-03-28 10:48 ` [tip: locking/core] m68knommu: Remove mm.h include from uaccess_no.h tip-bot2 for Thomas Gleixner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).