From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07C96C2D0E5 for ; Sun, 29 Mar 2020 20:26:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DA87220748 for ; Sun, 29 Mar 2020 20:26:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728869AbgC2U0Y (ORCPT ); Sun, 29 Mar 2020 16:26:24 -0400 Received: from Galois.linutronix.de ([193.142.43.55]:56953 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728814AbgC2U0T (ORCPT ); Sun, 29 Mar 2020 16:26:19 -0400 Received: from [5.158.153.53] (helo=tip-bot2.lab.linutronix.de) by Galois.linutronix.de with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1jIeVc-0001MC-Vq; Sun, 29 Mar 2020 22:26:17 +0200 Received: from [127.0.1.1] (localhost [IPv6:::1]) by tip-bot2.lab.linutronix.de (Postfix) with ESMTP id 919DE1C0470; Sun, 29 Mar 2020 22:26:11 +0200 (CEST) Date: Sun, 29 Mar 2020 20:26:11 -0000 From: "tip-bot2 for Michal Simek" Reply-to: linux-kernel@vger.kernel.org To: linux-tip-commits@vger.kernel.org Subject: [tip: irq/core] irqchip/xilinx: Fill error code when irq domain registration fails Cc: Michal Simek , Marc Zyngier , Stefan Asserhall , x86 , LKML In-Reply-To: <20200317125600.15913-3-mubin.usman.sayyed@xilinx.com> References: <20200317125600.15913-3-mubin.usman.sayyed@xilinx.com> MIME-Version: 1.0 Message-ID: <158551357125.28353.14243002761268594399.tip-bot2@tip-bot2> X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The following commit has been merged into the irq/core branch of tip: Commit-ID: c74038baa9bccac76344b7215a55be136c81dfc3 Gitweb: https://git.kernel.org/tip/c74038baa9bccac76344b7215a55be136c81dfc3 Author: Michal Simek AuthorDate: Tue, 17 Mar 2020 18:25:58 +05:30 Committer: Marc Zyngier CommitterDate: Sun, 22 Mar 2020 11:52:53 irqchip/xilinx: Fill error code when irq domain registration fails There is no ret filled in case of irq_domain_add_linear() failure. Signed-off-by: Michal Simek Signed-off-by: Marc Zyngier Reviewed-by: Stefan Asserhall Link: https://lore.kernel.org/r/20200317125600.15913-3-mubin.usman.sayyed@xilinx.com --- drivers/irqchip/irq-xilinx-intc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/irqchip/irq-xilinx-intc.c b/drivers/irqchip/irq-xilinx-intc.c index 34593fa..1d3d273 100644 --- a/drivers/irqchip/irq-xilinx-intc.c +++ b/drivers/irqchip/irq-xilinx-intc.c @@ -228,6 +228,7 @@ static int __init xilinx_intc_of_init(struct device_node *intc, &xintc_irq_domain_ops, irqc); if (!irqc->root_domain) { pr_err("irq-xilinx: Unable to create IRQ domain\n"); + ret = -EINVAL; goto error; }