From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B327EC2BA15 for ; Fri, 3 Apr 2020 07:25:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 89183206F8 for ; Fri, 3 Apr 2020 07:25:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="i3oPTvsH" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389802AbgDCHZU (ORCPT ); Fri, 3 Apr 2020 03:25:20 -0400 Received: from mail-pl1-f196.google.com ([209.85.214.196]:38965 "EHLO mail-pl1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730889AbgDCHZU (ORCPT ); Fri, 3 Apr 2020 03:25:20 -0400 Received: by mail-pl1-f196.google.com with SMTP id k18so2379385pll.6; Fri, 03 Apr 2020 00:25:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:subject:to:cc:references:in-reply-to:mime-version :user-agent:message-id:content-transfer-encoding; bh=gWN2/l3Nk/lqsKPF1eViKQ9o9AZt+XSnO9fYcexJ5do=; b=i3oPTvsH5TefcZSZ/s6cffxKNlmPapTR0Q18gP6u0mf/PMRHwDbL2wMinlbhvtjzE9 KMyVIR96vM2c4ZYzaRNYjWN2UL+Dd+CnEUla7XPaBIMJ/hslJUXLoqHnMKXgJfJC9IAp OWDPIN7DJ5qcvEKf2xLRfjwt1xPzCT3PfRjdbUbFXzbRM2Lb4wXi9irkzkWffxvnc5/F KB8eJVttUWM3vacwK3+R777MHdc+WXvEqYKX1ZvYy5AL6Y45SbW/W9WZN1ICx/edWvmk cLVPOd0BXu7Au8JXVDcwD5lTyHkgsWxs4z96cAVY0rv4QN5ptCxTRrZQkCNYJSUEJyyn L6ZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:subject:to:cc:references:in-reply-to :mime-version:user-agent:message-id:content-transfer-encoding; bh=gWN2/l3Nk/lqsKPF1eViKQ9o9AZt+XSnO9fYcexJ5do=; b=KI7zYHQF47F20DM41plCmPVjO8jw6hFthvmD303ZRILTfDxKiCBi39fFxogdqYESO0 2vZP5GdTnegMRSCV+mdDwm9yY3zu5i2rZj2HphOdLRsPpArkflURmZIiuevoq4LyLQGq pGGb1OVqwu0G75xaPpkDK7eRbF3nxVdaXNfTOOhMKmiIqxy8+EOIlEu/E1W7v/V5JpwQ xE4TA4nRzn2BqHFqIeB3fBHR2FfRRV1ENnhfYyc9VrGze+rbqO8wl7VkfmEFpk3lRNL4 c6dzljWUhrzfs1E3uLpAeMzZBmeLNZFDHAZNfMMlm0m6wBaAklMXhX7XsL1xNv1xhVhh jRdA== X-Gm-Message-State: AGi0PuaSITHjAdJU8n9VkyTRkM5WbjzbdSfcHa/PzvtdEU8DE9VNpeT+ JVvhK6Piq9ASihBlJCs89Q0= X-Google-Smtp-Source: APiQypLvOn0Dugjcw4rcQbIFXLiJdhks1PnmfqUpwNAhu3DD4RMhhi5GkyAqP+L0q44XeXBvYh6XbQ== X-Received: by 2002:a17:90a:35ce:: with SMTP id r72mr8190743pjb.126.1585898719557; Fri, 03 Apr 2020 00:25:19 -0700 (PDT) Received: from localhost (60-241-117-97.tpgi.com.au. [60.241.117.97]) by smtp.gmail.com with ESMTPSA id l190sm5103624pfl.212.2020.04.03.00.25.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Apr 2020 00:25:18 -0700 (PDT) Date: Fri, 03 Apr 2020 17:25:13 +1000 From: Nicholas Piggin Subject: Re: [PATCH v11 0/8] Disable compat cruft on ppc64le v11 To: linuxppc-dev@lists.ozlabs.org, Michal Suchanek Cc: Arnaldo Carvalho de Melo , Alexander Shishkin , Allison Randal , Andy Shevchenko , Arnd Bergmann , Thiago Jung Bauermann , Benjamin Herrenschmidt , Sebastian Andrzej Siewior , Claudio Carvalho , Christophe Leroy , "David S. Miller" , "Eric W. Biederman" , Eric Richter , Greg Kroah-Hartman , Gustavo Luiz Duarte , Hari Bathini , Jordan Niethe , Jiri Olsa , Jonathan Cameron , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Mark Rutland , Masahiro Yamada , Mauro Carvalho Chehab , Michael Neuling , Ingo Molnar , Michael Ellerman , Namhyung Kim , Nayna Jain , Paul Mackerras , Peter Zijlstra , Rob Herring , Thomas Gleixner , Valentin Schneider , Alexander Viro References: <20200225173541.1549955-1-npiggin@gmail.com> In-Reply-To: MIME-Version: 1.0 User-Agent: astroid/0.15.0 (https://github.com/astroidmail/astroid) Message-Id: <1585898335.tckaz04a6x.astroid@bobo.none> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Michal Suchanek's on March 19, 2020 10:19 pm: > Less code means less bugs so add a knob to skip the compat stuff. >=20 > Changes in v2: saner CONFIG_COMPAT ifdefs > Changes in v3: > - change llseek to 32bit instead of builing it unconditionally in fs > - clanup the makefile conditionals > - remove some ifdefs or convert to IS_DEFINED where possible > Changes in v4: > - cleanup is_32bit_task and current_is_64bit > - more makefile cleanup > Changes in v5: > - more current_is_64bit cleanup > - split off callchain.c 32bit and 64bit parts > Changes in v6: > - cleanup makefile after split > - consolidate read_user_stack_32 > - fix some checkpatch warnings > Changes in v7: > - add back __ARCH_WANT_SYS_LLSEEK to fix build with llseek > - remove leftover hunk > - add review tags > Changes in v8: > - consolidate valid_user_sp to fix it in the split callchain.c > - fix build errors/warnings with PPC64 !COMPAT and PPC32 > Changes in v9: > - remove current_is_64bit() > Chanegs in v10: > - rebase, sent together with the syscall cleanup > Changes in v11: > - rebase > - add MAINTAINERS pattern for ppc perf These all look good to me. I had some minor comment about one patch but=20 not really a big deal and there were more cleanups on top of it, so I=20 don't mind if it's merged as is. Actually I think we have a bit of stack reading fixes for 64s radix now (not a bug fix as such, but we don't need the hash fault logic in radix), so if I get around to that I can propose the changes in that series. Thanks, Nick =