* [PATCH 0/2] mtd: spi-nor: macronix: Add mx25l512/mx25u512 support
@ 2020-04-06 9:00 Mason Yang
2020-04-06 9:00 ` [PATCH 1/2] mtd: spi-nor: macronix: Add mx25l51245g support Mason Yang
2020-04-06 9:00 ` [PATCH 2/2] mtd: spi-nor: macronix: Add mx25u51245g support Mason Yang
0 siblings, 2 replies; 5+ messages in thread
From: Mason Yang @ 2020-04-06 9:00 UTC (permalink / raw)
To: tudor.ambarus, miquel.raynal, richard, vigneshr
Cc: juliensu, linux-kernel, linux-mtd, Mason Yang
Hi,
mx25l51245g/mx25u51245g is a mass production for new design and
replace mx66l51235l/mx66u51235f(phase out).
thanks for your time and review.
Mason
Mason Yang (2):
mtd: spi-nor: macronix: Add mx25l51245g support
mtd: spi-nor: macronix: Add mx25u51245g support
drivers/mtd/spi-nor/macronix.c | 6 ++++++
1 file changed, 6 insertions(+)
--
1.9.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 1/2] mtd: spi-nor: macronix: Add mx25l51245g support
2020-04-06 9:00 [PATCH 0/2] mtd: spi-nor: macronix: Add mx25l512/mx25u512 support Mason Yang
@ 2020-04-06 9:00 ` Mason Yang
2020-04-06 9:00 ` [PATCH 2/2] mtd: spi-nor: macronix: Add mx25u51245g support Mason Yang
1 sibling, 0 replies; 5+ messages in thread
From: Mason Yang @ 2020-04-06 9:00 UTC (permalink / raw)
To: tudor.ambarus, miquel.raynal, richard, vigneshr
Cc: juliensu, linux-kernel, linux-mtd, Mason Yang
mx25l51245g is a mass production for new design and
replace mx66l51235l(phase out).
Signed-off-by: Mason Yang <masonccyang@mxic.com.tw>
---
drivers/mtd/spi-nor/macronix.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/mtd/spi-nor/macronix.c b/drivers/mtd/spi-nor/macronix.c
index ab0f963..c864ac8 100644
--- a/drivers/mtd/spi-nor/macronix.c
+++ b/drivers/mtd/spi-nor/macronix.c
@@ -67,6 +67,9 @@
SECT_4K | SPI_NOR_DUAL_READ |
SPI_NOR_QUAD_READ) },
{ "mx25l25655e", INFO(0xc22619, 0, 64 * 1024, 512, 0) },
+ { "mx25l51245g", INFO(0xc2201a, 0, 64 * 1024, 1024,
+ SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
+ SPI_NOR_4B_OPCODES) },
{ "mx66l51235l", INFO(0xc2201a, 0, 64 * 1024, 1024,
SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
SPI_NOR_4B_OPCODES) },
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 2/2] mtd: spi-nor: macronix: Add mx25u51245g support
2020-04-06 9:00 [PATCH 0/2] mtd: spi-nor: macronix: Add mx25l512/mx25u512 support Mason Yang
2020-04-06 9:00 ` [PATCH 1/2] mtd: spi-nor: macronix: Add mx25l51245g support Mason Yang
@ 2020-04-06 9:00 ` Mason Yang
2020-04-20 8:57 ` Tudor.Ambarus
1 sibling, 1 reply; 5+ messages in thread
From: Mason Yang @ 2020-04-06 9:00 UTC (permalink / raw)
To: tudor.ambarus, miquel.raynal, richard, vigneshr
Cc: juliensu, linux-kernel, linux-mtd, Mason Yang
mx25u51245g is a mass production for new design and
replace mx66u51235f(phase out).
Signed-off-by: Mason Yang <masonccyang@mxic.com.tw>
---
drivers/mtd/spi-nor/macronix.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/mtd/spi-nor/macronix.c b/drivers/mtd/spi-nor/macronix.c
index c864ac8..e685aec 100644
--- a/drivers/mtd/spi-nor/macronix.c
+++ b/drivers/mtd/spi-nor/macronix.c
@@ -73,6 +73,9 @@
{ "mx66l51235l", INFO(0xc2201a, 0, 64 * 1024, 1024,
SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
SPI_NOR_4B_OPCODES) },
+ { "mx25u51245g", INFO(0xc2253a, 0, 64 * 1024, 1024,
+ SECT_4K | SPI_NOR_DUAL_READ |
+ SPI_NOR_QUAD_READ | SPI_NOR_4B_OPCODES) },
{ "mx66u51235f", INFO(0xc2253a, 0, 64 * 1024, 1024,
SECT_4K | SPI_NOR_DUAL_READ |
SPI_NOR_QUAD_READ | SPI_NOR_4B_OPCODES) },
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 2/2] mtd: spi-nor: macronix: Add mx25u51245g support
2020-04-06 9:00 ` [PATCH 2/2] mtd: spi-nor: macronix: Add mx25u51245g support Mason Yang
@ 2020-04-20 8:57 ` Tudor.Ambarus
2020-04-22 2:16 ` masonccyang
0 siblings, 1 reply; 5+ messages in thread
From: Tudor.Ambarus @ 2020-04-20 8:57 UTC (permalink / raw)
To: masonccyang
Cc: miquel.raynal, richard, vigneshr, juliensu, linux-kernel, linux-mtd
Hi, Mason,
On Monday, April 6, 2020 12:00:11 PM EEST Mason Yang wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the
> content is safe
>
> mx25u51245g is a mass production for new design and
> replace mx66u51235f(phase out).
>
> Signed-off-by: Mason Yang <masonccyang@mxic.com.tw>
> ---
> drivers/mtd/spi-nor/macronix.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/mtd/spi-nor/macronix.c b/drivers/mtd/spi-nor/macronix.c
> index c864ac8..e685aec 100644
> --- a/drivers/mtd/spi-nor/macronix.c
> +++ b/drivers/mtd/spi-nor/macronix.c
> @@ -73,6 +73,9 @@
> { "mx66l51235l", INFO(0xc2201a, 0, 64 * 1024, 1024,
> SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
> SPI_NOR_4B_OPCODES) },
> + { "mx25u51245g", INFO(0xc2253a, 0, 64 * 1024, 1024,
Shouldn't the ID be 0xc2953a?
We usually don't add new flashes if they are not tested. Please specify in the
commit message with which controller you tested the flash. Please do the same
for the previous patch.
The minimal test is a read, erase, read back, write and read back. This
sequence should verify if read, erase and pp work fine.
Cheers,
ta
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 2/2] mtd: spi-nor: macronix: Add mx25u51245g support
2020-04-20 8:57 ` Tudor.Ambarus
@ 2020-04-22 2:16 ` masonccyang
0 siblings, 0 replies; 5+ messages in thread
From: masonccyang @ 2020-04-22 2:16 UTC (permalink / raw)
To: Tudor.Ambarus
Cc: juliensu, linux-kernel, linux-mtd, miquel.raynal, richard, vigneshr
Hi Tudor,
> On Monday, April 6, 2020 12:00:11 PM EEST Mason Yang wrote:
> > EXTERNAL EMAIL: Do not click links or open attachments unless you know
the
> > content is safe
> >
> > mx25u51245g is a mass production for new design and
> > replace mx66u51235f(phase out).
> >
> > Signed-off-by: Mason Yang <masonccyang@mxic.com.tw>
> > ---
> > drivers/mtd/spi-nor/macronix.c | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/drivers/mtd/spi-nor/macronix.c
b/drivers/mtd/spi-nor/macronix.c
> > index c864ac8..e685aec 100644
> > --- a/drivers/mtd/spi-nor/macronix.c
> > +++ b/drivers/mtd/spi-nor/macronix.c
> > @@ -73,6 +73,9 @@
> > { "mx66l51235l", INFO(0xc2201a, 0, 64 * 1024, 1024,
> > SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
> > SPI_NOR_4B_OPCODES) },
> > + { "mx25u51245g", INFO(0xc2253a, 0, 64 * 1024, 1024,
>
> Shouldn't the ID be 0xc2953a?
no!
it's 0xc2253a
please refer to Macronix website
https://www.macronix.com/zh-tw/products/NOR-Flash/Serial-NOR-Flash/Pages/spec.aspx?p=MX25U51245G&m=Serial%20NOR%20Flash&n=PM2244
>
> We usually don't add new flashes if they are not tested. Please specify
in the
> commit message with which controller you tested the flash. Please do the
same
> for the previous patch.
okay.
>
> The minimal test is a read, erase, read back, write and read back. This
> sequence should verify if read, erase and pp work fine.
sure.
>
> Cheers,
> ta
>
thanks for your time & review.
Mason
CONFIDENTIALITY NOTE:
This e-mail and any attachments may contain confidential information
and/or personal data, which is protected by applicable laws. Please be
reminded that duplication, disclosure, distribution, or use of this e-mail
(and/or its attachments) or any part thereof is prohibited. If you receive
this e-mail in error, please notify us immediately and delete this mail as
well as its attachment(s) from your system. In addition, please be
informed that collection, processing, and/or use of personal data is
prohibited unless expressly permitted by personal data protection laws.
Thank you for your attention and cooperation.
Macronix International Co., Ltd.
=====================================================================
============================================================================
CONFIDENTIALITY NOTE:
This e-mail and any attachments may contain confidential information and/or personal data, which is protected by applicable laws. Please be reminded that duplication, disclosure, distribution, or use of this e-mail (and/or its attachments) or any part thereof is prohibited. If you receive this e-mail in error, please notify us immediately and delete this mail as well as its attachment(s) from your system. In addition, please be informed that collection, processing, and/or use of personal data is prohibited unless expressly permitted by personal data protection laws. Thank you for your attention and cooperation.
Macronix International Co., Ltd.
=====================================================================
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-04-22 2:17 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-06 9:00 [PATCH 0/2] mtd: spi-nor: macronix: Add mx25l512/mx25u512 support Mason Yang
2020-04-06 9:00 ` [PATCH 1/2] mtd: spi-nor: macronix: Add mx25l51245g support Mason Yang
2020-04-06 9:00 ` [PATCH 2/2] mtd: spi-nor: macronix: Add mx25u51245g support Mason Yang
2020-04-20 8:57 ` Tudor.Ambarus
2020-04-22 2:16 ` masonccyang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).