From: Giovanni Gherdovich <ggherdovich@suse.cz>
To: Harald Arnesen <harald@skogtun.org>,
Peter Zijlstra <peterz@infradead.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Dave Kleikamp <dave.kleikamp@oracle.com>
Cc: Ingo Molnar <mingo@kernel.org>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [BISECTED]: Kernel panic (was: Linux 5.7-rc2)
Date: Wed, 22 Apr 2020 13:01:24 +0200 [thread overview]
Message-ID: <1587553284.9537.96.camel@suse.cz> (raw)
In-Reply-To: <ecdc6ffa-0137-4ca0-3bdb-cf37178ba4ff@skogtun.org>
On Wed, 2020-04-22 at 12:22 +0200, Harald Arnesen wrote:
> Harald Arnesen [22.04.2020 11:37]:
>
> > Giovanni Gherdovich [22.04.2020 11:02]:
> > >
> > > Harald:
> > >
> > > I'll echo Linus' request of testing that the patch series linked above fixes
> > > the problem on your machine. Since you're testing -rc kernels and bisecting
> > > bugs I assume you're comfortable with patching and compiling kernels, but if
> > > that is not the case I am more than happy to assist by providing either an RPM
> > > or a DEB package, depending on the distribution you're running. Let me know.
> > Will try patching first, if I'm not successful, you may compile a DEB
> > package for me.
>
> I can confirm that my Thinkpad T510i boots normally with the four
> patches added.
>
> Thanks!
That's awesome, thank you for testing.
Regarding the turbostat output you attached to an earlier email, it confirms
the suspicion that the 4C turbo is reported as zero (being a 2 cores / 4 threads
machine), explaining why the fix works:
cpu2: MSR_TURBO_RATIO_LIMIT: 0x00001313
19 * 133.3 = 2533.3 MHz max turbo 2 active cores
19 * 133.3 = 2533.3 MHz max turbo 1 active cores
In the above, bits 31:24 are zero. It's not a universal rule, though: my laptop
also has a 2 cores / 4 threads cpu, and that same MSR says:
cpu3: MSR_TURBO_RATIO_LIMIT: 0x1b1b1b1b1b1d
27 * 100.0 = 2700.0 MHz max turbo 6 active cores
27 * 100.0 = 2700.0 MHz max turbo 5 active cores
27 * 100.0 = 2700.0 MHz max turbo 4 active cores
27 * 100.0 = 2700.0 MHz max turbo 3 active cores
27 * 100.0 = 2700.0 MHz max turbo 2 active cores
29 * 100.0 = 2900.0 MHz max turbo 1 active cores
So despite my CPU being similar to yours, it wouldn't show the bug. There is
even more: the bug can show on large core counts too, as seen in
https://lore.kernel.org/lkml/bf43772d-48e5-01d4-dd03-330110e487fa@linux.intel.com/
Like Xu from Intel has an Atom P-Series with 24 physical cores, yet their
MSR goes like:
MSR_TURBO_RATIO_LIMIT: 0x00000016
which means only the 1C turbo is reported non-zero (that machine doesn't have
turbo at all, 1C turbo is the same as base frequency).
Thanks,
Giovanni
next prev parent reply other threads:[~2020-04-22 11:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-19 21:58 Linux 5.7-rc2 Linus Torvalds
[not found] ` <428bac87-b6dd-0867-c8f8-622cd606de3e@skogtun.org>
2020-04-21 19:03 ` [BISECTED]: Kernel panic (was: Linux 5.7-rc2) Linus Torvalds
2020-04-21 21:23 ` Peter Zijlstra
2020-04-21 21:30 ` Linus Torvalds
2020-04-21 21:41 ` Peter Zijlstra
2020-04-22 9:02 ` Giovanni Gherdovich
2020-04-22 9:37 ` Harald Arnesen
2020-04-22 10:22 ` Harald Arnesen
2020-04-22 11:01 ` Giovanni Gherdovich [this message]
2020-04-22 14:12 ` Dave Kleikamp
2020-04-22 14:49 ` Giovanni Gherdovich
2020-04-22 9:32 ` Harald Arnesen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1587553284.9537.96.camel@suse.cz \
--to=ggherdovich@suse.cz \
--cc=dave.kleikamp@oracle.com \
--cc=harald@skogtun.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=rafael.j.wysocki@intel.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).