From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F07FC54FCB for ; Fri, 24 Apr 2020 02:41:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6D95020728 for ; Fri, 24 Apr 2020 02:41:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="mkp2gRYN" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726324AbgDXCld (ORCPT ); Thu, 23 Apr 2020 22:41:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45174 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725922AbgDXClb (ORCPT ); Thu, 23 Apr 2020 22:41:31 -0400 Received: from mail-pf1-x443.google.com (mail-pf1-x443.google.com [IPv6:2607:f8b0:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5D88BC09B045 for ; Thu, 23 Apr 2020 19:41:31 -0700 (PDT) Received: by mail-pf1-x443.google.com with SMTP id v63so4065752pfb.10 for ; Thu, 23 Apr 2020 19:41:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:content-transfer-encoding:in-reply-to:references :subject:from:cc:to:date:message-id:user-agent; bh=IamAn4a0tQXNMZ5u6FtEHO8gII/iIo7Dkt5XESJ77dQ=; b=mkp2gRYNtVroJL0E5FpN6TQ1ABuX3Q+1ke0nW3i6W26Jc9tboDBV1/i77MwsBJ3FYx ejQXMEoqNJs5kQ/L3baIEXrXYDy71UBWrs3vxusMVBHr8B5OnDSG27PmRphMS0E7OsMq xhhsoUhzxkI6F0+B8I8WhwwsuwLs3fMCRvh1w= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:content-transfer-encoding :in-reply-to:references:subject:from:cc:to:date:message-id :user-agent; bh=IamAn4a0tQXNMZ5u6FtEHO8gII/iIo7Dkt5XESJ77dQ=; b=rMj8MZfTgzPnDqmD06Uni37G6s2gDpoful9XibKlG+MRNK9GeKEvMeVqIW5zsPx/XK g5xnvc5F5w9KJ+X8G++n9R1BdXzcHYhfH5vQ3QGfxSuqV5CN3/V1ZGpiCbRHIJ8DON1M VrXIJgSIvp2c+daanZSnjBKTunvOi5HkSCcLHSopgRQYyopr2ZM8Rc0wNe1dsMJp5FVk CgG+Cn7Px1lqWHyPiunfv764wmmTRyjQHGQltfYOH1vIDdl1oh0WMmF7m9vNhOoFBnh1 vcMfF2xgCBMGgWHgBxUT4wixrAtaH2OWyAmuijU5NFhiGL7iFaMI55xzJpoXWx9Z+qm0 NK7Q== X-Gm-Message-State: AGi0Puanmyu9XpfuivnYYgXgqBirFQNw5NpcqYGC9WCITn5hJnNGajjr bxw1KsKb0nfith2TohVo39dwPg== X-Google-Smtp-Source: APiQypLfcGqGen5mp5XKqJ1vdbdXM4bxAywugE5RO8B7Z7gEjxWlAJTv+Do9/rhgBJdrxbbr6Y8rww== X-Received: by 2002:a63:6342:: with SMTP id x63mr3762256pgb.185.1587696090768; Thu, 23 Apr 2020 19:41:30 -0700 (PDT) Received: from chromium.org ([2620:15c:202:1:fa53:7765:582b:82b9]) by smtp.gmail.com with ESMTPSA id b24sm3361024pfi.4.2020.04.23.19.41.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Apr 2020 19:41:30 -0700 (PDT) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <158769590404.135303.4049749400685142607@swboyd.mtv.corp.google.com> References: <20200422145408.v4.1.Ic7096b3b9b7828cdd41cd5469a6dee5eb6abf549@changeid> <20200422145408.v4.2.I1927d1bca2569a27b2d04986baf285027f0818a2@changeid> <158769590404.135303.4049749400685142607@swboyd.mtv.corp.google.com> Subject: Re: [PATCH v4 2/5] soc: qcom: rpmh-rsc: We aren't notified of our own failure w/ NOTIFY_BAD From: Stephen Boyd Cc: mka@chromium.org, mkshah@codeaurora.org, evgreen@chromium.org, Douglas Anderson , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org To: Andy Gross , Bjorn Andersson , Douglas Anderson , Greg Kroah-Hartman , rafael.j.wysocki@intel.com Date: Thu, 23 Apr 2020 19:41:29 -0700 Message-ID: <158769608929.135303.4217396252503884167@swboyd.mtv.corp.google.com> User-Agent: alot/0.9 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Stephen Boyd (2020-04-23 19:38:24) > Quoting Douglas Anderson (2020-04-22 14:55:00) > > When a PM Notifier returns NOTIFY_BAD it doesn't get called with > > CPU_PM_ENTER_FAILED. It only get called for CPU_PM_ENTER_FAILED if > > someone else (further down the notifier chain) returns NOTIFY_BAD. > >=20 > > Handle this case by taking our CPU out of the list of ones that have > > entered PM. Without this it's possible we could detect that the last > > CPU went down (and we would flush) even if some CPU was alive. That's > > not good since our flushing routines currently assume they're running > > on the last CPU for mutual exclusion. > >=20 > > Fixes: 985427f997b6 ("soc: qcom: rpmh: Invoke rpmh_flush() for dirty ca= ches") > > Signed-off-by: Douglas Anderson > > --- >=20 > Reported-by: Stephen Boyd Scratch that one! Copy/paste for the lose.