From: Stephen Boyd <swboyd@chromium.org>
To: Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Douglas Anderson <dianders@chromium.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
rafael.j.wysocki@intel.com
Cc: evgreen@chromium.org, mka@chromium.org, mkshah@codeaurora.org,
Douglas Anderson <dianders@chromium.org>,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 4/5] soc: qcom: rpmh-rsc: Simplify locking by eliminating the per-TCS lock
Date: Fri, 24 Apr 2020 11:28:38 -0700 [thread overview]
Message-ID: <158775291872.135303.5673866534956446786@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <158775156694.135303.3535369004080151247@swboyd.mtv.corp.google.com>
Quoting Stephen Boyd (2020-04-24 11:06:06)
> Quoting Douglas Anderson (2020-04-24 09:46:56)
> > @@ -581,24 +575,19 @@ static int tcs_write(struct rsc_drv *drv, const struct tcs_request *msg)
> > + ret = find_free_tcs(tcs);
> > + if (ret < 0)
> > + goto unlock;
> > + tcs_id = ret;
>
> Sorry, missed this. We should keep the tcs_id = find_free_tcs() thing
> and then assign ret to it on failure. Otherwise the return value of this
> function is -EBUSY or the tcs_id number instead of -EBUSY or 0.
>
Ah I see that ret is only returned on error. Nevermind that comment. I
should make that coffee this morning...
next prev parent reply other threads:[~2020-04-24 18:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-24 16:46 [PATCH v5 1/5] soc: qcom: rpmh-rsc: Correctly ignore CPU_CLUSTER_PM notifications Douglas Anderson
2020-04-24 16:46 ` [PATCH v5 2/5] soc: qcom: rpmh-rsc: We aren't notified of our own failure w/ NOTIFY_BAD Douglas Anderson
2020-04-24 16:46 ` [PATCH v5 3/5] kernel/cpu_pm: Fix uninitted local in cpu_pm Douglas Anderson
2020-04-30 21:15 ` Doug Anderson
2020-04-24 16:46 ` [PATCH v5 4/5] soc: qcom: rpmh-rsc: Simplify locking by eliminating the per-TCS lock Douglas Anderson
2020-04-24 17:30 ` Stephen Boyd
2020-04-24 18:06 ` Stephen Boyd
2020-04-24 18:28 ` Stephen Boyd [this message]
2020-04-24 16:46 ` [PATCH v5 5/5] soc: qcom: rpmh-rsc: Remove the pm_lock Douglas Anderson
2020-05-04 5:19 ` [PATCH v5 1/5] soc: qcom: rpmh-rsc: Correctly ignore CPU_CLUSTER_PM notifications Maulik Shah
2020-05-04 17:54 ` Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=158775291872.135303.5673866534956446786@swboyd.mtv.corp.google.com \
--to=swboyd@chromium.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=dianders@chromium.org \
--cc=evgreen@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mka@chromium.org \
--cc=mkshah@codeaurora.org \
--cc=rafael.j.wysocki@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).