From: Masami Hiramatsu <mhiramat@kernel.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Masami Hiramatsu <mhiramat@kernel.org>,
Tom Zanussi <zanussi@kernel.org>,
linux-kernel@vger.kernel.org, Ingo Molnar <mingo@kernel.org>
Subject: [PATCH 0/3] tracing/kprobes: Fix event generation API etc.
Date: Sat, 25 Apr 2020 14:48:59 +0900 [thread overview]
Message-ID: <158779373972.6082.16695832932765258919.stgit@devnote2> (raw)
Hello,
Here are bugfix/cleanup patches for the kprobe tracer, [1/3]
is a typo fix, [2/3] is fixing boot-time tracer and [3/3] is
error checking for the new in-kernel kprobe event API.
Tom, I found that your commit 29a154810546 ("tracing: Change
trace_boot to use kprobe_event interface") broke the boot-time
tracer's kprobe event because of wrong API usage. Could you
review it?
I marked [3/3] as a bugfix, because if the loc == NULL,
__kprobe_event_gen_cmd_start() obviously does not work.
But it reports actual error at kprobe_event_gen_cmd_end().
That is not good for developers to debug it.
Thank you,
---
Masami Hiramatsu (3):
tracing/kprobes: Fix a double initialization typo
tracing/boottime: Fix kprobe event API usage
tracing/kprobes: Reject new event if loc is NULL
kernel/trace/trace_boot.c | 20 ++++++++------------
kernel/trace/trace_kprobe.c | 8 +++++++-
2 files changed, 15 insertions(+), 13 deletions(-)
--
Masami Hiramatsu (Linaro) <mhiramat@kernel.org>
next reply other threads:[~2020-04-25 5:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-25 5:48 Masami Hiramatsu [this message]
2020-04-25 5:49 ` [PATCH 1/3] tracing/kprobes: Fix a double initialization typo Masami Hiramatsu
2020-04-25 5:49 ` [PATCH 2/3] tracing/boottime: Fix kprobe event API usage Masami Hiramatsu
2020-04-25 14:00 ` Steven Rostedt
2020-04-26 7:59 ` Masami Hiramatsu
2020-04-26 20:55 ` Tom Zanussi
2020-04-25 5:49 ` [PATCH 3/3] tracing/kprobes: Reject new event if loc is NULL Masami Hiramatsu
2020-05-20 14:22 ` [PATCH 0/3] tracing/kprobes: Fix event generation API etc Masami Hiramatsu
2020-05-20 14:33 ` Steven Rostedt
2020-05-20 14:40 ` Steven Rostedt
2020-05-21 7:55 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=158779373972.6082.16695832932765258919.stgit@devnote2 \
--to=mhiramat@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=rostedt@goodmis.org \
--cc=zanussi@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).