From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: jejb@linux.ibm.com, aacraid@microsemi.com,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: "Martin K . Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: aacraid: Fix some error handling paths in 'aac_probe_one()'
Date: Mon, 27 Apr 2020 18:49:49 -0400 [thread overview]
Message-ID: <158802757520.27023.14035276109176874290.b4-ty@oracle.com> (raw)
In-Reply-To: <20200412094039.8822-1-christophe.jaillet@wanadoo.fr>
On Sun, 12 Apr 2020 11:40:39 +0200, Christophe JAILLET wrote:
> If 'scsi_host_alloc()' or 'kcalloc()' fail, 'error' is known to be 0. Set
> it explicitly to -ENOMEM instead before branching to the error handling
> path.
>
> While at it, axe 2 useless assignments to 'error'. These values are
> overwridden a few lines later.
Applied to 5.8/scsi-queue, thanks!
[1/1] scsi: aacraid: Fix error handling paths in aac_probe_one()
https://git.kernel.org/mkp/scsi/c/f7854c382240
--
Martin K. Petersen Oracle Linux Engineering
prev parent reply other threads:[~2020-04-27 22:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-12 9:40 [PATCH] scsi: aacraid: Fix some error handling paths in 'aac_probe_one()' Christophe JAILLET
2020-04-27 22:49 ` Martin K. Petersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=158802757520.27023.14035276109176874290.b4-ty@oracle.com \
--to=martin.petersen@oracle.com \
--cc=aacraid@microsemi.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=jejb@linux.ibm.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).