* [PATCH] perf:Avoid duplicate printouts
@ 2020-04-02 11:59 Tang Bin
2020-04-30 21:12 ` Will Deacon
0 siblings, 1 reply; 2+ messages in thread
From: Tang Bin @ 2020-04-02 11:59 UTC (permalink / raw)
To: will, mark.rutland; +Cc: linux-arm-kernel, linux-kernel, Tang Bin
Because platform_get_irq() has dev_err(),so this place
should be removed.
Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>
---
drivers/perf/arm_dsu_pmu.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/perf/arm_dsu_pmu.c b/drivers/perf/arm_dsu_pmu.c
index 70968c8c0..518d0603e 100644
--- a/drivers/perf/arm_dsu_pmu.c
+++ b/drivers/perf/arm_dsu_pmu.c
@@ -690,10 +690,8 @@ static int dsu_pmu_device_probe(struct platform_device *pdev)
}
irq = platform_get_irq(pdev, 0);
- if (irq < 0) {
- dev_warn(&pdev->dev, "Failed to find IRQ\n");
+ if (irq < 0)
return -EINVAL;
- }
name = devm_kasprintf(&pdev->dev, GFP_KERNEL, "%s_%d",
PMUNAME, atomic_inc_return(&pmu_idx));
--
2.20.1.windows.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] perf:Avoid duplicate printouts
2020-04-02 11:59 [PATCH] perf:Avoid duplicate printouts Tang Bin
@ 2020-04-30 21:12 ` Will Deacon
0 siblings, 0 replies; 2+ messages in thread
From: Will Deacon @ 2020-04-30 21:12 UTC (permalink / raw)
To: mark.rutland, Tang Bin
Cc: catalin.marinas, Will Deacon, linux-arm-kernel, linux-kernel
On Thu, 2 Apr 2020 19:59:40 +0800, Tang Bin wrote:
> Because platform_get_irq() has dev_err(),so this place
> should be removed.
Applied to arm64 (for-next/perf), thanks!
[1/1] drivers/perf: arm_dsu_pmu: Avoid duplicate printouts
https://git.kernel.org/arm64/c/5810f00ade49
Cheers,
--
Will
https://fixes.arm64.dev
https://next.arm64.dev
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-04-30 21:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-02 11:59 [PATCH] perf:Avoid duplicate printouts Tang Bin
2020-04-30 21:12 ` Will Deacon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).