linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2] spi: sun6i: Add support for GPIO chip select lines
@ 2020-05-11  4:53 Alistair Francis
  2020-05-11 11:25 ` Mark Brown
  2020-05-11 17:21 ` Mark Brown
  0 siblings, 2 replies; 5+ messages in thread
From: Alistair Francis @ 2020-05-11  4:53 UTC (permalink / raw)
  To: broonie, linux-spi
  Cc: mripard, wens, linux-arm-kernel, linux-kernel, alistair23,
	Alistair Francis

Set use_gpio_descriptors as true to support using generic GPIO
lines for the chip select.

Signed-off-by: Alistair Francis <alistair@alistair23.me>
---
v2:
 - Use use_gpio_descriptors instead of spi_setup

 drivers/spi/spi-sun6i.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/spi/spi-sun6i.c b/drivers/spi/spi-sun6i.c
index ec7967be9e2f..ecea15534c42 100644
--- a/drivers/spi/spi-sun6i.c
+++ b/drivers/spi/spi-sun6i.c
@@ -470,6 +470,7 @@ static int sun6i_spi_probe(struct platform_device *pdev)
 
 	master->max_speed_hz = 100 * 1000 * 1000;
 	master->min_speed_hz = 3 * 1000;
+	master->use_gpio_descriptors = true;
 	master->set_cs = sun6i_spi_set_cs;
 	master->transfer_one = sun6i_spi_transfer_one;
 	master->num_chipselect = 4;
-- 
2.26.2


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH v2] spi: sun6i: Add support for GPIO chip select lines
  2020-05-11  4:53 [PATCH v2] spi: sun6i: Add support for GPIO chip select lines Alistair Francis
@ 2020-05-11 11:25 ` Mark Brown
  2020-05-11 12:42   ` Maxime Ripard
  2020-05-11 17:21 ` Mark Brown
  1 sibling, 1 reply; 5+ messages in thread
From: Mark Brown @ 2020-05-11 11:25 UTC (permalink / raw)
  To: linux-spi, Alistair Francis
  Cc: linux-kernel, wens, mripard, linux-arm-kernel, alistair23

On Sun, 10 May 2020 21:53:30 -0700, Alistair Francis wrote:
> Set use_gpio_descriptors as true to support using generic GPIO
> lines for the chip select.

Applied to

   local tree asoc/for-5.7

Thanks!

[1/1] spi: sun6i: Add support for GPIO chip select lines
      (no commit info)

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v2] spi: sun6i: Add support for GPIO chip select lines
  2020-05-11 11:25 ` Mark Brown
@ 2020-05-11 12:42   ` Maxime Ripard
  2020-05-11 14:53     ` Mark Brown
  0 siblings, 1 reply; 5+ messages in thread
From: Maxime Ripard @ 2020-05-11 12:42 UTC (permalink / raw)
  To: Mark Brown
  Cc: linux-spi, Alistair Francis, linux-kernel, wens,
	linux-arm-kernel, alistair23

[-- Attachment #1: Type: text/plain, Size: 338 bytes --]

Hi Mark

On Mon, May 11, 2020 at 12:25:35PM +0100, Mark Brown wrote:
> On Sun, 10 May 2020 21:53:30 -0700, Alistair Francis wrote:
> > Set use_gpio_descriptors as true to support using generic GPIO
> > lines for the chip select.
> 
> Applied to
> 
>    local tree asoc/for-5.7

Are you sure this is the proper tree?

Maxime

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v2] spi: sun6i: Add support for GPIO chip select lines
  2020-05-11 12:42   ` Maxime Ripard
@ 2020-05-11 14:53     ` Mark Brown
  0 siblings, 0 replies; 5+ messages in thread
From: Mark Brown @ 2020-05-11 14:53 UTC (permalink / raw)
  To: Maxime Ripard
  Cc: linux-spi, Alistair Francis, linux-kernel, wens,
	linux-arm-kernel, alistair23

[-- Attachment #1: Type: text/plain, Size: 231 bytes --]

On Mon, May 11, 2020 at 02:42:45PM +0200, Maxime Ripard wrote:
> On Mon, May 11, 2020 at 12:25:35PM +0100, Mark Brown wrote:

> >    local tree asoc/for-5.7

> Are you sure this is the proper tree?

b4 seems to have grown a bug :/

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v2] spi: sun6i: Add support for GPIO chip select lines
  2020-05-11  4:53 [PATCH v2] spi: sun6i: Add support for GPIO chip select lines Alistair Francis
  2020-05-11 11:25 ` Mark Brown
@ 2020-05-11 17:21 ` Mark Brown
  1 sibling, 0 replies; 5+ messages in thread
From: Mark Brown @ 2020-05-11 17:21 UTC (permalink / raw)
  To: linux-spi, Alistair Francis
  Cc: mripard, wens, linux-arm-kernel, alistair23, linux-kernel

On Sun, 10 May 2020 21:53:30 -0700, Alistair Francis wrote:
> Set use_gpio_descriptors as true to support using generic GPIO
> lines for the chip select.

Applied to

   local tree spi/for-5.7

Thanks!

[1/1] spi: sun6i: Add support for GPIO chip select lines
      (no commit info)

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2020-05-11 17:21 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-11  4:53 [PATCH v2] spi: sun6i: Add support for GPIO chip select lines Alistair Francis
2020-05-11 11:25 ` Mark Brown
2020-05-11 12:42   ` Maxime Ripard
2020-05-11 14:53     ` Mark Brown
2020-05-11 17:21 ` Mark Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).