[PATCH 1/2] MIPS: Loongson: Fix fatal error during GPU init

[PATCH 1/2] MIPS: Loongson: Fix fatal error during GPU init

[Tiezhu Yang]

When ATI Radeon graphics card has been compiled directly into the kernel
instead of as a module, we should make sure the firmware for the model
(check available ones in /lib/firmware/radeon) is built-in to the kernel
as well, otherwise there exists the following fatal error during GPU init,
change CONFIG_DRM_RADEON=y to CONFIG_DRM_RADEON=m to fix it.

[    1.900997] [drm] Loading RS780 Microcode
[    1.905077] radeon 0000:01:05.0: Direct firmware load for radeon/RS780_pfp.bin failed with error -2
[    1.914140] r600_cp: Failed to load firmware "radeon/RS780_pfp.bin"
[    1.920405] [drm:r600_init] *ERROR* Failed to load firmware!
[    1.926069] radeon 0000:01:05.0: Fatal error during GPU init
[    1.931729] [drm] radeon: finishing device.

Fixes: 024e6a8b5bb1 ("MIPS: Loongson: Add a Loongson-3 default config file")
Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
---
 arch/mips/configs/loongson3_defconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/mips/configs/loongson3_defconfig b/arch/mips/configs/loongson3_defconfig
index 6768c16..4df2434 100644
--- a/arch/mips/configs/loongson3_defconfig
+++ b/arch/mips/configs/loongson3_defconfig
@@ -230,7 +230,7 @@ CONFIG_MEDIA_CAMERA_SUPPORT=y
 CONFIG_MEDIA_USB_SUPPORT=y
 CONFIG_USB_VIDEO_CLASS=m
 CONFIG_DRM=y
-CONFIG_DRM_RADEON=y
+CONFIG_DRM_RADEON=m
 CONFIG_FB_RADEON=y
 CONFIG_LCD_CLASS_DEVICE=y
 CONFIG_LCD_PLATFORM=m
-- 
2.1.0

[PATCH 2/2] MIPS: Fix build errors under CONFIG_HAVE_STD_PC_SERIAL_PORT

[Tiezhu Yang]

When CONFIG_HAVE_STD_PC_SERIAL_PORT is set, include linux/module.h to fix
the following build errors:

  CC      arch/mips/kernel/8250-platform.o
arch/mips/kernel/8250-platform.c:42:1: error: data definition has no type or storage class [-Werror]
 module_init(uart8250_init);
 ^
arch/mips/kernel/8250-platform.c:42:1: error: type defaults to ‘int’ in declaration of ‘module_init’ [-Werror=implicit-int]
arch/mips/kernel/8250-platform.c:42:1: error: parameter names (without types) in function declaration [-Werror]
arch/mips/kernel/8250-platform.c:44:15: error: expected declaration specifiers or ‘...’ before string constant
 MODULE_AUTHOR("Ralf Baechle <ralf@linux-mips.org>");
               ^
arch/mips/kernel/8250-platform.c:45:16: error: expected declaration specifiers or ‘...’ before string constant
 MODULE_LICENSE("GPL");
                ^
arch/mips/kernel/8250-platform.c:46:20: error: expected declaration specifiers or ‘...’ before string constant
 MODULE_DESCRIPTION("Generic 8250 UART probe driver");
                    ^
arch/mips/kernel/8250-platform.c:37:81: error: ‘uart8250_init’ defined but not used [-Werror=unused-function]
 static int __init uart8250_init(void)
                                                                                 ^
cc1: all warnings being treated as errors
scripts/Makefile.build:267: recipe for target 'arch/mips/kernel/8250-platform.o' failed
make[2]: *** [arch/mips/kernel/8250-platform.o] Error 1

Fixes: 848484e2c412 ("mips: remove needless include of module.h from core kernel files.")
Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
---
 arch/mips/kernel/8250-platform.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/mips/kernel/8250-platform.c b/arch/mips/kernel/8250-platform.c
index 5c6b2ab..cbf3fe2 100644
--- a/arch/mips/kernel/8250-platform.c
+++ b/arch/mips/kernel/8250-platform.c
@@ -5,6 +5,7 @@
  *
  * Copyright (C) 2007 Ralf Baechle (ralf@linux-mips.org)
  */
+#include <linux/module.h>
 #include <linux/init.h>
 #include <linux/serial_8250.h>
 
-- 
2.1.0

Re: [PATCH 1/2] MIPS: Loongson: Fix fatal error during GPU init

[Jiaxun Yang]

于 2020年5月15日 GMT+08:00 上午10:15:00, Tiezhu Yang <yangtiezhu@loongson.cn> 写到:
>When ATI Radeon graphics card has been compiled directly into the kernel
>instead of as a module, we should make sure the firmware for the model
>(check available ones in /lib/firmware/radeon) is built-in to the kernel
>as well, otherwise there exists the following fatal error during GPU init,
>change CONFIG_DRM_RADEON=y to CONFIG_DRM_RADEON=m to fix it.
>

The commit message looks shocking.

You'd better reword it as "MIPS: Loongson64: Mark GPU driver as module in Kconfig"

Thanks.
-- 
Jiaxun Yang

Re: [PATCH 1/2] MIPS: Loongson: Fix fatal error during GPU init

[Tiezhu Yang]

On 05/15/2020 10:33 AM, Jiaxun Yang wrote:
>
> 于 2020年5月15日 GMT+08:00 上午10:15:00, Tiezhu Yang <yangtiezhu@loongson.cn> 写到:
>> When ATI Radeon graphics card has been compiled directly into the kernel
>> instead of as a module, we should make sure the firmware for the model
>> (check available ones in /lib/firmware/radeon) is built-in to the kernel
>> as well, otherwise there exists the following fatal error during GPU init,
>> change CONFIG_DRM_RADEON=y to CONFIG_DRM_RADEON=m to fix it.
>>
> The commit message looks shocking.
>
> You'd better reword it as "MIPS: Loongson64: Mark GPU driver as module in Kconfig"

OK, I will modify the patch subject and send v2.

>
> Thanks.

Re: [PATCH 1/2] MIPS: Loongson: Fix fatal error during GPU init

[Jiaxun Yang]

于 2020年5月15日 GMT+08:00 上午11:09:56, Tiezhu Yang <yangtiezhu@loongson.cn> 写到:
>On 05/15/2020 10:33 AM, Jiaxun Yang wrote:
>>
>> 于 2020年5月15日 GMT+08:00 上午10:15:00, Tiezhu Yang <yangtiezhu@loongson.cn> 写到:
>>> When ATI Radeon graphics card has been compiled directly into the kernel
>>> instead of as a module, we should make sure the firmware for the model
>>> (check available ones in /lib/firmware/radeon) is built-in to the kernel
>>> as well, otherwise there exists the following fatal error during GPU init,
>>> change CONFIG_DRM_RADEON=y to CONFIG_DRM_RADEON=m to fix it.
>>>
>> The commit message looks shocking.
>>
>> You'd better reword it as "MIPS: Loongson64: Mark GPU driver as module in Kconfig"
>
>OK, I will modify the patch subject and send v2.

Sorry I meant defconfig not Kconfig.
>
>>
>> Thanks.
>

-- 
Jiaxun Yang

Re: [PATCH 1/2] MIPS: Loongson: Fix fatal error during GPU init

[Sergei Shtylyov]

Hello!

On 15.05.2020 5:15, Tiezhu Yang wrote:

> When ATI Radeon graphics card has been compiled directly into the kernel
                                ^ driver

> instead of as a module, we should make sure the firmware for the model
> (check available ones in /lib/firmware/radeon) is built-in to the kernel
> as well, otherwise there exists the following fatal error during GPU init,
> change CONFIG_DRM_RADEON=y to CONFIG_DRM_RADEON=m to fix it.
> 
> [    1.900997] [drm] Loading RS780 Microcode
> [    1.905077] radeon 0000:01:05.0: Direct firmware load for radeon/RS780_pfp.bin failed with error -2
> [    1.914140] r600_cp: Failed to load firmware "radeon/RS780_pfp.bin"
> [    1.920405] [drm:r600_init] *ERROR* Failed to load firmware!
> [    1.926069] radeon 0000:01:05.0: Fatal error during GPU init
> [    1.931729] [drm] radeon: finishing device.
> 
> Fixes: 024e6a8b5bb1 ("MIPS: Loongson: Add a Loongson-3 default config file")
> Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
[...]

MBR, Sergei

Re: [PATCH 1/2] MIPS: Loongson: Fix fatal error during GPU init

[Tiezhu Yang]

On 05/15/2020 04:51 PM, Sergei Shtylyov wrote:
> Hello!
>
> On 15.05.2020 5:15, Tiezhu Yang wrote:
>
>> When ATI Radeon graphics card has been compiled directly into the kernel
>                                ^ driver

Hi Sergei,

Thanks for your review, I have been sent v2 with the updated commit message:
https://lore.kernel.org/patchwork/patch/1242218/

Thanks,
Tiezhu Yang

>
>> instead of as a module, we should make sure the firmware for the model
>> (check available ones in /lib/firmware/radeon) is built-in to the kernel
>> as well, otherwise there exists the following fatal error during GPU 
>> init,
>> change CONFIG_DRM_RADEON=y to CONFIG_DRM_RADEON=m to fix it.
>>
>> [    1.900997] [drm] Loading RS780 Microcode
>> [    1.905077] radeon 0000:01:05.0: Direct firmware load for 
>> radeon/RS780_pfp.bin failed with error -2
>> [    1.914140] r600_cp: Failed to load firmware "radeon/RS780_pfp.bin"
>> [    1.920405] [drm:r600_init] *ERROR* Failed to load firmware!
>> [    1.926069] radeon 0000:01:05.0: Fatal error during GPU init
>> [    1.931729] [drm] radeon: finishing device.
>>
>> Fixes: 024e6a8b5bb1 ("MIPS: Loongson: Add a Loongson-3 default config 
>> file")
>> Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
> [...]
>
> MBR, Sergei