From: Yingjoe Chen <yingjoe.chen@mediatek.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Marco Felsch <m.felsch@pengutronix.de>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
<linux-kernel@vger.kernel.org>,
<linux-mediatek@lists.infradead.org>,
Fengping Yu <fengping.yu@mediatek.com>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v8 2/3] drivers: input: keyboard: Add mtk keypad driver
Date: Sat, 16 May 2020 00:19:47 +0800 [thread overview]
Message-ID: <1589559587.28571.0.camel@mtksdaap41> (raw)
In-Reply-To: <20200515114044.GR185537@smile.fi.intel.com>
On Fri, 2020-05-15 at 14:40 +0300, Andy Shevchenko wrote:
> On Fri, May 15, 2020 at 11:30:16AM +0200, Marco Felsch wrote:
> > On 20-05-15 14:20, Fengping Yu wrote:
>
> ...
>
> > > + depends on OF && HAVE_CLK
> >
> > Please drop those deps and instead use:
>
> +1
>
> > depends on ARCH_MEDIATEK && ARM64
>
> I would go even further
> depends on (ARCH_MEDIATEK && ARM64) || COMPILE_TEST
Please drop ARM64. This works for 32bits SoC as well.
Joe.C
next prev parent reply other threads:[~2020-05-15 16:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-15 6:20 [PATCH v8] Add matrix keypad driver support for Mediatek SoCs Fengping Yu
[not found] ` <20200515062007.28346-3-fengping.yu@mediatek.com>
2020-05-15 9:30 ` [PATCH v8 2/3] drivers: input: keyboard: Add mtk keypad driver Marco Felsch
2020-05-15 11:40 ` Andy Shevchenko
2020-05-15 16:19 ` Yingjoe Chen [this message]
2020-05-15 11:38 ` [PATCH v8] Add matrix keypad driver support for Mediatek SoCs Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1589559587.28571.0.camel@mtksdaap41 \
--to=yingjoe.chen@mediatek.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=dmitry.torokhov@gmail.com \
--cc=fengping.yu@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=m.felsch@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).