From: "MyungJoo Ham" <myungjoo.ham@samsung.com>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
"Stephen Rothwell" <sfr@canb.auug.org.au>
Cc: "linux-next@vger.kernel.org" <linux-next@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Krzysztof Kozlowski" <k.kozlowski@samsung.com>,
"Chanwoo Choi" <cw00.choi@samsung.com>
Subject: RE: Re: linux-next: build failure after merge of the pm tree
Date: Mon, 19 Sep 2016 07:37:24 +0000 [thread overview]
Message-ID: <1589961933.1419204.1474270644855.JavaMail.weblogic@ep1ml103c> (raw)
In-Reply-To: CGME20160914213244epcas1p12dc9e18680105107404e1715ebcd40f8@epcas1p1.samsung.com
[-- Attachment #1: Type: text/plain, Size: 2196 bytes --]
> On Wednesday, September 14, 2016 02:27:47 PM Stephen Rothwell wrote:
> > Hi Rafael,
> >
> > After merging the pm tree, today's linux-next build (powerpc allyesconfig)
> > failed like this:
> >
> > drivers/devfreq/tegra-devfreq.c: In function 'tegra_devfreq_target':
> > drivers/devfreq/tegra-devfreq.c:500:2: error: implicit declaration of function 'clk_set_min_rate' [-Werror=implicit-function-declaration]
> > clk_set_min_rate(tegra->emc_clock, rate);
> > ^
> >
> > Caused by commit
> >
> > 797da5598f3a ("PM / devfreq: Add COMPILE_TEST for build coverage")
@Rafael: Thank you!
@Kozlowski:
It looks like COMMON_CLK is required to be "selected" for TEGRA.
Although COMMON_CLK is supposed to be widely used by most ARM platforms
especially if "Multiple platfrom selection" for ARMv7 is used,
COMPILE_TEST won't recognize it.
Adding COMMON_CLK for TEGRA will solve this instance of issue; however,
for COMPILE_TEST to be reasonably robust, each "COMPILE_TEST"ed item
should "select" every required item. How do you want to proceed with
COMPILE_TEST on SoC-specific device drivers?
Cheers,
MyungJoo.
> >
> > clk_set_min_rate() usage depends on CONFIG_HAVE_CLK.
> >
> > I added the following for today:
> >
> > From: Stephen Rothwell <sfr@canb.auug.org.au>
> > Date: Wed, 14 Sep 2016 14:22:25 +1000
> > Subject: [PATCH] partial revert of 797da5598f3a ("PM / devfreq: Add
> > COMPILE_TEST for build coverage")
> >
> > Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> > ---
> > drivers/devfreq/Kconfig | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/devfreq/Kconfig b/drivers/devfreq/Kconfig
> > index cadd56e50b2c..93b6ada06676 100644
> > --- a/drivers/devfreq/Kconfig
> > +++ b/drivers/devfreq/Kconfig
> > @@ -92,7 +92,7 @@ config ARM_EXYNOS_BUS_DEVFREQ
> >
> > config ARM_TEGRA_DEVFREQ
> > tristate "Tegra DEVFREQ Driver"
> > - depends on ARCH_TEGRA_124_SOC || COMPILE_TEST
> > + depends on ARCH_TEGRA_124_SOC
> > select DEVFREQ_GOV_SIMPLE_ONDEMAND
> > select PM_OPP
> > help
>
> I've just gone ahead and applied it.
>
> Thanks Stephen!
>
next prev parent reply other threads:[~2016-09-19 7:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-14 4:27 linux-next: build failure after merge of the pm tree Stephen Rothwell
2016-09-14 21:38 ` Rafael J. Wysocki
[not found] ` <CGME20160914213244epcas1p12dc9e18680105107404e1715ebcd40f8@epcas1p1.samsung.com>
2016-09-19 7:37 ` MyungJoo Ham [this message]
2016-09-19 16:12 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1589961933.1419204.1474270644855.JavaMail.weblogic@ep1ml103c \
--to=myungjoo.ham@samsung.com \
--cc=cw00.choi@samsung.com \
--cc=k.kozlowski@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).