From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD4FDC433DF for ; Thu, 28 May 2020 01:56:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 92FE8207CB for ; Thu, 28 May 2020 01:56:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1590631014; bh=JPh9VqWlO6/GEoqC3u2uYd8L4jEnjtFsdsbXczjP7Bg=; h=In-Reply-To:References:Subject:From:Cc:To:Date:List-ID:From; b=JhaEG/mScjwN65lWu+YzhSK+2jjfNZ3BtY+vgWCrIe0/Kn04ZnqxD04al5WvSlycP xtgNckeEDnszQaTYdA6YuIcPYTaaGPlz4dl4wCRD1CVUkCcIPO9QSHxaa24ERdrBwq IOG+FqMC9v7Fh3+/7kx4p0upU7M0LLP/seOoOkVU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726927AbgE1B4y (ORCPT ); Wed, 27 May 2020 21:56:54 -0400 Received: from mail.kernel.org ([198.145.29.99]:52942 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725849AbgE1B4x (ORCPT ); Wed, 27 May 2020 21:56:53 -0400 Received: from kernel.org (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1E2B0207CB; Thu, 28 May 2020 01:56:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1590631013; bh=JPh9VqWlO6/GEoqC3u2uYd8L4jEnjtFsdsbXczjP7Bg=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=N23kTYfh52xFeon1etjkNSjhcqiIQGJS5S7hkM/TEUVQlE6jTdhUBuoK4o+FePJqy jO0kUfDvkWytrKDtzowKTt2cetZ/VzY5suJrFV9XfxYgWLf8sYeVpk8Mgb0tl2WDmy o8GPys9KmPYJsPIY4FC1adLbIz3nGTGUKEKhe1/4= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <1590582292-13314-6-git-send-email-sivaprak@codeaurora.org> References: <1590582292-13314-1-git-send-email-sivaprak@codeaurora.org> <1590582292-13314-6-git-send-email-sivaprak@codeaurora.org> Subject: Re: [PATCH V6 5/5] arm64: dts: ipq6018: Add support for apss pll From: Stephen Boyd Cc: Sivaprakash Murugesan To: Sivaprakash Murugesan , agross@kernel.org, bjorn.andersson@linaro.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, mturquette@baylibre.com, robh+dt@kernel.org Date: Wed, 27 May 2020 18:56:52 -0700 Message-ID: <159063101240.69627.8166973936029543160@swboyd.mtv.corp.google.com> User-Agent: alot/0.9 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Sivaprakash Murugesan (2020-05-27 05:24:52) > Enable apss pll support. >=20 > Signed-off-by: Sivaprakash Murugesan > --- > [V6] > * split the mailbox driver from this patch > arch/arm64/boot/dts/qcom/ipq6018.dtsi | 8 ++++++++ > 1 file changed, 8 insertions(+) >=20 > diff --git a/arch/arm64/boot/dts/qcom/ipq6018.dtsi b/arch/arm64/boot/dts/= qcom/ipq6018.dtsi > index 1aa8d85..3956e44 100644 > --- a/arch/arm64/boot/dts/qcom/ipq6018.dtsi > +++ b/arch/arm64/boot/dts/qcom/ipq6018.dtsi > @@ -300,6 +300,14 @@ > #mbox-cells =3D <1>; > }; > =20 > + apsspll: clock@b116000 { > + compatible =3D "qcom,ipq6018-a53pll"; > + reg =3D <0x0b116000 0x40>; > + #clock-cells =3D <0>; > + clocks =3D <&xo>; > + clock-names =3D "xo"; > + }; > + I'd expect to see this inside an soc node. Also this doesn't go via clk tree so don't send it with the clk patches. > timer { > compatible =3D "arm,armv8-timer"; > interrupts =3D ,