From: Huazhong Tan <tanhuazhong@huawei.com>
To: <davem@davemloft.net>
Cc: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<salil.mehta@huawei.com>, <yisen.zhuang@huawei.com>,
<linuxarm@huawei.com>, <kuba@kernel.org>,
Huazhong Tan <tanhuazhong@huawei.com>
Subject: [PATCH net-next 12/12] net: hns3: print out speed info when parsing speed fails
Date: Thu, 28 May 2020 21:48:19 +0800 [thread overview]
Message-ID: <1590673699-63819-13-git-send-email-tanhuazhong@huawei.com> (raw)
In-Reply-To: <1590673699-63819-1-git-send-email-tanhuazhong@huawei.com>
When calling hclge_parse_speed() fails, printing out the speed is
helpful for debugging.
Signed-off-by: Huazhong Tan <tanhuazhong@huawei.com>
---
drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c
index 1e4f285..96bfad5 100644
--- a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c
+++ b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c
@@ -1387,7 +1387,8 @@ static int hclge_configure(struct hclge_dev *hdev)
ret = hclge_parse_speed(cfg.default_speed, &hdev->hw.mac.speed);
if (ret) {
- dev_err(&hdev->pdev->dev, "Get wrong speed ret=%d.\n", ret);
+ dev_err(&hdev->pdev->dev, "failed to parse speed %u, ret = %d\n",
+ cfg.default_speed, ret);
return ret;
}
--
2.7.4
next prev parent reply other threads:[~2020-05-28 13:52 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-28 13:48 [PATCH net-next 00/12] net: hns3: misc updates for -next Huazhong Tan
2020-05-28 13:48 ` [PATCH net-next 01/12] net: hns3: remove an unnecessary 'goto' in hclge_init_ae_dev() Huazhong Tan
2020-05-28 13:48 ` [PATCH net-next 02/12] net: hns3: add a missing mutex destroy in hclge_init_ad_dev() Huazhong Tan
2020-05-28 13:48 ` [PATCH net-next 03/12] net: hns3: refactor hclge_config_tso() Huazhong Tan
2020-05-28 13:48 ` [PATCH net-next 04/12] net: hns3: refactor hclge_query_bd_num_cmd_send() Huazhong Tan
2020-05-28 13:48 ` [PATCH net-next 05/12] net: hns3: modify an incorrect type in struct hclge_cfg_gro_status_cmd Huazhong Tan
2020-05-28 13:48 ` [PATCH net-next 06/12] net: hns3: modify an incorrect type in struct hclgevf_cfg_gro_status_cmd Huazhong Tan
2020-05-28 13:48 ` [PATCH net-next 07/12] net: hns3: remove some unused fields in struct hns3_nic_priv Huazhong Tan
2020-05-28 13:48 ` [PATCH net-next 08/12] net: hns3; remove unused HNAE3_RESTORE_CLIENT in enum hnae3_reset_notify_type Huazhong Tan
2020-05-28 13:48 ` [PATCH net-next 09/12] net: hns3: remove unused struct hnae3_unic_private_info Huazhong Tan
2020-05-28 13:48 ` [PATCH net-next 10/12] net: hns3: remove two duplicated register macros in hclgevf_main.h Huazhong Tan
2020-05-28 13:48 ` [PATCH net-next 11/12] net: hns3: remove some unused fields in struct hclge_dev Huazhong Tan
2020-05-28 13:48 ` Huazhong Tan [this message]
2020-05-28 23:39 ` [PATCH net-next 00/12] net: hns3: misc updates for -next David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1590673699-63819-13-git-send-email-tanhuazhong@huawei.com \
--to=tanhuazhong@huawei.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=salil.mehta@huawei.com \
--cc=yisen.zhuang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).