* [PATCH] userfaultfd: eliminate meaningless check in userfaultfd_register()
@ 2020-06-01 11:55 linmiaohe
0 siblings, 0 replies; only message in thread
From: linmiaohe @ 2020-06-01 11:55 UTC (permalink / raw)
To: viro; +Cc: linux-fsdevel, linux-kernel, linmiaohe
From: Miaohe Lin <linmiaohe@huawei.com>
When we reach here, !(cur->vm_flags & VM_MAYWRITE) is already checked and
equals to false. So the condition here always equals to false and should
be eliminated.
Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
---
fs/userfaultfd.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/fs/userfaultfd.c b/fs/userfaultfd.c
index e39fdec8a0b0..e529e6bbb57b 100644
--- a/fs/userfaultfd.c
+++ b/fs/userfaultfd.c
@@ -1409,8 +1409,6 @@ static int userfaultfd_register(struct userfaultfd_ctx *ctx,
if (end & (vma_hpagesize - 1))
goto out_unlock;
}
- if ((vm_flags & VM_UFFD_WP) && !(cur->vm_flags & VM_MAYWRITE))
- goto out_unlock;
/*
* Check that this vma isn't already owned by a
--
2.19.1
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2020-06-01 11:51 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-01 11:55 [PATCH] userfaultfd: eliminate meaningless check in userfaultfd_register() linmiaohe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).