* [PATCH] arm64: debug: mark a function as __init to save some memory
@ 2020-05-31 11:00 Christophe JAILLET
2020-06-02 20:40 ` Doug Anderson
2020-06-04 17:25 ` Will Deacon
0 siblings, 2 replies; 3+ messages in thread
From: Christophe JAILLET @ 2020-05-31 11:00 UTC (permalink / raw)
To: catalin.marinas, will, tglx, paulmck, gregkh, mhiramat, dianders
Cc: linux-arm-kernel, linux-kernel, kernel-janitors, Christophe JAILLET
'debug_monitors_init()' is only called via 'postcore_initcall'.
It can be marked as __init to save a few bytes of memory.
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
arch/arm64/kernel/debug-monitors.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/kernel/debug-monitors.c b/arch/arm64/kernel/debug-monitors.c
index 15e80c876d46..5df49366e9ab 100644
--- a/arch/arm64/kernel/debug-monitors.c
+++ b/arch/arm64/kernel/debug-monitors.c
@@ -130,7 +130,7 @@ static int clear_os_lock(unsigned int cpu)
return 0;
}
-static int debug_monitors_init(void)
+static int __init debug_monitors_init(void)
{
return cpuhp_setup_state(CPUHP_AP_ARM64_DEBUG_MONITORS_STARTING,
"arm64/debug_monitors:starting",
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: debug: mark a function as __init to save some memory
2020-05-31 11:00 [PATCH] arm64: debug: mark a function as __init to save some memory Christophe JAILLET
@ 2020-06-02 20:40 ` Doug Anderson
2020-06-04 17:25 ` Will Deacon
1 sibling, 0 replies; 3+ messages in thread
From: Doug Anderson @ 2020-06-02 20:40 UTC (permalink / raw)
To: Christophe JAILLET
Cc: Catalin Marinas, Will Deacon, Thomas Gleixner, paulmck,
Greg Kroah-Hartman, Masami Hiramatsu, Linux ARM, LKML,
kernel-janitors
Hi,
On Sun, May 31, 2020 at 4:00 AM Christophe JAILLET
<christophe.jaillet@wanadoo.fr> wrote:
>
> 'debug_monitors_init()' is only called via 'postcore_initcall'.
> It can be marked as __init to save a few bytes of memory.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> arch/arm64/kernel/debug-monitors.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Seems OK to me.
Reviewed-by: Douglas Anderson <dianders@chromium.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: debug: mark a function as __init to save some memory
2020-05-31 11:00 [PATCH] arm64: debug: mark a function as __init to save some memory Christophe JAILLET
2020-06-02 20:40 ` Doug Anderson
@ 2020-06-04 17:25 ` Will Deacon
1 sibling, 0 replies; 3+ messages in thread
From: Will Deacon @ 2020-06-04 17:25 UTC (permalink / raw)
To: catalin.marinas, mhiramat, Christophe JAILLET, gregkh, paulmck,
tglx, dianders
Cc: Will Deacon, kernel-janitors, linux-arm-kernel, linux-kernel
On Sun, 31 May 2020 13:00:15 +0200, Christophe JAILLET wrote:
> 'debug_monitors_init()' is only called via 'postcore_initcall'.
> It can be marked as __init to save a few bytes of memory.
Applied to arm64 (for-next/core), thanks!
[1/1] arm64: debug: mark a function as __init to save some memory
https://git.kernel.org/arm64/c/5311ebfb612f
Cheers,
--
Will
https://fixes.arm64.dev
https://next.arm64.dev
https://will.arm64.dev
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-06-04 17:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-31 11:00 [PATCH] arm64: debug: mark a function as __init to save some memory Christophe JAILLET
2020-06-02 20:40 ` Doug Anderson
2020-06-04 17:25 ` Will Deacon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).