From: Mimi Zohar <firstname.lastname@example.org>
To: Bruno Meneguele <email@example.com>
Cc: Roberto Sassu <firstname.lastname@example.org>,
Subject: Re: [PATCH 2/2] ima: Call ima_calc_boot_aggregate() in ima_eventdigest_init()
Date: Thu, 04 Jun 2020 15:35:20 -0400 [thread overview]
Message-ID: <email@example.com> (raw)
On Thu, 2020-06-04 at 16:12 -0300, Bruno Meneguele wrote:
> On Wed, Jun 03, 2020 at 06:03:35PM -0400, Mimi Zohar wrote:
> > Hi Roberto,
> > On Wed, 2020-06-03 at 17:08 +0200, Roberto Sassu wrote:
> > > If the template field 'd' is chosen and the digest to be added to the
> > > measurement entry was not calculated with SHA1 or MD5, it is
> > > recalculated with SHA1, by using the passed file descriptor. However, this
> > > cannot be done for boot_aggregate, because there is no file descriptor.
> > >
> > > This patch adds a call to ima_calc_boot_aggregate() in
> > > ima_eventdigest_init(), so that the digest can be recalculated also for the
> > > boot_aggregate entry.
> > >
> > > Cc: firstname.lastname@example.org # 3.13.x
> > > Fixes: 3ce1217d6cd5d ("ima: define template fields library and new helpers")
> > > Reported-by: Takashi Iwai <email@example.com>
> > > Signed-off-by: Roberto Sassu <firstname.lastname@example.org>
> > Thanks, Roberto.
> > I've pushed both patches out to the next-integrity branch and would
> > appreciate some additional testing.
> > thanks,
> > Mimi
> Hi Mimi and Roberto,
> FWIW, I've tested this patch manually and things went fine, with no
> unexpected behavior or results.
> However, wouldn't it be worth add a note in kmsg about the
> ima_calc_boot_aggregate() being called with an algo different from the
> system's default? Just to let the user know he won't find a sha256 when
> check the measurement. But that's something we can add later too.
There's no guarantees that the IMA default crypto algorithm will be
used for calculating the boot_aggregate. The algorithm is dependent
on the TPM. For example, the default IMA algorithm could be sha256,
but on a system with TPM 1.2, the boot_aggregate would have to be
This patch addresses a mismatch between the template format field ('d'
field) and the larger digest. We could require the "ima_template_fmt"
specified on the boot command line define an appropriate format, but
Roberto decided to support the situation where both "d" and "d-ng" are
next prev parent reply other threads:[~2020-06-04 19:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-03 15:08 [PATCH 1/2] ima: Directly assign the ima_default_policy pointer to ima_rules Roberto Sassu
2020-06-03 15:08 ` [PATCH 2/2] ima: Call ima_calc_boot_aggregate() in ima_eventdigest_init() Roberto Sassu
2020-06-03 22:03 ` Mimi Zohar
2020-06-04 19:12 ` Bruno Meneguele
2020-06-04 19:35 ` Mimi Zohar [this message]
2020-06-04 19:57 ` Bruno Meneguele
2020-06-03 21:30 ` [PATCH 1/2] ima: Directly assign the ima_default_policy pointer to ima_rules Mimi Zohar
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).