From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14093C433E6 for ; Fri, 5 Jun 2020 14:41:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E5220206DC for ; Fri, 5 Jun 2020 14:41:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728235AbgFEOlF convert rfc822-to-8bit (ORCPT ); Fri, 5 Jun 2020 10:41:05 -0400 Received: from mail.fireflyinternet.com ([109.228.58.192]:63184 "EHLO fireflyinternet.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727113AbgFEOlE (ORCPT ); Fri, 5 Jun 2020 10:41:04 -0400 X-Default-Received-SPF: pass (skip=forwardok (res=PASS)) x-ip-name=78.156.65.138; Received: from localhost (unverified [78.156.65.138]) by fireflyinternet.com (Firefly Internet (M1)) with ESMTP (TLS) id 21408010-1500050 for multiple; Fri, 05 Jun 2020 15:40:48 +0100 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT In-Reply-To: <202006050718.9D4FCFC2E@keescook> References: <202006050718.9D4FCFC2E@keescook> Cc: intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Joe Perches From: Chris Wilson To: Daniel Vetter , David Airlie , Kees Cook Subject: Re: [Intel-gfx] [PATCH] drm/i915: Fix comments mentioning typo in IS_ENABLED() Message-ID: <159136804617.22562.13050948656630993484@build.alporthouse.com> User-Agent: alot/0.8.1 Date: Fri, 05 Jun 2020 15:40:46 +0100 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Kees Cook (2020-06-05 15:19:53) > This has no code changes, but the typo is clearly getting copy/pasted, > so better to avoid this now and fix the typo. IS_ENABLED() takes full > names, and must have the "CONFIG_" prefix. > > Reported-by: Joe Perches > Link: https://lore.kernel.org/lkml/b08611018fdb6d88757c6008a5c02fa0e07b32fb.camel@perches.com > Signed-off-by: Kees Cook Reviewed-by: Chris Wilson -Chris