[PATCH 0/2] Add MSIOF support for R8A7742 SOC

[PATCH 0/2] Add MSIOF support for R8A7742 SOC

[Lad Prabhakar]

Hi All,

This patch series adds support for MSIOF on R8A7742 SOC.

Cheers,
Prabhakar

Lad Prabhakar (2):
  dt-bindings: spi: renesas,sh-msiof: Add r8a7742 support
  ARM: dts: r8a7742: Add MSIOF[0123] support

 .../devicetree/bindings/spi/renesas,sh-msiof.yaml  |  1 +
 arch/arm/boot/dts/r8a7742.dtsi                     | 64 ++++++++++++++++++++++
 2 files changed, 65 insertions(+)

-- 
2.7.4

[PATCH 1/2] dt-bindings: spi: renesas,sh-msiof: Add r8a7742 support

[Lad Prabhakar]

Document RZ/G1H (R8A7742) SoC bindings.

Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Reviewed-by: Marian-Cristian Rotariu <marian-cristian.rotariu.rb@bp.renesas.com>
---
 Documentation/devicetree/bindings/spi/renesas,sh-msiof.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/spi/renesas,sh-msiof.yaml b/Documentation/devicetree/bindings/spi/renesas,sh-msiof.yaml
index b6c1dd2..910be66 100644
--- a/Documentation/devicetree/bindings/spi/renesas,sh-msiof.yaml
+++ b/Documentation/devicetree/bindings/spi/renesas,sh-msiof.yaml
@@ -21,6 +21,7 @@ properties:
                                             # device
       - items:
           - enum:
+              - renesas,msiof-r8a7742       # RZ/G1H
               - renesas,msiof-r8a7743       # RZ/G1M
               - renesas,msiof-r8a7744       # RZ/G1N
               - renesas,msiof-r8a7745       # RZ/G1E
-- 
2.7.4

[PATCH 2/2] ARM: dts: r8a7742: Add MSIOF[0123] support

[Lad Prabhakar]

Add the DT nodes needed by MSIOF[0123] interfaces to the SoC dtsi.

Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Reviewed-by: Marian-Cristian Rotariu <marian-cristian.rotariu.rb@bp.renesas.com>
---
 arch/arm/boot/dts/r8a7742.dtsi | 64 ++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 64 insertions(+)

diff --git a/arch/arm/boot/dts/r8a7742.dtsi b/arch/arm/boot/dts/r8a7742.dtsi
index 08af9e2..08d89cf 100644
--- a/arch/arm/boot/dts/r8a7742.dtsi
+++ b/arch/arm/boot/dts/r8a7742.dtsi
@@ -853,6 +853,70 @@
 			status = "disabled";
 		};
 
+		msiof0: spi@e6e20000 {
+			compatible = "renesas,msiof-r8a7742",
+				     "renesas,rcar-gen2-msiof";
+			reg = <0 0xe6e20000 0 0x0064>;
+			interrupts = <GIC_SPI 156 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&cpg CPG_MOD 0>;
+			dmas = <&dmac0 0x51>, <&dmac0 0x52>,
+			       <&dmac1 0x51>, <&dmac1 0x52>;
+			dma-names = "tx", "rx", "tx", "rx";
+			power-domains = <&sysc R8A7742_PD_ALWAYS_ON>;
+			resets = <&cpg 0>;
+			#address-cells = <1>;
+			#size-cells = <0>;
+			status = "disabled";
+		};
+
+		msiof1: spi@e6e10000 {
+			compatible = "renesas,msiof-r8a7742",
+				     "renesas,rcar-gen2-msiof";
+			reg = <0 0xe6e10000 0 0x0064>;
+			interrupts = <GIC_SPI 157 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&cpg CPG_MOD 208>;
+			dmas = <&dmac0 0x55>, <&dmac0 0x56>,
+			       <&dmac1 0x55>, <&dmac1 0x56>;
+			dma-names = "tx", "rx", "tx", "rx";
+			power-domains = <&sysc R8A7742_PD_ALWAYS_ON>;
+			resets = <&cpg 208>;
+			#address-cells = <1>;
+			#size-cells = <0>;
+			status = "disabled";
+		};
+
+		msiof2: spi@e6e00000 {
+			compatible = "renesas,msiof-r8a7742",
+				     "renesas,rcar-gen2-msiof";
+			reg = <0 0xe6e00000 0 0x0064>;
+			interrupts = <GIC_SPI 158 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&cpg CPG_MOD 205>;
+			dmas = <&dmac0 0x41>, <&dmac0 0x42>,
+			       <&dmac1 0x41>, <&dmac1 0x42>;
+			dma-names = "tx", "rx", "tx", "rx";
+			power-domains = <&sysc R8A7742_PD_ALWAYS_ON>;
+			resets = <&cpg 205>;
+			#address-cells = <1>;
+			#size-cells = <0>;
+			status = "disabled";
+		};
+
+		msiof3: spi@e6c90000 {
+			compatible = "renesas,msiof-r8a7742",
+				     "renesas,rcar-gen2-msiof";
+			reg = <0 0xe6c90000 0 0x0064>;
+			interrupts = <GIC_SPI 159 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&cpg CPG_MOD 215>;
+			dmas = <&dmac0 0x45>, <&dmac0 0x46>,
+			       <&dmac1 0x45>, <&dmac1 0x46>;
+			dma-names = "tx", "rx", "tx", "rx";
+			power-domains = <&sysc R8A7742_PD_ALWAYS_ON>;
+			resets = <&cpg 215>;
+			#address-cells = <1>;
+			#size-cells = <0>;
+			status = "disabled";
+		};
+
 		rcar_sound: sound@ec500000 {
 			/*
 			 * #sound-dai-cells is required
-- 
2.7.4

Re: [PATCH 1/2] dt-bindings: spi: renesas,sh-msiof: Add r8a7742 support

[Geert Uytterhoeven]

On Tue, Jun 9, 2020 at 10:54 PM Lad Prabhakar
<prabhakar.mahadev-lad.rj@bp.renesas.com> wrote:
> Document RZ/G1H (R8A7742) SoC bindings.
>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> Reviewed-by: Marian-Cristian Rotariu <marian-cristian.rotariu.rb@bp.renesas.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH 1/2] dt-bindings: spi: renesas,sh-msiof: Add r8a7742 support

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 451 bytes --]

On Tue, Jun 09, 2020 at 09:54:13PM +0100, Lad Prabhakar wrote:
> Document RZ/G1H (R8A7742) SoC bindings.
> 
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> Reviewed-by: Marian-Cristian Rotariu <marian-cristian.rotariu.rb@bp.renesas.com>
> ---
>  Documentation/devicetree/bindings/spi/renesas,sh-msiof.yaml | 1 +
>  1 file changed, 1 insertion(+)

To repeat my previous feedback I'd expect a driver update as well.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH 1/2] dt-bindings: spi: renesas,sh-msiof: Add r8a7742 support

[Geert Uytterhoeven]

Hi Mark,

On Wed, Jun 10, 2020 at 1:08 PM Mark Brown <broonie@kernel.org> wrote:
> On Tue, Jun 09, 2020 at 09:54:13PM +0100, Lad Prabhakar wrote:
> > Document RZ/G1H (R8A7742) SoC bindings.
> >
> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> > Reviewed-by: Marian-Cristian Rotariu <marian-cristian.rotariu.rb@bp.renesas.com>
> > ---
> >  Documentation/devicetree/bindings/spi/renesas,sh-msiof.yaml | 1 +
> >  1 file changed, 1 insertion(+)
>
> To repeat my previous feedback I'd expect a driver update as well.

No driver update is needed.

Documentation/devicetree/bindings/spi/renesas,sh-msiof.yaml says:

  compatible:
    oneOf:
      - items:
          - enum:
             - renesas,msiof-r8a7742       # RZ/G1H
               ...
          - const: renesas,rcar-gen2-msiof  # generic R-Car Gen2 and RZ/G1
                                            # compatible device

drivers/spi/spi-sh-msiof.c matches against "renesas,rcar-gen2-msiof".

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH 1/2] dt-bindings: spi: renesas,sh-msiof: Add r8a7742 support

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 473 bytes --]

On Wed, Jun 10, 2020 at 01:59:24PM +0200, Geert Uytterhoeven wrote:
> On Wed, Jun 10, 2020 at 1:08 PM Mark Brown <broonie@kernel.org> wrote:

> > To repeat my previous feedback I'd expect a driver update as well.

> No driver update is needed.

> Documentation/devicetree/bindings/spi/renesas,sh-msiof.yaml says:

I'm much more comfortable explicitly listing the new compatible so that
even if someone makes a DT that doesn't bother listing the fallbacks
things will work.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH 1/2] dt-bindings: spi: renesas,sh-msiof: Add r8a7742 support

[Geert Uytterhoeven]

Hi Mark,

On Wed, Jun 10, 2020 at 6:49 PM Mark Brown <broonie@kernel.org> wrote:
> On Wed, Jun 10, 2020 at 01:59:24PM +0200, Geert Uytterhoeven wrote:
> > On Wed, Jun 10, 2020 at 1:08 PM Mark Brown <broonie@kernel.org> wrote:
> > > To repeat my previous feedback I'd expect a driver update as well.
>
> > No driver update is needed.
>
> > Documentation/devicetree/bindings/spi/renesas,sh-msiof.yaml says:
>
> I'm much more comfortable explicitly listing the new compatible so that
> even if someone makes a DT that doesn't bother listing the fallbacks
> things will work.

Adding all of them would cause even more churn when adding support for
a new SoC... There are already more than 700 "renesas," compatible
values documented that are not directly matched by drivers.
Nowadays we have "make dtbs_check", so if a DTS doesn't conform to the
binding, it will be flagged.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH 1/2] dt-bindings: spi: renesas,sh-msiof: Add r8a7742 support

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 842 bytes --]

On Wed, Jun 10, 2020 at 09:18:19PM +0200, Geert Uytterhoeven wrote:
> On Wed, Jun 10, 2020 at 6:49 PM Mark Brown <broonie@kernel.org> wrote:

> > I'm much more comfortable explicitly listing the new compatible so that
> > even if someone makes a DT that doesn't bother listing the fallbacks
> > things will work.

> Adding all of them would cause even more churn when adding support for
> a new SoC... There are already more than 700 "renesas," compatible
> values documented that are not directly matched by drivers.

I'm not sure it's a particular concern, especially since you'll be
sending this stuff in the same series as a bindings update and an extra
patch in a series makes very little difference.

> Nowadays we have "make dtbs_check", so if a DTS doesn't conform to the
> binding, it will be flagged.

For things that are upstream.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH 1/2] dt-bindings: spi: renesas,sh-msiof: Add r8a7742 support

[Geert Uytterhoeven]

Hi Mark,

On Thu, Jun 11, 2020 at 10:50 AM Mark Brown <broonie@kernel.org> wrote:
> On Wed, Jun 10, 2020 at 09:18:19PM +0200, Geert Uytterhoeven wrote:
> > On Wed, Jun 10, 2020 at 6:49 PM Mark Brown <broonie@kernel.org> wrote:
>
> > > I'm much more comfortable explicitly listing the new compatible so that
> > > even if someone makes a DT that doesn't bother listing the fallbacks
> > > things will work.
>
> > Adding all of them would cause even more churn when adding support for
> > a new SoC... There are already more than 700 "renesas," compatible
> > values documented that are not directly matched by drivers.
>
> I'm not sure it's a particular concern, especially since you'll be
> sending this stuff in the same series as a bindings update and an extra
> patch in a series makes very little difference.

Until the DT bindings are split off into their own project...

Listing unneeded compatible values in drivers also increases binary size.
For RSPI and MSIOF that would be +2.5 KiB each.  Times tens of drivers.

Considering the RSPI driver itself is only 9 KiB, and some RZ/A1 systems
are really memory-constrained, I think it's better to avoid that.

> > Nowadays we have "make dtbs_check", so if a DTS doesn't conform to the
> > binding, it will be flagged.
>
> For things that are upstream.

The DT bindings apply to out-of-tree DTS files, too ;-)
If they're not compliant, all odds are off.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH 0/2] Add MSIOF support for R8A7742 SOC

[Mark Brown]

On Tue, 9 Jun 2020 21:54:12 +0100, Lad Prabhakar wrote:
> This patch series adds support for MSIOF on R8A7742 SOC.
> 
> Cheers,
> Prabhakar
> 
> Lad Prabhakar (2):
>   dt-bindings: spi: renesas,sh-msiof: Add r8a7742 support
>   ARM: dts: r8a7742: Add MSIOF[0123] support
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next

Thanks!

[1/1] spi: renesas,sh-msiof: Add r8a7742 support
      commit: 6383b118efafff8cce8fc8fa5b7e893a523b698f

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

Re: [PATCH 1/2] dt-bindings: spi: renesas,sh-msiof: Add r8a7742 support

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 1249 bytes --]

On Thu, Jun 11, 2020 at 02:09:54PM +0200, Geert Uytterhoeven wrote:
> On Thu, Jun 11, 2020 at 10:50 AM Mark Brown <broonie@kernel.org> wrote:

> > I'm not sure it's a particular concern, especially since you'll be
> > sending this stuff in the same series as a bindings update and an extra
> > patch in a series makes very little difference.

> Until the DT bindings are split off into their own project...
> Listing unneeded compatible values in drivers also increases binary size.
> For RSPI and MSIOF that would be +2.5 KiB each.  Times tens of drivers.

> Considering the RSPI driver itself is only 9 KiB, and some RZ/A1 systems
> are really memory-constrained, I think it's better to avoid that.

That is an issue, though I can't help wondering if space constrained
systems could use some sort of automatic compaction of the ID tables
during install.  We're also bloating their DTs by adding fallbacks of
course!

> > > Nowadays we have "make dtbs_check", so if a DTS doesn't conform to the
> > > binding, it will be flagged.

> > For things that are upstream.

> The DT bindings apply to out-of-tree DTS files, too ;-)
> If they're not compliant, all odds are off.

The point here is to improve robustness and make the interface less
fragile.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH 2/2] ARM: dts: r8a7742: Add MSIOF[0123] support

[Geert Uytterhoeven]

On Tue, Jun 9, 2020 at 10:54 PM Lad Prabhakar
<prabhakar.mahadev-lad.rj@bp.renesas.com> wrote:
> Add the DT nodes needed by MSIOF[0123] interfaces to the SoC dtsi.
>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> Reviewed-by: Marian-Cristian Rotariu <marian-cristian.rotariu.rb@bp.renesas.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
i.e. will queue in renesas-devel for v5.9.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds