From: "Alex Xu (Hello71)" <alex_y_xu@yahoo.ca>
To: Christoph Hellwig <hch@lst.de>, David Rientjes <rientjes@google.com>
Cc: alsa-devel@alsa-project.org, bp@alien8.de, hch@infradead.org,
hpa@zytor.com, linux-kernel@vger.kernel.org, mingo@redhat.com,
Pavel Machek <pavel@ucw.cz>,
perex@perex.cz, tglx@linutronix.de, tiwai@suse.com,
x86@kernel.org
Subject: Re: [patch for-5.8] dma-pool: decouple DMA_REMAP from DMA_COHERENT_POOL
Date: Thu, 11 Jun 2020 10:49:53 -0400 [thread overview]
Message-ID: <1591886384.28dd734zt4.none@localhost> (raw)
In-Reply-To: <alpine.DEB.2.22.394.2006110025250.13899@chino.kir.corp.google.com>
Excerpts from David Rientjes's message of June 11, 2020 3:25 am:
> DMA_REMAP is an unnecessary requirement for AMD SEV, which requires
> DMA_COHERENT_POOL, so avoid selecting it when it is otherwise unnecessary.
>
> The only other requirement for DMA coherent pools is DMA_DIRECT_REMAP, so
> ensure that properly selects the config option when needed.
>
> Fixes: 82fef0ad811f ("x86/mm: unencrypted non-blocking DMA allocations use
> coherent pools")
> Suggested-by: Christoph Hellwig <hch@lst.de>
> Signed-off-by: David Rientjes <rientjes@google.com>
> ---
> kernel/dma/Kconfig | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
Works for me with SME on or off with af7b480103, and with SME off in
abfbb29297. There is some regression with amdgpu and SME between those
two points, I need to check that out too. I haven't tested either before
or after with SEV (which I'm not even sure my system supports).
Regardless, this is a definite improvement.
Tested-by: Alex Xu (Hello71) <alex_y_xu@yahoo.ca>
Thanks,
Alex.
next prev parent reply other threads:[~2020-06-11 14:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-11 7:25 [patch for-5.8] dma-pool: decouple DMA_REMAP from DMA_COHERENT_POOL David Rientjes
2020-06-11 14:49 ` Alex Xu (Hello71) [this message]
2020-06-15 6:36 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1591886384.28dd734zt4.none@localhost \
--to=alex_y_xu@yahoo.ca \
--cc=alsa-devel@alsa-project.org \
--cc=bp@alien8.de \
--cc=hch@infradead.org \
--cc=hch@lst.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pavel@ucw.cz \
--cc=perex@perex.cz \
--cc=rientjes@google.com \
--cc=tglx@linutronix.de \
--cc=tiwai@suse.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).