From: Stanley Chu <stanley.chu@mediatek.com>
To: Alim Akhtar <alim.akhtar@samsung.com>
Cc: <linux-scsi@vger.kernel.org>, <martin.petersen@oracle.com>,
<avri.altman@wdc.com>, <jejb@linux.ibm.com>,
<asutoshd@codeaurora.org>, <bvanassche@acm.org>,
<andy.teng@mediatek.com>, <cc.chou@mediatek.com>,
<chun-hung.wu@mediatek.com>, <kuohong.wang@mediatek.com>,
<linux-kernel@vger.kernel.org>, <cang@codeaurora.org>,
<linux-mediatek@lists.infradead.org>, <peter.wang@mediatek.com>,
<matthias.bgg@gmail.com>, <chaotian.jing@mediatek.com>,
<linux-arm-kernel@lists.infradead.org>, <beanhuo@micron.com>
Subject: RE: [PATCH v1 2/2] scsi: ufs: Cleanup device vendor and quirk definition
Date: Fri, 12 Jun 2020 09:27:18 +0800 [thread overview]
Message-ID: <1591925238.25636.40.camel@mtkswgap22> (raw)
In-Reply-To: <001d01d64005$d7564e20$8602ea60$@samsung.com>
Hi Alim,
On Thu, 2020-06-11 at 21:04 +0530, Alim Akhtar wrote:
> Hi Stanley
>
> > diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c index
> > dea4fddf9332..7c93cb446f51 100644
> > --- a/drivers/scsi/ufs/ufshcd.c
> > +++ b/drivers/scsi/ufs/ufshcd.c
> > @@ -219,10 +219,8 @@ static struct ufs_dev_fix ufs_fixups[] = {
> > UFS_FIX(UFS_VENDOR_MICRON, UFS_ANY_MODEL,
> > UFS_DEVICE_QUIRK_DELAY_BEFORE_LPM),
> > UFS_FIX(UFS_VENDOR_SAMSUNG, UFS_ANY_MODEL,
> > - UFS_DEVICE_QUIRK_DELAY_BEFORE_LPM),
> > - UFS_FIX(UFS_VENDOR_SAMSUNG, UFS_ANY_MODEL,
> > - UFS_DEVICE_QUIRK_RECOVERY_FROM_DL_NAC_ERRORS),
> > - UFS_FIX(UFS_VENDOR_SAMSUNG, UFS_ANY_MODEL,
> > + UFS_DEVICE_QUIRK_DELAY_BEFORE_LPM |
> > + UFS_DEVICE_QUIRK_RECOVERY_FROM_DL_NAC_ERRORS |
> > UFS_DEVICE_QUIRK_HOST_PA_TACTIVATE),
> > UFS_FIX(UFS_VENDOR_TOSHIBA, UFS_ANY_MODEL,
> > UFS_DEVICE_QUIRK_DELAY_BEFORE_LPM),
> > --
> While at this, may be arrange the table in alphabetical order.
Sure, fixed in v2.
Thanks for the review.
Stanley Chu
prev parent reply other threads:[~2020-06-12 1:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-10 5:36 [PATCH v1 0/2] scsi: ufs: Fix and cleanup device quirk Stanley Chu
2020-06-10 5:36 ` [PATCH v1 1/2] scsi: ufs: Add DELAY_BEFORE_LPM quirk for Micron devices Stanley Chu
2020-06-10 9:06 ` Bean Huo
2020-06-10 5:36 ` [PATCH v1 2/2] scsi: ufs: Cleanup device vendor and quirk definition Stanley Chu
2020-06-11 15:34 ` Alim Akhtar
2020-06-12 1:27 ` Stanley Chu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1591925238.25636.40.camel@mtkswgap22 \
--to=stanley.chu@mediatek.com \
--cc=alim.akhtar@samsung.com \
--cc=andy.teng@mediatek.com \
--cc=asutoshd@codeaurora.org \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=bvanassche@acm.org \
--cc=cang@codeaurora.org \
--cc=cc.chou@mediatek.com \
--cc=chaotian.jing@mediatek.com \
--cc=chun-hung.wu@mediatek.com \
--cc=jejb@linux.ibm.com \
--cc=kuohong.wang@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=matthias.bgg@gmail.com \
--cc=peter.wang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).