From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: linux-scsi@vger.kernel.org, jejb@linux.ibm.com,
avri.altman@wdc.com, Stanley Chu <stanley.chu@mediatek.com>,
asutoshd@codeaurora.org, alim.akhtar@samsung.com
Cc: "Martin K . Petersen" <martin.petersen@oracle.com>,
peter.wang@mediatek.com, beanhuo@micron.com,
matthias.bgg@gmail.com, bvanassche@acm.org,
linux-kernel@vger.kernel.org, andy.teng@mediatek.com,
cc.chou@mediatek.com, cang@codeaurora.org,
linux-arm-kernel@lists.infradead.org, kuohong.wang@mediatek.com,
chaotian.jing@mediatek.com, chun-hung.wu@mediatek.com,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH v5] scsi: ufs: Fix imprecise load calculation in devfreq window
Date: Mon, 15 Jun 2020 23:59:59 -0400 [thread overview]
Message-ID: <159227986423.24883.5364281872549678357.b4-ty@oracle.com> (raw)
In-Reply-To: <20200611101043.6379-1-stanley.chu@mediatek.com>
On Thu, 11 Jun 2020 18:10:43 +0800, Stanley Chu wrote:
> The UFS load calculation is based on "total_time" and "busy_time" in a
> devfreq window. However, the source of time is different for both
> parameters: "busy_time" is assigned from "jiffies" thus has different
> accuracy from "total_time" which is assigned from ktime_get().
>
> Besides, the time of window boundary is not exactly the same as
> the starting busy time in this window if UFS is actually busy
> in the beginning of the window. A similar accuracy error may also
> happen for the end of busy time in current window.
>
> [...]
Applied to 5.9/scsi-queue, thanks!
[1/1] scsi: ufs: Fix imprecise load calculation in devfreq window
https://git.kernel.org/mkp/scsi/c/b1bf66d1d5a8
--
Martin K. Petersen Oracle Linux Engineering
prev parent reply other threads:[~2020-06-16 4:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-11 10:10 [PATCH v5] scsi: ufs: Fix imprecise load calculation in devfreq window Stanley Chu
2020-06-16 3:59 ` Martin K. Petersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=159227986423.24883.5364281872549678357.b4-ty@oracle.com \
--to=martin.petersen@oracle.com \
--cc=alim.akhtar@samsung.com \
--cc=andy.teng@mediatek.com \
--cc=asutoshd@codeaurora.org \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=bvanassche@acm.org \
--cc=cang@codeaurora.org \
--cc=cc.chou@mediatek.com \
--cc=chaotian.jing@mediatek.com \
--cc=chun-hung.wu@mediatek.com \
--cc=jejb@linux.ibm.com \
--cc=kuohong.wang@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=peter.wang@mediatek.com \
--cc=stanley.chu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).