From: Mimi Zohar <zohar@linux.ibm.com>
To: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>,
vt@altlinux.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH ima-evm-utils 2/3] ima-evm-utils: beautify the code to make it more readable
Date: Wed, 08 Jul 2020 12:28:38 -0400 [thread overview]
Message-ID: <1594225718.23056.257.camel@linux.ibm.com> (raw)
In-Reply-To: <20200707033548.21640-2-tianjia.zhang@linux.alibaba.com>
On Tue, 2020-07-07 at 11:35 +0800, Tianjia Zhang wrote:
> @@ -625,7 +625,7 @@ int ima_verify_signature(const char *file, unsigned char *sig, int siglen,
> unsigned char hash[MAX_DIGEST_SIZE];
> int hashlen, sig_hash_algo;
>
> - if (sig[0] != 0x03) {
> + if (sig[0] != EVM_IMA_XATTR_DIGSIG) {
> log_err("xattr ima has no signature\n");
> return -1;
> }
This last hunk didn't apply properly. The error message now includes
the filename. I've fixed this patch. In the future, please post
patches against the next-testing branch.
thanks,
Mimi
next prev parent reply other threads:[~2020-07-08 16:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-07 3:35 [PATCH ima-evm-utils 1/3] ima-evm-utils: Fix mismatched type checking Tianjia Zhang
2020-07-07 3:35 ` [PATCH ima-evm-utils 2/3] ima-evm-utils: beautify the code to make it more readable Tianjia Zhang
2020-07-08 16:28 ` Mimi Zohar [this message]
2020-07-07 3:35 ` [PATCH ima-evm-utils 3/3] ima-evm-utils: ima_sign supports sm3 algorithm Tianjia Zhang
2020-07-08 16:37 ` Mimi Zohar
2020-07-08 14:01 ` [PATCH ima-evm-utils 1/3] ima-evm-utils: Fix mismatched type checking Mimi Zohar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1594225718.23056.257.camel@linux.ibm.com \
--to=zohar@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tianjia.zhang@linux.alibaba.com \
--cc=vt@altlinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).