* [PATCH] arm64: Add missing sentinel to erratum_1463225
@ 2020-07-09 5:13 Florian Fainelli
2020-07-09 5:21 ` Sai Prakash Ranjan
2020-07-09 9:54 ` Will Deacon
0 siblings, 2 replies; 3+ messages in thread
From: Florian Fainelli @ 2020-07-09 5:13 UTC (permalink / raw)
To: linux-kernel, linux-arm-kernel
Cc: Florian Fainelli, Catalin Marinas, Will Deacon, Marc Zyngier,
Steven Price, Suzuki K Poulose, Sai Prakash Ranjan, Mark Brown,
James Morse, Mark Rutland, Andrew Scull
When the erratum_1463225 array was introduced a sentinel at the end was
missing thus causing a KASAN: global-out-of-bounds in
is_affected_midr_range_list on arm64 error.
Link: https://lore.kernel.org/linux-arm-kernel/CA+G9fYs3EavpU89-rTQfqQ9GgxAMgMAk7jiiVrfP0yxj5s+Q6g@mail.gmail.com/
Fixes: a9e821b89daa ("arm64: Add KRYO4XX gold CPU cores to erratum list 1463225 and 1418040")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
arch/arm64/kernel/cpu_errata.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/kernel/cpu_errata.c b/arch/arm64/kernel/cpu_errata.c
index 8e302dc093d0..79728bfb5351 100644
--- a/arch/arm64/kernel/cpu_errata.c
+++ b/arch/arm64/kernel/cpu_errata.c
@@ -782,6 +782,7 @@ static const struct midr_range erratum_1463225[] = {
MIDR_RANGE(MIDR_CORTEX_A76, 0, 0, 3, 1),
/* Kryo4xx Gold (rcpe to rfpf) => (r0p0 to r3p1) */
MIDR_RANGE(MIDR_QCOM_KRYO_4XX_GOLD, 0xc, 0xe, 0xf, 0xf),
+ {},
};
#endif
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: Add missing sentinel to erratum_1463225
2020-07-09 5:13 [PATCH] arm64: Add missing sentinel to erratum_1463225 Florian Fainelli
@ 2020-07-09 5:21 ` Sai Prakash Ranjan
2020-07-09 9:54 ` Will Deacon
1 sibling, 0 replies; 3+ messages in thread
From: Sai Prakash Ranjan @ 2020-07-09 5:21 UTC (permalink / raw)
To: Florian Fainelli
Cc: linux-kernel, linux-arm-kernel, Catalin Marinas, Will Deacon,
Marc Zyngier, Steven Price, Suzuki K Poulose, Mark Brown,
James Morse, Mark Rutland, Andrew Scull
Hi Florian,
On 2020-07-09 10:43, Florian Fainelli wrote:
> When the erratum_1463225 array was introduced a sentinel at the end was
> missing thus causing a KASAN: global-out-of-bounds in
> is_affected_midr_range_list on arm64 error.
>
> Link:
> https://lore.kernel.org/linux-arm-kernel/CA+G9fYs3EavpU89-rTQfqQ9GgxAMgMAk7jiiVrfP0yxj5s+Q6g@mail.gmail.com/
> Fixes: a9e821b89daa ("arm64: Add KRYO4XX gold CPU cores to erratum
> list 1463225 and 1418040")
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
> arch/arm64/kernel/cpu_errata.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/kernel/cpu_errata.c
> b/arch/arm64/kernel/cpu_errata.c
> index 8e302dc093d0..79728bfb5351 100644
> --- a/arch/arm64/kernel/cpu_errata.c
> +++ b/arch/arm64/kernel/cpu_errata.c
> @@ -782,6 +782,7 @@ static const struct midr_range erratum_1463225[] =
> {
> MIDR_RANGE(MIDR_CORTEX_A76, 0, 0, 3, 1),
> /* Kryo4xx Gold (rcpe to rfpf) => (r0p0 to r3p1) */
> MIDR_RANGE(MIDR_QCOM_KRYO_4XX_GOLD, 0xc, 0xe, 0xf, 0xf),
> + {},
> };
> #endif
My bad missing this, thanks for the fix.
Reviewed-by: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a
member
of Code Aurora Forum, hosted by The Linux Foundation
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: Add missing sentinel to erratum_1463225
2020-07-09 5:13 [PATCH] arm64: Add missing sentinel to erratum_1463225 Florian Fainelli
2020-07-09 5:21 ` Sai Prakash Ranjan
@ 2020-07-09 9:54 ` Will Deacon
1 sibling, 0 replies; 3+ messages in thread
From: Will Deacon @ 2020-07-09 9:54 UTC (permalink / raw)
To: Florian Fainelli, linux-arm-kernel, linux-kernel
Cc: catalin.marinas, kernel-team, Will Deacon, Marc Zyngier,
Suzuki K Poulose, Sai Prakash Ranjan, James Morse, Steven Price,
Mark Brown, Mark Rutland, Andrew Scull
On Wed, 8 Jul 2020 22:13:40 -0700, Florian Fainelli wrote:
> When the erratum_1463225 array was introduced a sentinel at the end was
> missing thus causing a KASAN: global-out-of-bounds in
> is_affected_midr_range_list on arm64 error.
Applied to arm64 (for-next/fixes), thanks!
[1/1] arm64: Add missing sentinel to erratum_1463225
https://git.kernel.org/arm64/c/09c717c92b52
Cheers,
--
Will
https://fixes.arm64.dev
https://next.arm64.dev
https://will.arm64.dev
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-07-09 9:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-09 5:13 [PATCH] arm64: Add missing sentinel to erratum_1463225 Florian Fainelli
2020-07-09 5:21 ` Sai Prakash Ranjan
2020-07-09 9:54 ` Will Deacon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).