* [PATCH] drm/i915: Don't force IOSF_MBI
@ 2020-07-17 6:11 Jisheng Zhang
2020-07-17 19:32 ` Chris Wilson
0 siblings, 1 reply; 3+ messages in thread
From: Jisheng Zhang @ 2020-07-17 6:11 UTC (permalink / raw)
To: Jani Nikula, Joonas Lahtinen, Rodrigo Vivi, David Airlie, Daniel Vetter
Cc: intel-gfx, dri-devel, linux-kernel
The i915 doesn't depend on IOSF_MBI, asm/iosf_mbi.h already defines
isof_mbi_* APIs when ISOF_MBI is disabled.
Don't force IOSF_MBI to allow disabling IOSF_MBI for non SoC platforms.
Signed-off-by: Jisheng Zhang <Jisheng.Zhang@synaptics.com>
---
drivers/gpu/drm/i915/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/Kconfig b/drivers/gpu/drm/i915/Kconfig
index 9afa5c4a6bf0..b76874989292 100644
--- a/drivers/gpu/drm/i915/Kconfig
+++ b/drivers/gpu/drm/i915/Kconfig
@@ -21,7 +21,6 @@ config DRM_I915
select ACPI_VIDEO if ACPI
select ACPI_BUTTON if ACPI
select SYNC_FILE
- select IOSF_MBI
select CRC32
select SND_HDA_I915 if SND_HDA_CORE
select CEC_CORE if CEC_NOTIFIER
--
2.28.0.rc0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/i915: Don't force IOSF_MBI
2020-07-17 6:11 [PATCH] drm/i915: Don't force IOSF_MBI Jisheng Zhang
@ 2020-07-17 19:32 ` Chris Wilson
2020-07-20 9:29 ` Jisheng Zhang
0 siblings, 1 reply; 3+ messages in thread
From: Chris Wilson @ 2020-07-17 19:32 UTC (permalink / raw)
To: Daniel Vetter, David Airlie, Jani Nikula, Jisheng Zhang,
Joonas Lahtinen, Rodrigo Vivi
Cc: intel-gfx, dri-devel, linux-kernel
Quoting Jisheng Zhang (2020-07-17 07:11:38)
> The i915 doesn't depend on IOSF_MBI, asm/iosf_mbi.h already defines
> isof_mbi_* APIs when ISOF_MBI is disabled.
>
> Don't force IOSF_MBI to allow disabling IOSF_MBI for non SoC platforms.
But it is required for Valleyview/Cherryview and we want to support
those by default. Tricky.
-Chris
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/i915: Don't force IOSF_MBI
2020-07-17 19:32 ` Chris Wilson
@ 2020-07-20 9:29 ` Jisheng Zhang
0 siblings, 0 replies; 3+ messages in thread
From: Jisheng Zhang @ 2020-07-20 9:29 UTC (permalink / raw)
To: Chris Wilson
Cc: Daniel Vetter, David Airlie, Jani Nikula, Joonas Lahtinen,
Rodrigo Vivi, intel-gfx, dri-devel, linux-kernel
On Fri, 17 Jul 2020 20:32:44 +0100 Chris Wilson wrote:
>
>
> Quoting Jisheng Zhang (2020-07-17 07:11:38)
> > The i915 doesn't depend on IOSF_MBI, asm/iosf_mbi.h already defines
> > isof_mbi_* APIs when ISOF_MBI is disabled.
> >
> > Don't force IOSF_MBI to allow disabling IOSF_MBI for non SoC platforms.
>
> But it is required for Valleyview/Cherryview and we want to support
> those by default. Tricky.
If linux kernel is built for Valleyview/Cherryview, ISOF_MBI has to be
enabled. The dependency is met there.
Thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-07-20 9:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-17 6:11 [PATCH] drm/i915: Don't force IOSF_MBI Jisheng Zhang
2020-07-17 19:32 ` Chris Wilson
2020-07-20 9:29 ` Jisheng Zhang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).