linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] Documentation: driver-api: update kernel connector
@ 2020-07-20  7:24 Wang Long
  2020-07-23 20:06 ` Jonathan Corbet
  0 siblings, 1 reply; 2+ messages in thread
From: Wang Long @ 2020-07-20  7:24 UTC (permalink / raw)
  To: corbet; +Cc: w, linux-doc, linux-kernel

This patch changes:
1) Fix typo in kernel connector documentation.
	s/cn_netlink_send_multi/cn_netlink_send_mult/
2) update definition of struct cn_msg

Signed-off-by: Wang Long <w@laoqinren.net>
---
 Documentation/driver-api/connector.rst | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/Documentation/driver-api/connector.rst b/Documentation/driver-api/connector.rst
index c100c74..23d06819 100644
--- a/Documentation/driver-api/connector.rst
+++ b/Documentation/driver-api/connector.rst
@@ -26,7 +26,7 @@ netlink based networking for inter-process communication in a significantly
 easier way::
 
   int cn_add_callback(struct cb_id *id, char *name, void (*callback) (struct cn_msg *, struct netlink_skb_parms *));
-  void cn_netlink_send_multi(struct cn_msg *msg, u16 len, u32 portid, u32 __group, int gfp_mask);
+  void cn_netlink_send_mult(struct cn_msg *msg, u16 len, u32 portid, u32 __group, int gfp_mask);
   void cn_netlink_send(struct cn_msg *msg, u32 portid, u32 __group, int gfp_mask);
 
   struct cb_id
@@ -48,7 +48,8 @@ be dereferenced to `struct cn_msg *`::
 	__u32			seq;
 	__u32			ack;
 
-	__u32			len;	/* Length of the following data */
+	__u16			len;	/* Length of the following data */
+	__u16			flags;
 	__u8			data[0];
   };
 
-- 
1.8.3.1





^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] Documentation: driver-api: update kernel connector
  2020-07-20  7:24 [PATCH] Documentation: driver-api: update kernel connector Wang Long
@ 2020-07-23 20:06 ` Jonathan Corbet
  0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Corbet @ 2020-07-23 20:06 UTC (permalink / raw)
  To: Wang Long; +Cc: linux-doc, linux-kernel

On Mon, 20 Jul 2020 15:24:12 +0800
Wang Long <w@laoqinren.net> wrote:

> This patch changes:
> 1) Fix typo in kernel connector documentation.
> 	s/cn_netlink_send_multi/cn_netlink_send_mult/
> 2) update definition of struct cn_msg
> 
> Signed-off-by: Wang Long <w@laoqinren.net>
> ---
>  Documentation/driver-api/connector.rst | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)

Applied, thanks.

This sort of documentation would be better handled with kerneldoc
comments, though...

jon

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-07-23 20:06 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-20  7:24 [PATCH] Documentation: driver-api: update kernel connector Wang Long
2020-07-23 20:06 ` Jonathan Corbet

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).