* [PATCH net-next] brcm80211: fix possible memleak in brcmf_proto_msgbuf_attach
@ 2020-07-20 9:36 Wang Yufen
2020-08-02 15:29 ` Kalle Valo
2020-08-18 12:47 ` Kalle Valo
0 siblings, 2 replies; 4+ messages in thread
From: Wang Yufen @ 2020-07-20 9:36 UTC (permalink / raw)
To: netdev, linux-kernel, brcm80211-dev-list, linux-wireless, davem,
kvalo, kuba, franky.lin, wright.feng
Cc: Wang Yufen
When brcmf_proto_msgbuf_attach fail and msgbuf->txflow_wq != NULL,
we should destroy the workqueue.
Fixes: 05491d2ccf20 ("brcm80211: move under broadcom vendor directory")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wang Yufen <wangyufen@huawei.com>
---
drivers/net/wireless/broadcom/brcm80211/brcmfmac/msgbuf.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/msgbuf.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/msgbuf.c
index 8bb4f1f..1bb270e 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/msgbuf.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/msgbuf.c
@@ -1619,6 +1619,8 @@ int brcmf_proto_msgbuf_attach(struct brcmf_pub *drvr)
BRCMF_TX_IOCTL_MAX_MSG_SIZE,
msgbuf->ioctbuf,
msgbuf->ioctbuf_handle);
+ if (msgbuf->txflow_wq)
+ destroy_workqueue(msgbuf->txflow_wq);
kfree(msgbuf);
}
return -ENOMEM;
--
1.8.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH net-next] brcm80211: fix possible memleak in brcmf_proto_msgbuf_attach
2020-07-20 9:36 [PATCH net-next] brcm80211: fix possible memleak in brcmf_proto_msgbuf_attach Wang Yufen
@ 2020-08-02 15:29 ` Kalle Valo
2020-08-18 12:47 ` Kalle Valo
1 sibling, 0 replies; 4+ messages in thread
From: Kalle Valo @ 2020-08-02 15:29 UTC (permalink / raw)
To: Wang Yufen
Cc: netdev, linux-kernel, brcm80211-dev-list, linux-wireless, davem,
kuba, franky.lin, wright.feng, Wang Yufen
Wang Yufen <wangyufen@huawei.com> wrote:
> When brcmf_proto_msgbuf_attach fail and msgbuf->txflow_wq != NULL,
> we should destroy the workqueue.
>
> Fixes: 05491d2ccf20 ("brcm80211: move under broadcom vendor directory")
Moving the driver to another directory cannot have caused this bug, so I'm
removing the fixes tag. Please check your commit logs, don't just blindly copy
what git-blame says.
--
https://patchwork.kernel.org/patch/11673291/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net-next] brcm80211: fix possible memleak in brcmf_proto_msgbuf_attach
2020-07-20 9:36 [PATCH net-next] brcm80211: fix possible memleak in brcmf_proto_msgbuf_attach Wang Yufen
2020-08-02 15:29 ` Kalle Valo
@ 2020-08-18 12:47 ` Kalle Valo
1 sibling, 0 replies; 4+ messages in thread
From: Kalle Valo @ 2020-08-18 12:47 UTC (permalink / raw)
To: Wang Yufen
Cc: netdev, linux-kernel, brcm80211-dev-list, linux-wireless, davem,
kuba, franky.lin, wright.feng, Wang Yufen
Wang Yufen <wangyufen@huawei.com> wrote:
> When brcmf_proto_msgbuf_attach fail and msgbuf->txflow_wq != NULL,
> we should destroy the workqueue.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wang Yufen <wangyufen@huawei.com>
Patch applied to wireless-drivers-next.git, thanks.
6c151410d5b5 brcm80211: fix possible memleak in brcmf_proto_msgbuf_attach
--
https://patchwork.kernel.org/patch/11673291/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH net-next] brcm80211: fix possible memleak in brcmf_proto_msgbuf_attach
@ 2020-07-20 9:33 Wang Yufen
0 siblings, 0 replies; 4+ messages in thread
From: Wang Yufen @ 2020-07-20 9:33 UTC (permalink / raw)
To: netdev, linux-kernel, brcm80211-dev-list, linux-wireless, davem,
kvalo, kuba, franky.lin, wright.feng
Cc: Wang Yufen
When brcmf_proto_msgbuf_attach fail and msgbuf->txflow_wq != NULL,
we should destroy the workqueue.
Fixes: 05491d2ccf20 ("brcm80211: move under broadcom vendor directory")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wang Yufen <wangyufen@huawei.com>
---
drivers/net/wireless/broadcom/brcm80211/brcmfmac/msgbuf.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/msgbuf.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/msgbuf.c
index 8bb4f1f..1bb270e 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/msgbuf.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/msgbuf.c
@@ -1619,6 +1619,8 @@ int brcmf_proto_msgbuf_attach(struct brcmf_pub *drvr)
BRCMF_TX_IOCTL_MAX_MSG_SIZE,
msgbuf->ioctbuf,
msgbuf->ioctbuf_handle);
+ if (msgbuf->txflow_wq)
+ destroy_workqueue(msgbuf->txflow_wq);
kfree(msgbuf);
}
return -ENOMEM;
--
1.8.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-08-18 12:47 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-20 9:36 [PATCH net-next] brcm80211: fix possible memleak in brcmf_proto_msgbuf_attach Wang Yufen
2020-08-02 15:29 ` Kalle Valo
2020-08-18 12:47 ` Kalle Valo
-- strict thread matches above, loose matches on Subject: below --
2020-07-20 9:33 Wang Yufen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).