From: Qii Wang <qii.wang@mediatek.com>
To: Matthias Brugger <mbrugger@suse.com>
Cc: Matthias Brugger <matthias.bgg@gmail.com>, <wsa@the-dreams.de>,
<yingjoe.chen@mediatek.com>, <linux-i2c@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-mediatek@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] i2c: mediatek: Fix i2c_spec_values description
Date: Fri, 7 Aug 2020 09:05:13 +0800 [thread overview]
Message-ID: <1596762313.8263.9.camel@mhfsdcap03> (raw)
In-Reply-To: <6e029d96-6171-0006-a5bb-01d0d5a7391b@suse.com>
On Thu, 2020-08-06 at 15:35 +0200, Matthias Brugger wrote:
>
> On 06/08/2020 13:06, Qii Wang wrote:
> > On Thu, 2020-08-06 at 11:48 +0200, Matthias Brugger wrote:
> >> The struct i2c_spec_values have it's members documented but is missing the
> >> starting '@', which leads to warings like:
> >>
> >> drivers/i2c/busses/i2c-mt65xx.c:267: warning: Function parameter or member
> >> 'min_low_ns' not described in 'i2c_spec_values'
> >>
> >> Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com>
> >> ---
> >> drivers/i2c/busses/i2c-mt65xx.c | 8 ++++----
> >> 1 file changed, 4 insertions(+), 4 deletions(-)
> >>
> >> diff --git a/drivers/i2c/busses/i2c-mt65xx.c b/drivers/i2c/busses/i2c-mt65xx.c
> >> index e889f74703e4..f51b35fc400f 100644
> >> --- a/drivers/i2c/busses/i2c-mt65xx.c
> >> +++ b/drivers/i2c/busses/i2c-mt65xx.c
> >> @@ -253,10 +253,10 @@ struct mtk_i2c {
> >>
> >> /**
> >> * struct i2c_spec_values:
> >> - * min_low_ns: min LOW period of the SCL clock
> >
> > Can you help me add a description of min_high_ns. As
> > @min_high_ns: min HIGH period of the SCL clock
>
> Right, I forgot about this one.
>
> Actually I don't see any code which uses the value, so I think it should be
> deleted from the struct.
>
> Do you have any thoughts on this.
>
That is right, it is used for internal test before. You can deleted it.
next prev parent reply other threads:[~2020-08-07 1:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-06 9:48 [PATCH] i2c: mediatek: Fix i2c_spec_values description Matthias Brugger
2020-08-06 11:06 ` Qii Wang
2020-08-06 13:35 ` Matthias Brugger
2020-08-07 1:05 ` Qii Wang [this message]
2020-08-10 9:40 ` wsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1596762313.8263.9.camel@mhfsdcap03 \
--to=qii.wang@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=mbrugger@suse.com \
--cc=wsa@the-dreams.de \
--cc=yingjoe.chen@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).