From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B769C433DF for ; Fri, 7 Aug 2020 21:44:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4612E2086A for ; Fri, 7 Aug 2020 21:44:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596836667; bh=RvRidD0gBRnyhL+PINbEd1JlEJ7BuJCSlC1D0xNCzUQ=; h=In-Reply-To:References:Subject:From:Cc:To:Date:List-ID:From; b=aNwVSM/fNlYL+RZUW70c6DYiPmhaO0sH4q3YEOsqx8Sk7YODFPohKxSsh8ML+ePD/ AVPT4p+5FsgEYo+lasBfQz9LpzWanMBf6mjeTK4VgNcywXC9o3j0mtFLDcI72dbvTB GOilNvWHvDOZ2cdQiERj1W7BpR9N7OB3dXh0H0ic= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726804AbgHGVoY (ORCPT ); Fri, 7 Aug 2020 17:44:24 -0400 Received: from mail.kernel.org ([198.145.29.99]:44000 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725970AbgHGVoX (ORCPT ); Fri, 7 Aug 2020 17:44:23 -0400 Received: from kernel.org (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id EA76D2086A; Fri, 7 Aug 2020 21:44:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596836663; bh=RvRidD0gBRnyhL+PINbEd1JlEJ7BuJCSlC1D0xNCzUQ=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=UaJb2DmSREBOT9PFmRI69xnpXJbZI83YIit1bT1pKZllKG7QVow6OkuWPDpJ7BDd+ 8S6wsRnda2be7ZKVN1L/9SFHalpsqf6JmbQkin0OUpyBeI3sfoDxMRs7axfq5ckrIp w0jS+qWJfWPLWN2jt/z20H+FTcr+8DLyuhBAqDkY= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <159191561875.242598.18326727418245335996@swboyd.mtv.corp.google.com> References: <1591885683-29514-1-git-send-email-sanm@codeaurora.org> <1591885683-29514-2-git-send-email-sanm@codeaurora.org> <159191561875.242598.18326727418245335996@swboyd.mtv.corp.google.com> Subject: Re: [PATCH 1/2] clk: qcom: gcc: Add genpd active wakeup flag for sc7180 From: Stephen Boyd Cc: linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Manu Gautam , linux-clk@vger.kernel.org, Taniya Das To: Andy Gross , Bjorn Andersson , Doug Anderson , Felipe Balbi , Greg Kroah-Hartman , Mark Rutland , Matthias Kaehlcke , Michael Turquette , Rob Herring , Sandeep Maheswaram Date: Fri, 07 Aug 2020 14:44:21 -0700 Message-ID: <159683666176.1360974.5500366475077976771@swboyd.mtv.corp.google.com> User-Agent: alot/0.9.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Stephen Boyd (2020-06-11 15:46:58) > Quoting Sandeep Maheswaram (2020-06-11 07:28:02) > > From: Taniya Das > >=20 > > The USB client requires the usb30_prim gdsc to be kept active for > > certain use cases, thus add the GENPD_FLAG_ACTIVE_WAKEUP flag. >=20 > Can you please describe more of what this is for? Once sentence doesn't > tell me much at all. I guess that sometimes we want to wakeup from USB > and so the usb gdsc should be marked as "maybe keep on for wakeups" with > the GENPD_FLAG_ACTIVE_WAKEUP flag if the USB controller is wakeup > enabled? >=20 > >=20 > > Signed-off-by: Taniya Das > > --- >=20 > Add a Fixes: tag too? And I assume we need to do this for all USB gdscs > on various SoCs and maybe other GDSCs like PCIe. Any plans to fix those > GDSCs? >=20 Any update here?