Re: [PATCH v2] drm/mediatek: dsi: fix scrolling of panel with small hfp or hbp

From: Jitao Shi <jitao.shi@mediatek.com>
To: Chun-Kuang Hu <chunkuang.hu@kernel.org>
Cc: Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Daniel Vetter <daniel@ffwll.ch>, David Airlie <airlied@linux.ie>,
	DRI Development <dri-devel@lists.freedesktop.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	<devicetree@vger.kernel.org>,
	srv_heupstream <srv_heupstream@mediatek.com>,
	<huijuan.xie@mediatek.com>, <stonea168@163.com>,
	<cawa.cheng@mediatek.com>,
	"moderated list:ARM/Mediatek SoC support" 
	<linux-mediatek@lists.infradead.org>,
	Bibby Hsieh <bibby.hsieh@mediatek.com>,
	CK Hu <ck.hu@mediatek.com>, <yingjoe.chen@mediatek.com>,
	<eddie.huang@mediatek.com>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2] drm/mediatek: dsi: fix scrolling of panel with small hfp or hbp
Date: Tue, 18 Aug 2020 10:41:32 +0800	[thread overview]
Message-ID: <1597718492.6381.6.camel@mszsdaap41> (raw)
In-Reply-To: <CAAOTY_9ggDUdDD9KoOaWBx3XaK+=Q=5qxahG7SJ5uYBQZ4aadw@mail.gmail.com>

On Tue, 2020-08-18 at 07:42 +0800, Chun-Kuang Hu wrote:
> Hi, Jitao:
> 
> Jitao Shi <jitao.shi@mediatek.com> 於 2020年8月17日 週一 下午9:07寫道：
> >
> > horizontal_backporch_byte should be hbp * bpp - hbp extra bytes.
> > So remove the wrong subtraction 10.
> >
> > Signed-off-by: Jitao Shi <jitao.shi@mediatek.com>
> > ---
> >  drivers/gpu/drm/mediatek/mtk_dsi.c | 9 ++++-----
> >  1 file changed, 4 insertions(+), 5 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c
> > index 270bf22c98fe..5d031e634571 100644
> > --- a/drivers/gpu/drm/mediatek/mtk_dsi.c
> > +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c
> > @@ -473,14 +473,13 @@ static void mtk_dsi_config_vdo_timing(struct mtk_dsi *dsi)
> >         horizontal_sync_active_byte = (vm->hsync_len * dsi_tmp_buf_bpp - 10);
> 
> So this subtraction 10 is correct?
> 
> Regards,
> Chun-Kuang.
> 

Yes, It is right.

In the cea861 and dmt spec the mini hsync is 40 pixels.
So the vm->hsync_len * dsi_tmp_buf_bpp >= 120 > 10

Best Regards
jitao
> >
> >         if (dsi->mode_flags & MIPI_DSI_MODE_VIDEO_SYNC_PULSE)
> > -               horizontal_backporch_byte =
> > -                       (vm->hback_porch * dsi_tmp_buf_bpp - 10);
> > +               horizontal_backporch_byte = vm->hback_porch * dsi_tmp_buf_bpp;
> >         else
> > -               horizontal_backporch_byte = ((vm->hback_porch + vm->hsync_len) *
> > -                       dsi_tmp_buf_bpp - 10);
> > +               horizontal_backporch_byte = (vm->hback_porch + vm->hsync_len) *
> > +                                           dsi_tmp_buf_bpp;
> >
> >         data_phy_cycles = timing->lpx + timing->da_hs_prepare +
> > -                         timing->da_hs_zero + timing->da_hs_exit + 3;
> > +                         timing->da_hs_zero + timing->da_hs_exit;
> >
> >         if (dsi->mode_flags & MIPI_DSI_MODE_VIDEO_BURST) {
> >                 if ((vm->hfront_porch + vm->hback_porch) * dsi_tmp_buf_bpp >
> > --
> > 2.12.5
> > _______________________________________________
> > Linux-mediatek mailing list
> > Linux-mediatek@lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/linux-mediatek