From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: linux-scsi@vger.kernel.org, bvanassche@acm.org,
avri.altman@wdc.com, jejb@linux.ibm.com, alim.akhtar@samsung.com,
Stanley Chu <stanley.chu@mediatek.com>
Cc: "Martin K . Petersen" <martin.petersen@oracle.com>,
linux-mediatek@lists.infradead.org, matthias.bgg@gmail.com,
chaotian.jing@mediatek.com, peter.wang@mediatek.com,
linux-arm-kernel@lists.infradead.org, cc.chou@mediatek.com,
kuohong.wang@mediatek.com, andy.teng@mediatek.com,
asutoshd@codeaurora.org, cang@codeaurora.org, beanhuo@micron.com,
linux-kernel@vger.kernel.org, chun-hung.wu@mediatek.com
Subject: Re: [PATCH v3] scsi: ufs: Fix possible infinite loop in ufshcd_hold
Date: Mon, 17 Aug 2020 23:12:32 -0400 [thread overview]
Message-ID: <159772029325.19587.9193434104087348194.b4-ty@oracle.com> (raw)
In-Reply-To: <20200809050734.18740-1-stanley.chu@mediatek.com>
On Sun, 9 Aug 2020 13:07:34 +0800, Stanley Chu wrote:
> In ufshcd_suspend(), after clk-gating is suspended and link is set
> as Hibern8 state, ufshcd_hold() is still possibly invoked before
> ufshcd_suspend() returns. For example, MediaTek's suspend vops may
> issue UIC commands which would call ufshcd_hold() during the command
> issuing flow.
>
> Now if UFSHCD_CAP_HIBERN8_WITH_CLK_GATING capability is enabled,
> then ufshcd_hold() may enter infinite loops because there is no
> clk-ungating work scheduled or pending. In this case, ufshcd_hold()
> shall just bypass, and keep the link as Hibern8 state.
Applied to 5.9/scsi-fixes, thanks!
[1/1] scsi: ufs: Fix possible infinite loop in ufshcd_hold
https://git.kernel.org/mkp/scsi/c/93b6c5db0602
--
Martin K. Petersen Oracle Linux Engineering
prev parent reply other threads:[~2020-08-18 3:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-09 5:07 [PATCH v3] scsi: ufs: Fix possible infinite loop in ufshcd_hold Stanley Chu
2020-08-18 3:12 ` Martin K. Petersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=159772029325.19587.9193434104087348194.b4-ty@oracle.com \
--to=martin.petersen@oracle.com \
--cc=alim.akhtar@samsung.com \
--cc=andy.teng@mediatek.com \
--cc=asutoshd@codeaurora.org \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=bvanassche@acm.org \
--cc=cang@codeaurora.org \
--cc=cc.chou@mediatek.com \
--cc=chaotian.jing@mediatek.com \
--cc=chun-hung.wu@mediatek.com \
--cc=jejb@linux.ibm.com \
--cc=kuohong.wang@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=peter.wang@mediatek.com \
--cc=stanley.chu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).