From: "tip-bot2 for James Morse" <tip-bot2@linutronix.de>
To: linux-tip-commits@vger.kernel.org
Cc: James Morse <james.morse@arm.com>, Borislav Petkov <bp@suse.de>,
Reinette Chatre <reinette.chatre@intel.com>, x86 <x86@kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: [tip: x86/cache] x86/resctrl: Remove struct rdt_membw::max_delay
Date: Wed, 19 Aug 2020 12:33:13 -0000 [thread overview]
Message-ID: <159784039302.3192.3471663986483240927.tip-bot2@tip-bot2> (raw)
In-Reply-To: <20200708163929.2783-3-james.morse@arm.com>
The following commit has been merged into the x86/cache branch of tip:
Commit-ID: e89f85b9171665c917dca59920884f3d4fe0b1ef
Gitweb: https://git.kernel.org/tip/e89f85b9171665c917dca59920884f3d4fe0b1ef
Author: James Morse <james.morse@arm.com>
AuthorDate: Wed, 08 Jul 2020 16:39:21
Committer: Borislav Petkov <bp@suse.de>
CommitterDate: Tue, 18 Aug 2020 17:01:23 +02:00
x86/resctrl: Remove struct rdt_membw::max_delay
max_delay is used by x86's __get_mem_config_intel() as a local variable.
Remove it, replacing it with a local variable.
Signed-off-by: James Morse <james.morse@arm.com>
Signed-off-by: Borislav Petkov <bp@suse.de>
Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>
Link: https://lkml.kernel.org/r/20200708163929.2783-3-james.morse@arm.com
---
arch/x86/kernel/cpu/resctrl/core.c | 8 ++++----
arch/x86/kernel/cpu/resctrl/internal.h | 3 ---
2 files changed, 4 insertions(+), 7 deletions(-)
diff --git a/arch/x86/kernel/cpu/resctrl/core.c b/arch/x86/kernel/cpu/resctrl/core.c
index 6a9df71..9225ee5 100644
--- a/arch/x86/kernel/cpu/resctrl/core.c
+++ b/arch/x86/kernel/cpu/resctrl/core.c
@@ -254,16 +254,16 @@ static bool __get_mem_config_intel(struct rdt_resource *r)
{
union cpuid_0x10_3_eax eax;
union cpuid_0x10_x_edx edx;
- u32 ebx, ecx;
+ u32 ebx, ecx, max_delay;
cpuid_count(0x00000010, 3, &eax.full, &ebx, &ecx, &edx.full);
r->num_closid = edx.split.cos_max + 1;
- r->membw.max_delay = eax.split.max_delay + 1;
+ max_delay = eax.split.max_delay + 1;
r->default_ctrl = MAX_MBA_BW;
if (ecx & MBA_IS_LINEAR) {
r->membw.delay_linear = true;
- r->membw.min_bw = MAX_MBA_BW - r->membw.max_delay;
- r->membw.bw_gran = MAX_MBA_BW - r->membw.max_delay;
+ r->membw.min_bw = MAX_MBA_BW - max_delay;
+ r->membw.bw_gran = MAX_MBA_BW - max_delay;
} else {
if (!rdt_get_mb_table(r))
return false;
diff --git a/arch/x86/kernel/cpu/resctrl/internal.h b/arch/x86/kernel/cpu/resctrl/internal.h
index 72bb210..1eb39bd 100644
--- a/arch/x86/kernel/cpu/resctrl/internal.h
+++ b/arch/x86/kernel/cpu/resctrl/internal.h
@@ -369,8 +369,6 @@ struct rdt_cache {
/**
* struct rdt_membw - Memory bandwidth allocation related data
- * @max_delay: Max throttle delay. Delay is the hardware
- * representation for memory bandwidth.
* @min_bw: Minimum memory bandwidth percentage user can request
* @bw_gran: Granularity at which the memory bandwidth is allocated
* @delay_linear: True if memory B/W delay is in linear scale
@@ -378,7 +376,6 @@ struct rdt_cache {
* @mb_map: Mapping of memory B/W percentage to memory B/W delay
*/
struct rdt_membw {
- u32 max_delay;
u32 min_bw;
u32 bw_gran;
u32 delay_linear;
next prev parent reply other threads:[~2020-08-19 12:34 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-08 16:39 [PATCH v5 00/10] x86/resctrl: Misc cleanup James Morse
2020-07-08 16:39 ` [PATCH v5 01/10] x86/resctrl: Nothing uses struct mbm_state chunks_bw James Morse
2020-08-19 12:33 ` [tip: x86/cache] x86/resctrl: Remove unused struct mbm_state::chunks_bw tip-bot2 for James Morse
2020-07-08 16:39 ` [PATCH v5 02/10] x86/resctrl: Remove max_delay James Morse
2020-08-19 12:33 ` tip-bot2 for James Morse [this message]
2020-07-08 16:39 ` [PATCH v5 03/10] x86/resctrl: Fix stale comment James Morse
2020-08-19 12:33 ` [tip: x86/cache] " tip-bot2 for James Morse
2020-07-08 16:39 ` [PATCH v5 04/10] x86/resctrl: use container_of() in delayed_work handlers James Morse
2020-08-19 12:33 ` [tip: x86/cache] x86/resctrl: Use " tip-bot2 for James Morse
2020-07-08 16:39 ` [PATCH v5 05/10] x86/resctrl: Include pid.h James Morse
2020-08-19 12:33 ` [tip: x86/cache] " tip-bot2 for James Morse
2020-07-08 16:39 ` [PATCH v5 06/10] x86/resctrl: Use is_closid_match() in more places James Morse
2020-08-19 12:33 ` [tip: x86/cache] " tip-bot2 for James Morse
2020-07-08 16:39 ` [PATCH v5 07/10] x86/resctrl: Add arch_needs_linear to explain AMD/Intel MBA difference James Morse
2020-08-19 12:33 ` [tip: x86/cache] x86/resctrl: Add struct rdt_membw::arch_needs_linear " tip-bot2 for James Morse
2020-07-08 16:39 ` [PATCH v5 08/10] x86/resctrl: Merge AMD/Intel parse_bw() calls James Morse
2020-08-19 12:33 ` [tip: x86/cache] " tip-bot2 for James Morse
2020-07-08 16:39 ` [PATCH v5 09/10] x86/resctrl: Add arch_has_{sparse,empty}_bitmaps to explain CAT differences James Morse
2020-08-19 12:33 ` [tip: x86/cache] x86/resctrl: Add struct rdt_cache::arch_has_{sparse, empty}_bitmaps tip-bot2 for James Morse
2020-07-08 16:39 ` [PATCH v5 10/10] cacheinfo: Move resctrl's get_cache_id() to the cacheinfo header file James Morse
2020-08-19 12:33 ` [tip: x86/cache] " tip-bot2 for James Morse
2020-07-23 18:31 ` [PATCH v5 00/10] x86/resctrl: Misc cleanup James Morse
2020-07-23 20:31 ` Reinette Chatre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=159784039302.3192.3471663986483240927.tip-bot2@tip-bot2 \
--to=tip-bot2@linutronix.de \
--cc=bp@suse.de \
--cc=james.morse@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=reinette.chatre@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).