From: David Howells <dhowells@redhat.com>
To: netdev@vger.kernel.org
Cc: dhowells@redhat.com, linux-afs@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: [PATCH net 4/7] afs: Remove afs_vlserver->probe.have_result
Date: Thu, 27 Aug 2020 16:04:01 +0100 [thread overview]
Message-ID: <159854064142.1382667.3537073236297188885.stgit@warthog.procyon.org.uk> (raw)
In-Reply-To: <159854061331.1382667.9693163318506702951.stgit@warthog.procyon.org.uk>
Remove afs_vlserver->probe.have_result as it's neither read nor waited
upon.
Fixes: 3bf0fb6f33dd ("afs: Probe multiple fileservers simultaneously")
Signed-off-by: David Howells <dhowells@redhat.com>
---
fs/afs/internal.h | 1 -
fs/afs/vl_probe.c | 5 +----
2 files changed, 1 insertion(+), 5 deletions(-)
diff --git a/fs/afs/internal.h b/fs/afs/internal.h
index 792ac711985e..2e6ae6388c72 100644
--- a/fs/afs/internal.h
+++ b/fs/afs/internal.h
@@ -412,7 +412,6 @@ struct afs_vlserver {
unsigned int rtt; /* RTT as ktime/64 */
u32 abort_code;
short error;
- bool have_result;
bool responded:1;
bool is_yfs:1;
bool not_yfs:1;
diff --git a/fs/afs/vl_probe.c b/fs/afs/vl_probe.c
index 081b7e5b13f5..ee59188433b9 100644
--- a/fs/afs/vl_probe.c
+++ b/fs/afs/vl_probe.c
@@ -109,11 +109,8 @@ void afs_vlserver_probe_result(struct afs_call *call)
server_index, index, &alist->addrs[index].transport, rtt_us, ret);
have_result |= afs_vl_probe_done(server);
- if (have_result) {
- server->probe.have_result = true;
- wake_up_var(&server->probe.have_result);
+ if (have_result)
wake_up_all(&server->probe_wq);
- }
}
/*
next prev parent reply other threads:[~2020-08-27 15:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-27 15:03 [PATCH net 0/7] rxrpc, afs: Fix probing issues David Howells
2020-08-27 15:03 ` [PATCH net 1/7] rxrpc: Keep the ACK serial in a var in rxrpc_input_ack() David Howells
2020-08-27 15:03 ` [PATCH net 2/7] rxrpc: Fix loss of RTT samples due to interposed ACK David Howells
2020-08-27 15:03 ` [PATCH net 3/7] rxrpc: Make rxrpc_kernel_get_srtt() indicate validity David Howells
2020-08-27 15:04 ` David Howells [this message]
2020-08-27 15:04 ` [PATCH net 5/7] afs: Expose information from afs_vlserver through /proc for debugging David Howells
2020-08-27 15:04 ` [PATCH net 6/7] afs: Don't use VL probe running state to make decisions outside probe code David Howells
2020-08-27 15:04 ` [PATCH net 7/7] afs: Fix error handling in VL server rotation David Howells
2020-08-27 19:56 ` [PATCH net 0/7] rxrpc, afs: Fix probing issues David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=159854064142.1382667.3537073236297188885.stgit@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=linux-afs@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).