linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] drm/panel: rm67191: Remove CLOCK_NON_CONTINUOUS flag
@ 2020-08-28 14:58 Robert Chiras (OSS)
  2020-08-29 21:05 ` Sam Ravnborg
  0 siblings, 1 reply; 2+ messages in thread
From: Robert Chiras (OSS) @ 2020-08-28 14:58 UTC (permalink / raw)
  To: Thierry Reding, Sam Ravnborg
  Cc: David Airlie, Daniel Vetter, dri-devel, linux-kernel, linux-imx

From: Robert Chiras <robert.chiras@nxp.com>

The flag MIPI_DSI_CLOCK_NON_CONTINUOUS was wrong used in the DSI driver,
so it was added to this panel, but not necessary.
So, remove this flag since it is not needed.

Signed-off-by: Robert Chiras <robert.chiras@nxp.com>
---
 drivers/gpu/drm/panel/panel-raydium-rm67191.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/panel/panel-raydium-rm67191.c b/drivers/gpu/drm/panel/panel-raydium-rm67191.c
index 23b6208..572547d 100644
--- a/drivers/gpu/drm/panel/panel-raydium-rm67191.c
+++ b/drivers/gpu/drm/panel/panel-raydium-rm67191.c
@@ -552,8 +552,7 @@ static int rad_panel_probe(struct mipi_dsi_device *dsi)
 	panel->dsi = dsi;
 
 	dsi->format = MIPI_DSI_FMT_RGB888;
-	dsi->mode_flags =  MIPI_DSI_MODE_VIDEO_HSE | MIPI_DSI_MODE_VIDEO |
-			   MIPI_DSI_CLOCK_NON_CONTINUOUS;
+	dsi->mode_flags =  MIPI_DSI_MODE_VIDEO_HSE | MIPI_DSI_MODE_VIDEO;
 
 	ret = of_property_read_u32(np, "video-mode", &video_mode);
 	if (!ret) {
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] drm/panel: rm67191: Remove CLOCK_NON_CONTINUOUS flag
  2020-08-28 14:58 [PATCH] drm/panel: rm67191: Remove CLOCK_NON_CONTINUOUS flag Robert Chiras (OSS)
@ 2020-08-29 21:05 ` Sam Ravnborg
  0 siblings, 0 replies; 2+ messages in thread
From: Sam Ravnborg @ 2020-08-29 21:05 UTC (permalink / raw)
  To: Robert Chiras (OSS)
  Cc: Thierry Reding, David Airlie, Daniel Vetter, dri-devel,
	linux-kernel, linux-imx

On Fri, Aug 28, 2020 at 05:58:33PM +0300, Robert Chiras (OSS) wrote:
> From: Robert Chiras <robert.chiras@nxp.com>
> 
> The flag MIPI_DSI_CLOCK_NON_CONTINUOUS was wrong used in the DSI driver,
> so it was added to this panel, but not necessary.
> So, remove this flag since it is not needed.
> 
> Signed-off-by: Robert Chiras <robert.chiras@nxp.com>

Thanks, applied to drm-misc-next.

	Sam

> ---
>  drivers/gpu/drm/panel/panel-raydium-rm67191.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/panel/panel-raydium-rm67191.c b/drivers/gpu/drm/panel/panel-raydium-rm67191.c
> index 23b6208..572547d 100644
> --- a/drivers/gpu/drm/panel/panel-raydium-rm67191.c
> +++ b/drivers/gpu/drm/panel/panel-raydium-rm67191.c
> @@ -552,8 +552,7 @@ static int rad_panel_probe(struct mipi_dsi_device *dsi)
>  	panel->dsi = dsi;
>  
>  	dsi->format = MIPI_DSI_FMT_RGB888;
> -	dsi->mode_flags =  MIPI_DSI_MODE_VIDEO_HSE | MIPI_DSI_MODE_VIDEO |
> -			   MIPI_DSI_CLOCK_NON_CONTINUOUS;
> +	dsi->mode_flags =  MIPI_DSI_MODE_VIDEO_HSE | MIPI_DSI_MODE_VIDEO;
>  
>  	ret = of_property_read_u32(np, "video-mode", &video_mode);
>  	if (!ret) {
> -- 
> 2.7.4

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-08-29 21:05 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-28 14:58 [PATCH] drm/panel: rm67191: Remove CLOCK_NON_CONTINUOUS flag Robert Chiras (OSS)
2020-08-29 21:05 ` Sam Ravnborg

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).