From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 740AEC433E2 for ; Tue, 8 Sep 2020 18:45:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3E54920678 for ; Tue, 8 Sep 2020 18:45:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="f2fD5pVm" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731653AbgIHSne (ORCPT ); Tue, 8 Sep 2020 14:43:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51840 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731344AbgIHSmQ (ORCPT ); Tue, 8 Sep 2020 14:42:16 -0400 Received: from mail-pf1-x430.google.com (mail-pf1-x430.google.com [IPv6:2607:f8b0:4864:20::430]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D87FFC061755 for ; Tue, 8 Sep 2020 11:42:15 -0700 (PDT) Received: by mail-pf1-x430.google.com with SMTP id o20so11695195pfp.11 for ; Tue, 08 Sep 2020 11:42:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:content-transfer-encoding:in-reply-to:references :subject:from:cc:to:date:message-id:user-agent; bh=JKtiywr7+fjeVER30WU5i+E72d6lfY9W4GWcx21Jgb8=; b=f2fD5pVmpsnDpq+srq+r2lnCbNJJR80fVasFaY9lpjHHU0c58mCDL9B6ng3gzFBLYT eADBy99c9rrDaeJ3AcnnVAOSBLH1yZF28V4bKx3cCQdYjr5LLg7zlZmYubAFh73mq9H1 w4lmNNA/lMWopy8w4n2cGWwg/NeQYncP0hnsE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:content-transfer-encoding :in-reply-to:references:subject:from:cc:to:date:message-id :user-agent; bh=JKtiywr7+fjeVER30WU5i+E72d6lfY9W4GWcx21Jgb8=; b=oAFUhXCimMeJYc4iPuJk/LqcbIid68bdDGZMwivQY+4G+bTC+5dQR+PPXRrjCEHW+K vd3G2eDanQwwWJYEfJEDVaNKr2fy/q9kMJERq33U1Rs9L5CxemQr6ImYYZw4U+2y4U2r IRDPDFzoWEgFmt4RqF8GTgE4d86R2p55QY4f0rbYwPswGmQ9ipFYbtEy4IOChzzfSxVU Q99j2T0cyQXfvk02QmZ2uT94Bsu9lE59PN7xLI+T7ken62sl6aw17rsLxbkep7oMe2eU PEsGOFOatn6DhBPXhxGCv6URVOdM/+Wd2TMsMnTzDOnTzDoRZw1pfVGXpPRtg/C94Iuk BEjg== X-Gm-Message-State: AOAM530SrTCKFkh8O4IbBfAKQbYv3KoQ5es+EGuXUyn+L8CFNBsldr85 sjUYNzA+f88tAy3ubEG11o/j86WoaVORaQ== X-Google-Smtp-Source: ABdhPJyt1eVQnuCuk4L6IVMa/HQgw45+PS9gTYAZnn5KPjOouxmwZbRHZweN2ayo6qGEOQZeb5kTtA== X-Received: by 2002:a63:4810:: with SMTP id v16mr98444pga.374.1599590534338; Tue, 08 Sep 2020 11:42:14 -0700 (PDT) Received: from chromium.org ([2620:15c:202:1:3e52:82ff:fe6c:83ab]) by smtp.gmail.com with ESMTPSA id y4sm127196pfq.215.2020.09.08.11.42.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Sep 2020 11:42:11 -0700 (PDT) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <990b9edf-055d-6ecf-ee39-5a252b4c8859@marek.ca> References: <20200902230215.3452712-1-swboyd@chromium.org> <20200902230215.3452712-8-swboyd@chromium.org> <990b9edf-055d-6ecf-ee39-5a252b4c8859@marek.ca> Subject: Re: [PATCH v2 07/10] phy: qcom-qmp: Add support for DP in USB3+DP combo phy From: Stephen Boyd Cc: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Jeykumar Sankaran , Chandan Uddaraju , Vara Reddy , Tanmay Shah , Bjorn Andersson , Manu Gautam , Sandeep Maheswaram , Douglas Anderson , Sean Paul , Stephen Boyd , Dmitry Baryshkov , Rob Clark To: Jonathan Marek , Kishon Vijay Abraham I , Vinod Koul Date: Tue, 08 Sep 2020 11:42:09 -0700 Message-ID: <159959052954.454335.18265741930513449396@swboyd.mtv.corp.google.com> User-Agent: alot/0.9.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Jonathan Marek (2020-09-03 16:26:39) > On 9/2/20 7:02 PM, Stephen Boyd wrote: >=20 > > +static int qcom_qmp_phy_configure_dp_phy(struct qmp_phy *qphy) > > +{ [...] > > + writel(0x05, qphy->pcs + QSERDES_V3_DP_PHY_CFG); > > + writel(0x01, qphy->pcs + QSERDES_V3_DP_PHY_CFG); > > + writel(0x09, qphy->pcs + QSERDES_V3_DP_PHY_CFG); > > + > > + writel(0x20, qphy->serdes + QSERDES_COM_RESETSM_CNTRL); >=20 > Should be QSERDES_V3_COM_RESETSM_CNTRL and not=20 > QSERDES_COM_RESETSM_CNTRL, which is for older PHY versions. >=20 Thanks! Fixed it.