From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753457AbcHWRP2 (ORCPT ); Tue, 23 Aug 2016 13:15:28 -0400 Received: from us01smtprelay-2.synopsys.com ([198.182.47.9]:33758 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752228AbcHWRPZ (ORCPT ); Tue, 23 Aug 2016 13:15:25 -0400 Subject: Re: [PATCH] DW: Read "is_memcpy" and "is_nollp" property from device tree. To: Andy Shevchenko , Eugeniy Paltsev References: <1471347080-1411-1-git-send-email-Eugeniy.Paltsev@synopsys.com> <1471617566.4887.184.camel@linux.intel.com> <1471965258.1562.15.camel@synopsys.com> <1471971704.4887.247.camel@linux.intel.com> CC: "robh@kernel.org" , "Nelson.Pereira@synopsys.com" , "vinod.koul@intel.com" , "viresh.kumar@linaro.org" , "linux-kernel@vger.kernel.org" , "dmaengine@vger.kernel.org" , "linux-snps-arc@lists.infradead.org" From: Vineet Gupta Message-ID: <15b77367-2f95-deb2-a4dc-c47730bdb939@synopsys.com> Date: Tue, 23 Aug 2016 10:14:52 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <1471971704.4887.247.camel@linux.intel.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.12.197.1] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/23/2016 10:02 AM, Andy Shevchenko wrote: > On Tue, 2016-08-23 at 15:14 +0000, Eugeniy Paltsev wrote: > >> DW DMAC on ARC SDP became broken after df5c7386 ("dmaengine: dw: >>>> some Intel devices has no memcpy support") and 30cb2639 >>>> ("dmaengine: dw: don't override platform data with autocfg") >>>> commits. >>> I'm not sure that word 'broken' is a correct one here. Is the >>> platform >>> code using this driver in the upstream already? If so, where is it >>> located? >>> >> I'm not sure is it, but, at least, it changed driver behavior for ARC >> SDP boards. > The rule of common sense here: if it was never upstreamed it has never > been broken. Right ! > I hardly remember any user of DW DMAC by ARC architecture in upstream. The ARC SDP platform is provided by arch/arc/plat-axs and arch/arc/boot/ax* The IP Proto-typing kit folks here would just add a DT binding in there and things would just work out of the box - and that stopped recently - hence the notion of broken. But I agree one can't fix what can't be seen as broken. I just intervened to make this comment - I'm sure you and Eugeniy can agree on a workable solution. Thx, -Vineet