From: "Linux regression tracking (Thorsten Leemhuis)" <regressions@leemhuis.info>
To: Jiri Kosina <jikos@kernel.org>, Bastien Nocera <hadess@hadess.net>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
"Benjamin Tissoires" <benjamin.tissoires@redhat.com>,
"Peter F . Patel-Schneider" <pfpschneider@gmail.com>,
"Filipe Laíns" <lains@riseup.net>,
"Nestor Lopez Casado" <nlopezcasad@logitech.com>,
"Mark Lord" <mlord@pobox.com>,
"Linux kernel regressions list" <regressions@lists.linux.dev>
Subject: Re: [PATCH] HID: logitech-hidpp: Handle timeout differently from busy
Date: Mon, 5 Jun 2023 10:44:09 +0200 [thread overview]
Message-ID: <15bb2507-a145-7f1b-8e84-58aeb02484b9@leemhuis.info> (raw)
In-Reply-To: <nycvar.YFH.7.76.2306031440380.29760@cbobk.fhfr.pm>
On 03.06.23 14:41, Jiri Kosina wrote:
> On Wed, 31 May 2023, Jiri Kosina wrote:
>
>>> If an attempt at contacting a receiver or a device fails because the
>>> receiver or device never responds, don't restart the communication, only
>>> restart it if the receiver or device answers that it's busy, as originally
>>> intended.
>>>
>>> This was the behaviour on communication timeout before commit 586e8fede795
>>> ("HID: logitech-hidpp: Retry commands when device is busy").
>>>
>>> This fixes some overly long waits in a critical path on boot, when
>>> checking whether the device is connected by getting its HID++ version.
>>>
>>> Signed-off-by: Bastien Nocera <hadess@hadess.net>
>>> Suggested-by: Mark Lord <mlord@pobox.com>
>>> Fixes: 586e8fede795 ("HID: logitech-hidpp: Retry commands when device is busy")
>>> Link: https://bugzilla.kernel.org/show_bug.cgi?id=217412
> [...]
>>
>> I have applied this even before getting confirmation from the reporters in
>> bugzilla, as it's the right thing to do anyway.
>
> Unfortunately it doesn't seem to cure the reported issue (while reverting
> 586e8fede79 does):
BTW, remind me again: was fixing this by reverting 586e8fede79 for now a
option? I guess it's not, but if I'm wrong I wonder if that might at
this point be the best way forward.
> https://bugzilla.kernel.org/show_bug.cgi?id=217523#c2
FWIW, another comment showed up there:
```
> --- Comment #6 from vova7890 ---
> Same problem. I researched this some time ago. I noticed that if I add a small
> delay between commands to the dongle - everything goes fine. Repeated
> request(586e8fede7953b1695b5ccc6112eff9b052e79ac) made the situation more
> visible
```
Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
--
Everything you wanna know about Linux kernel regression tracking:
https://linux-regtracking.leemhuis.info/about/#tldr
If I did something stupid, please tell me, as explained on that page.
#regzbot ^backmonitor:
https://lore.kernel.org/all/15e5d50f-95fc-c7c9-0918-015f24c6fc6d@leemhuis.info/
next prev parent reply other threads:[~2023-06-05 8:44 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-31 8:24 [PATCH] HID: logitech-hidpp: Handle timeout differently from busy Bastien Nocera
2023-05-31 14:07 ` Jiri Kosina
2023-06-03 12:41 ` Jiri Kosina
2023-06-03 13:17 ` Mark Lord
2023-06-05 14:20 ` Benjamin Tissoires
2023-06-05 14:31 ` Mark Lord
2023-06-05 8:44 ` Linux regression tracking (Thorsten Leemhuis) [this message]
2023-06-05 14:27 ` Benjamin Tissoires
2023-06-05 16:25 ` Mark Lord
2023-06-05 17:04 ` Benjamin Tissoires
2023-06-05 17:47 ` Mark Lord
2023-06-05 20:03 ` Jiri Kosina
2023-06-06 13:27 ` Jiri Kosina
2023-06-06 18:18 ` Linux regression tracking (Thorsten Leemhuis)
2023-06-06 18:37 ` Benjamin Tissoires
2023-06-07 9:46 ` Greg Kroah-Hartman
2023-06-07 10:07 ` Benjamin Tissoires
2023-06-15 7:24 ` Linux regression tracking (Thorsten Leemhuis)
2023-06-15 11:24 ` Mark Lord
2023-06-21 14:03 ` Linux regression tracking (Thorsten Leemhuis)
2023-06-21 15:10 ` Benjamin Tissoires
2023-06-21 17:19 ` Linux regression tracking (Thorsten Leemhuis)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15bb2507-a145-7f1b-8e84-58aeb02484b9@leemhuis.info \
--to=regressions@leemhuis.info \
--cc=benjamin.tissoires@redhat.com \
--cc=hadess@hadess.net \
--cc=jikos@kernel.org \
--cc=lains@riseup.net \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mlord@pobox.com \
--cc=nlopezcasad@logitech.com \
--cc=pfpschneider@gmail.com \
--cc=regressions@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).