linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Florian Fainelli <f.fainelli@gmail.com>
To: Oleksij Rempel <o.rempel@pengutronix.de>, Andrew Lunn <andrew@lunn.ch>
Cc: Heiner Kallweit <hkallweit1@gmail.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Rob Herring <robh+dt@kernel.org>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	linux-kernel@vger.kernel.org,
	"David S. Miller" <davem@davemloft.net>,
	netdev@vger.kernel.org, Marek Vasut <marex@denx.de>,
	David Jander <david@protonic.nl>,
	devicetree@vger.kernel.org
Subject: Re: [PATCH v4 1/4] dt-bindings: net: phy: Add support for NXP TJA11xx
Date: Fri, 13 Mar 2020 11:20:35 -0700	[thread overview]
Message-ID: <15dafdcd-1979-bf35-3968-c80ffc113001@gmail.com> (raw)
In-Reply-To: <20200313181601.sbxdrqdjqfj3xn3e@pengutronix.de>



On 3/13/2020 11:16 AM, Oleksij Rempel wrote:
> On Fri, Mar 13, 2020 at 07:10:56PM +0100, Andrew Lunn wrote:
>>>> diff --git a/Documentation/devicetree/bindings/net/nxp,tja11xx.yaml b/Documentation/devicetree/bindings/net/nxp,tja11xx.yaml
>>>> new file mode 100644
>>>> index 000000000000..42be0255512b
>>>> --- /dev/null
>>>> +++ b/Documentation/devicetree/bindings/net/nxp,tja11xx.yaml
>>>> @@ -0,0 +1,61 @@
>>>> +# SPDX-License-Identifier: GPL-2.0+
>>>> +%YAML 1.2
>>>> +---
>>>> +$id: http://devicetree.org/schemas/net/nxp,tja11xx.yaml#
>>>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>>>> +
>>>> +title: NXP TJA11xx PHY
>>>> +
>>>> +maintainers:
>>>> +  - Andrew Lunn <andrew@lunn.ch>
>>>> +  - Florian Fainelli <f.fainelli@gmail.com>
>>>> +  - Heiner Kallweit <hkallweit1@gmail.com>
>>>> +
>>>> +description:
>>>> +  Bindings for NXP TJA11xx automotive PHYs
>>>> +
>>>> +allOf:
>>>> +  - $ref: ethernet-phy.yaml#
>>>> +
>>>> +patternProperties:
>>>> +  "^ethernet-phy@[0-9a-f]+$":
>>>> +    type: object
>>>> +    description: |
>>>> +      Some packages have multiple PHYs. Secondary PHY should be defines as
>>>> +      subnode of the first (parent) PHY.
>>>
>>>
>>> There are QSGMII PHYs which have 4 PHYs embedded and AFAICT they are
>>> defined as 4 separate Ethernet PHY nodes and this would not be quite a
>>> big stretch to represent them that way compared to how they are.
>>>
>>> I would recommend doing the same thing and not bend the MDIO framework
>>> to support the registration of "nested" Ethernet PHY nodes.
>>
>> Hi Florian
>>
>> The issue here is the missing PHY ID in the secondary PHY. Because of
>> that, the secondary does not probe in the normal way. We need the
>> primary to be involved to some degree. It needs to register it. What
>> i'm not so clear on is if it just needs to register it, or if these
>> sub nodes are actually needed, given the current code.
> 
> There are a bit more dependencies:
> - PHY0 is responsible for health monitoring. If some thing wrong, it may
>   shut down complete chip.
> - We have shared reset. It make no sense to probe PHY1 before PHY0 with
>   more controlling options will be probed
> - It is possible bat dangerous to use PHY1 without PHY0.

probing is a software problem though. If we want to describe the PHY
package more correctly, we should be using a container node, something
like this maybe:

phy-package {
	compatible = "nxp,tja1102";

	ethernet-phy@4 {
		reg = <4>;
	};

	ethernet-phy@5 {
		reg = <5>;
	};
};
-- 
Florian

  reply	other threads:[~2020-03-13 18:20 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-13  5:22 [PATCH v4 0/4] add TJA1102 support Oleksij Rempel
2020-03-13  5:22 ` [PATCH v4 1/4] dt-bindings: net: phy: Add support for NXP TJA11xx Oleksij Rempel
2020-03-13 18:02   ` Florian Fainelli
2020-03-13 18:10     ` Andrew Lunn
2020-03-13 18:16       ` Oleksij Rempel
2020-03-13 18:20         ` Florian Fainelli [this message]
2020-03-13 18:53           ` Oleksij Rempel
2020-03-17 11:56             ` Oleksij Rempel
2020-03-17 19:48               ` Florian Fainelli
2020-03-20 23:05                 ` Rob Herring
2020-03-22 21:09                   ` Florian Fainelli
2020-03-23 14:20                     ` Rob Herring
2020-04-28 17:30   ` Rob Herring
2020-04-29  4:38     ` Oleksij Rempel
2020-04-29  4:45       ` Florian Fainelli
2020-03-13  5:22 ` [PATCH v4 2/4] net: phy: tja11xx: add initial TJA1102 support Oleksij Rempel
2020-03-13  5:22 ` [PATCH v4 3/4] net: mdio: of: export part of of_mdiobus_register_phy() Oleksij Rempel
2020-03-13  5:22 ` [PATCH v4 4/4] net: phy: tja11xx: add delayed registration of TJA1102 PHY1 Oleksij Rempel
2020-03-16  8:44 ` [PATCH v4 0/4] add TJA1102 support David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=15dafdcd-1979-bf35-3968-c80ffc113001@gmail.com \
    --to=f.fainelli@gmail.com \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=david@protonic.nl \
    --cc=devicetree@vger.kernel.org \
    --cc=hkallweit1@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marex@denx.de \
    --cc=mark.rutland@arm.com \
    --cc=netdev@vger.kernel.org \
    --cc=o.rempel@pengutronix.de \
    --cc=robh+dt@kernel.org \
    --subject='Re: [PATCH v4 1/4] dt-bindings: net: phy: Add support for NXP TJA11xx' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).