From: Lucas Stach <l.stach@pengutronix.de>
To: Christian Gmeiner <christian.gmeiner@gmail.com>,
linux-kernel@vger.kernel.org
Cc: Russell King <linux+etnaviv@armlinux.org.uk>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
etnaviv@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 3/6] drm/etnaviv: show identity information in debugfs
Date: Mon, 06 Jan 2020 11:08:42 +0100 [thread overview]
Message-ID: <15ed7b85a13e220a533a800b9c04f13b1c747c1c.camel@pengutronix.de> (raw)
In-Reply-To: <20200102100230.420009-4-christian.gmeiner@gmail.com>
On Do, 2020-01-02 at 11:02 +0100, Christian Gmeiner wrote:
> Signed-off-by: Christian Gmeiner <christian.gmeiner@gmail.com>
> ---
> drivers/gpu/drm/etnaviv/etnaviv_gpu.c | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gpu.c
> b/drivers/gpu/drm/etnaviv/etnaviv_gpu.c
> index 253301be9e95..cecef5034db1 100644
> --- a/drivers/gpu/drm/etnaviv/etnaviv_gpu.c
> +++ b/drivers/gpu/drm/etnaviv/etnaviv_gpu.c
> @@ -868,6 +868,18 @@ int etnaviv_gpu_debugfs(struct etnaviv_gpu *gpu,
> struct seq_file *m)
>
> verify_dma(gpu, &debug);
>
> + seq_puts(m, "\tidentity\n");
> + seq_printf(m, "\t model: 0x%x\n",
> + gpu->identity.model);
> + seq_printf(m, "\t revision: 0x%x\n",
> + gpu->identity.revision);
> + seq_printf(m, "\t product_id: 0x%x\n",
> + gpu->identity.product_id);
> + seq_printf(m, "\t customer_id: 0x%x\n",
> + gpu->identity.customer_id);
> + seq_printf(m, "\t eco_id: 0x%x\n",
> + gpu->identity.eco_id);
I like having this info in debugfs. Most of those seq_printf don't need
a line break though, as they fit well within the 80 char limit.
Regards,
Lucas
next prev parent reply other threads:[~2020-01-06 10:08 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-02 10:02 [PATCH 0/6] update hwdw for gc400 Christian Gmeiner
2020-01-02 10:02 ` [PATCH 1/6] drm/etnaviv: update hardware headers from rnndb Christian Gmeiner
2020-01-02 10:02 ` [PATCH 2/6] drm/etnaviv: determine product, customer and eco id Christian Gmeiner
2020-01-06 10:03 ` Lucas Stach
2020-01-06 10:57 ` Christian Gmeiner
2020-01-06 11:22 ` Lucas Stach
2020-01-06 11:40 ` Christian Gmeiner
2020-01-06 11:50 ` Lucas Stach
2020-01-02 10:02 ` [PATCH 3/6] drm/etnaviv: show identity information in debugfs Christian Gmeiner
2020-01-06 10:08 ` Lucas Stach [this message]
2020-01-06 11:08 ` Christian Gmeiner
2020-01-02 10:02 ` [PATCH 4/6] drm/etnaviv: update gc7000 chip identity entry Christian Gmeiner
2020-01-02 10:02 ` [PATCH 5/6] drm/etnaviv: update hwdb selection logic Christian Gmeiner
2020-01-06 10:15 ` Lucas Stach
2020-01-06 10:49 ` Christian Gmeiner
2020-01-02 10:02 ` [PATCH 6/6] drm/etnaviv: add hwdb entry for gc400 found in STM32 Christian Gmeiner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15ed7b85a13e220a533a800b9c04f13b1c747c1c.camel@pengutronix.de \
--to=l.stach@pengutronix.de \
--cc=airlied@linux.ie \
--cc=christian.gmeiner@gmail.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=etnaviv@lists.freedesktop.org \
--cc=linux+etnaviv@armlinux.org.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).