From: Kai Ye <yekai13@huawei.com>
To: <linux-accelerators@lists.ozlabs.org>,
<linux-kernel@vger.kernel.org>, <linuxarm@huawei.com>,
<zhangfei.gao@linaro.org>
Cc: Kai Ye <yekai13@huawei.com>
Subject: [PATCH] uacce: fix some coding styles
Date: Mon, 14 Sep 2020 10:29:07 +0800 [thread overview]
Message-ID: <1600050547-32577-1-git-send-email-yekai13@huawei.com> (raw)
1. delete some redundant code.
2. modify the module author information.
Signed-off-by: Kai Ye <yekai13@huawei.com>
Reviewed-by: Zhou Wang <wangzhou1@hisilicon.com>
Acked-by: Zhangfei Gao <zhangfei.gao@linaro.org>
---
Changes in V2:
deleted extra NULL pointer check in uacce_fops.
drivers/misc/uacce/uacce.c | 13 +------------
1 file changed, 1 insertion(+), 12 deletions(-)
diff --git a/drivers/misc/uacce/uacce.c b/drivers/misc/uacce/uacce.c
index 107028e..1d09707 100644
--- a/drivers/misc/uacce/uacce.c
+++ b/drivers/misc/uacce/uacce.c
@@ -239,17 +239,6 @@ static int uacce_fops_mmap(struct file *filep, struct vm_area_struct *vma)
switch (type) {
case UACCE_QFRT_MMIO:
- if (!uacce->ops->mmap) {
- ret = -EINVAL;
- goto out_with_lock;
- }
-
- ret = uacce->ops->mmap(q, vma, qfr);
- if (ret)
- goto out_with_lock;
-
- break;
-
case UACCE_QFRT_DUS:
if (!uacce->ops->mmap) {
ret = -EINVAL;
@@ -541,5 +530,5 @@ subsys_initcall(uacce_init);
module_exit(uacce_exit);
MODULE_LICENSE("GPL");
-MODULE_AUTHOR("Hisilicon Tech. Co., Ltd.");
+MODULE_AUTHOR("HiSilicon Tech. Co., Ltd.");
MODULE_DESCRIPTION("Accelerator interface for Userland applications");
--
2.8.1
next reply other threads:[~2020-09-14 2:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-14 2:29 Kai Ye [this message]
2020-09-14 7:59 ` [PATCH] uacce: fix some coding styles Jonathan Cameron
-- strict thread matches above, loose matches on Subject: below --
2020-07-30 6:13 Kai Ye
2020-07-31 2:40 ` Zhou Wang
2020-07-31 3:09 ` Zhangfei Gao
2020-09-11 7:37 ` yekai(A)
2020-09-11 7:41 ` Greg KH
2020-07-20 7:18 Kai Ye
2020-07-21 6:57 ` Zhangfei Gao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1600050547-32577-1-git-send-email-yekai13@huawei.com \
--to=yekai13@huawei.com \
--cc=linux-accelerators@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=zhangfei.gao@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).