From: Stephen Boyd <swboyd@chromium.org>
To: Sibi Sankar <sibis@codeaurora.org>, bjorn.andersson@linaro.org
Cc: agross@kernel.org, linux-arm-msm@vger.kernel.org,
linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org,
ohad@wizery.com, evgreen@chromium.org,
Sibi Sankar <sibis@codeaurora.org>
Subject: Re: [PATCH v2] remoteproc: qcom_q6v5: Assign mpss region to Q6 before MBA boot
Date: Wed, 16 Sep 2020 10:17:48 -0700 [thread overview]
Message-ID: <160027666863.4188128.6191735162530147774@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <20200916145252.16024-1-sibis@codeaurora.org>
Quoting Sibi Sankar (2020-09-16 07:52:52)
> On secure devices which support warm reset, the MBA firmware requires
> access to the modem region to clear them out. Hence provide Q6 access
> to this region before MBA boot. This will be a nop during a modem SSR.
>
Does it need a Fixes: tag? Probably.
> Signed-off-by: Sibi Sankar <sibis@codeaurora.org>
> ---
>
Trivia time!
>
> diff --git a/drivers/remoteproc/qcom_q6v5_mss.c b/drivers/remoteproc/qcom_q6v5_mss.c
> index c401bcc263fa..f989ca81d374 100644
> --- a/drivers/remoteproc/qcom_q6v5_mss.c
> +++ b/drivers/remoteproc/qcom_q6v5_mss.c
> @@ -931,6 +931,16 @@ static int q6v5_mba_load(struct q6v5 *qproc)
> goto assert_reset;
> }
>
> + /* Some versions of the MBA firmware will upon boot wipe the MPSS region as well, so provide
Should have /* on a line by itself.
> + * the Q6 access to this region.
> + */
> + ret = q6v5_xfer_mem_ownership(qproc, &qproc->mpss_perm, false, true,
> + qproc->mpss_phys, qproc->mpss_size);
> + if (ret) {
> + dev_err(qproc->dev, "assigning Q6 access to mpss memory failed: %d\n", ret);
> + goto disable_active_clks;
> + }
> +
> /* Assign MBA image access in DDR to q6 */
> ret = q6v5_xfer_mem_ownership(qproc, &qproc->mba_perm, false, true,
> qproc->mba_phys, qproc->mba_size);
> @@ -1137,8 +1147,7 @@ static int q6v5_mpss_load(struct q6v5 *qproc)
>
> /**
Should be /* instead of /**, the latter is for kernel-doc which this is
not.
> * In case of a modem subsystem restart on secure devices, the modem
> - * memory can be reclaimed only after MBA is loaded. For modem cold
> - * boot this will be a nop
> + * memory can be reclaimed only after MBA is loaded.
> */
> q6v5_xfer_mem_ownership(qproc, &qproc->mpss_perm, true, false,
> qproc->mpss_phys, qproc->mpss_size);
next prev parent reply other threads:[~2020-09-16 17:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-16 14:52 [PATCH v2] remoteproc: qcom_q6v5: Assign mpss region to Q6 before MBA boot Sibi Sankar
2020-09-16 17:17 ` Stephen Boyd [this message]
2020-09-17 15:59 ` Sibi Sankar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=160027666863.4188128.6191735162530147774@swboyd.mtv.corp.google.com \
--to=swboyd@chromium.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=evgreen@chromium.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=ohad@wizery.com \
--cc=sibis@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).