From: Mansur Alisha Shaik <mansur@codeaurora.org>
To: linux-media@vger.kernel.org, stanimir.varbanov@linaro.org
Cc: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
vgarodia@codeaurora.org,
Mansur Alisha Shaik <mansur@codeaurora.org>
Subject: [RESEND v2 2/4] venus: core: vote for video-mem path
Date: Thu, 17 Sep 2020 06:56:01 +0530 [thread overview]
Message-ID: <1600305963-7659-3-git-send-email-mansur@codeaurora.org> (raw)
In-Reply-To: <1600305963-7659-1-git-send-email-mansur@codeaurora.org>
Currently we are voting for venus0-ebi path during buffer processing
with an average bandwidth of all the instances and unvoting during
session release.
While video streaming when we try to do XO-SD using the command
"echo mem > /sys/power/state command" , device is not entering
to suspend state and from interconnect summary seeing votes for venus0-ebi
Corrected this by voting for venus0-ebi path in venus_runtime_resume()
and unvote during venus_runtime_suspend().
Fixes: 7482a983d ("media: venus: redesign clocks and pm domains control")
Signed-off-by: Mansur Alisha Shaik <mansur@codeaurora.org>
---
Resending by adding () for functions to know it as function.
drivers/media/platform/qcom/venus/core.c | 14 +++++++++++++-
1 file changed, 13 insertions(+), 1 deletion(-)
diff --git a/drivers/media/platform/qcom/venus/core.c b/drivers/media/platform/qcom/venus/core.c
index 52a3886..064b6c8 100644
--- a/drivers/media/platform/qcom/venus/core.c
+++ b/drivers/media/platform/qcom/venus/core.c
@@ -363,8 +363,16 @@ static __maybe_unused int venus_runtime_suspend(struct device *dev)
ret = icc_set_bw(core->cpucfg_path, 0, 0);
if (ret)
- return ret;
+ goto err_poweron_core;
+
+ ret = icc_set_bw(core->video_path, 0, 0);
+ if (ret)
+ goto err_poweron_core;
+
+ return ret;
+err_poweron_core:
+ pm_ops->core_power(dev, POWER_ON);
return ret;
}
@@ -374,6 +382,10 @@ static __maybe_unused int venus_runtime_resume(struct device *dev)
const struct venus_pm_ops *pm_ops = core->pm_ops;
int ret;
+ ret = icc_set_bw(core->video_path, 0, kbps_to_icc(1000));
+ if (ret)
+ return ret;
+
ret = icc_set_bw(core->cpucfg_path, 0, kbps_to_icc(1000));
if (ret)
return ret;
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
next prev parent reply other threads:[~2020-09-17 1:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-17 1:25 [RESEND v2 0/4] Venus - change clk enable, disable order and change bw values Mansur Alisha Shaik
2020-09-17 1:26 ` [RESEND v2 1/4] venus: core: change clk enable and disable order in resume and suspend Mansur Alisha Shaik
2020-09-17 7:20 ` Stephen Boyd
2020-09-17 1:26 ` Mansur Alisha Shaik [this message]
2020-09-17 7:20 ` [RESEND v2 2/4] venus: core: vote for video-mem path Stephen Boyd
2020-09-17 1:26 ` [RESEND v2 3/4] venus: core: vote with average bandwidth and peak bandwidth as zero Mansur Alisha Shaik
2020-09-17 7:21 ` Stephen Boyd
2020-09-17 1:26 ` [RESEND v2 4/4] venus: put dummy vote on video-mem path after last session release Mansur Alisha Shaik
2020-09-17 7:26 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1600305963-7659-3-git-send-email-mansur@codeaurora.org \
--to=mansur@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=stanimir.varbanov@linaro.org \
--cc=vgarodia@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).