From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C12C1C43461 for ; Thu, 17 Sep 2020 07:20:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 824212072E for ; Thu, 17 Sep 2020 07:20:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="emqitvXa" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726279AbgIQHUi (ORCPT ); Thu, 17 Sep 2020 03:20:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48614 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726247AbgIQHUY (ORCPT ); Thu, 17 Sep 2020 03:20:24 -0400 Received: from mail-pf1-x441.google.com (mail-pf1-x441.google.com [IPv6:2607:f8b0:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CAB64C061788 for ; Thu, 17 Sep 2020 00:20:22 -0700 (PDT) Received: by mail-pf1-x441.google.com with SMTP id k8so659574pfk.2 for ; Thu, 17 Sep 2020 00:20:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:content-transfer-encoding:in-reply-to:references :subject:from:cc:to:date:message-id:user-agent; bh=8mZBJ8cLMtckf5ie94vJM9dG4dXSSI5Lejo+Q/gBHh4=; b=emqitvXamm1Zt4kpxTich+8DdlEB5lfs6ctgPWa0EPCVR9Iyj+wLVcTCZ44Z74IjUY 94Mj+hbZqt2kyeIzD3SJ1u5sB1MIHi4psCJJgsF8tfoS7tmUTZ5OzCuBFiTkY4d9O9Xl sE6j+kvR4hBDGNAXRH3Jf1laOeVtuJl9IgMUI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:content-transfer-encoding :in-reply-to:references:subject:from:cc:to:date:message-id :user-agent; bh=8mZBJ8cLMtckf5ie94vJM9dG4dXSSI5Lejo+Q/gBHh4=; b=VM1pNbaxJckXoWikznuF6wrzLxiYP7qVZKm4q74HdL+Lx50hxK4+zHtG/daqhgEcno eZXiVAqfj7fYXI+Cpkn9NfqkUjxlIlMxCe4cCYUzPRFYcfVjecPh2Qi/Uo3s4xbC1RFV TMQ6yILIOCWpYIFdYuwfSU5h9WggZQbwiZt5eddb/rIPAleCFXeR3WKCld9hkEX+c8vz UhgU+5FbEV8lmR7ETWpLdVHWTOmaDrn5NM7gcqWng4uGJxM6cIhvV895xorEEc++Q08P +25VuEJJ319f9uWPaV3mtx+jkrh913y+IQEVjb/YyVMzxigNH66Mkw7BFf7s+zkJpL2i F6iw== X-Gm-Message-State: AOAM533QkmXdIloSUAXPOPuyLd9ua0otrtEqcwri4lQ8Hm6Jr/bEwTwr UoTqJ8tJoHiC9GgYuNkWYfyBzayCPVZbFg== X-Google-Smtp-Source: ABdhPJwXci7bPJVYBFGnOsZ81TDzX4aNaBlsDL4MOUhAzC4BVReOIP1FUogHNHnB3AqHInM5cq0p0Q== X-Received: by 2002:a63:d648:: with SMTP id d8mr21375045pgj.4.1600327222184; Thu, 17 Sep 2020 00:20:22 -0700 (PDT) Received: from chromium.org ([2620:15c:202:1:3e52:82ff:fe6c:83ab]) by smtp.gmail.com with ESMTPSA id 143sm19564027pfc.66.2020.09.17.00.20.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Sep 2020 00:20:21 -0700 (PDT) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <1600305963-7659-3-git-send-email-mansur@codeaurora.org> References: <1600305963-7659-1-git-send-email-mansur@codeaurora.org> <1600305963-7659-3-git-send-email-mansur@codeaurora.org> Subject: Re: [RESEND v2 2/4] venus: core: vote for video-mem path From: Stephen Boyd Cc: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, vgarodia@codeaurora.org, Mansur Alisha Shaik To: Mansur Alisha Shaik , linux-media@vger.kernel.org, stanimir.varbanov@linaro.org Date: Thu, 17 Sep 2020 00:20:20 -0700 Message-ID: <160032722036.4188128.15261798942473063496@swboyd.mtv.corp.google.com> User-Agent: alot/0.9.1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Mansur Alisha Shaik (2020-09-16 18:26:01) > diff --git a/drivers/media/platform/qcom/venus/core.c b/drivers/media/pla= tform/qcom/venus/core.c > index 52a3886..064b6c8 100644 > --- a/drivers/media/platform/qcom/venus/core.c > +++ b/drivers/media/platform/qcom/venus/core.c > @@ -363,8 +363,16 @@ static __maybe_unused int venus_runtime_suspend(stru= ct device *dev) > =20 > ret =3D icc_set_bw(core->cpucfg_path, 0, 0); > if (ret) > - return ret; > + goto err_poweron_core; > + > + ret =3D icc_set_bw(core->video_path, 0, 0); > + if (ret) > + goto err_poweron_core; > + > + return ret; > =20 > +err_poweron_core: > + pm_ops->core_power(dev, POWER_ON); Don't we need to put back the bandwidth from before suspend was entered if the video_path fails? > return ret; > } >