linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Chunfeng Yun <chunfeng.yun@mediatek.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Felipe Balbi <balbi@kernel.org>
Cc: Mathias Nyman <mathias.nyman@intel.com>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Chunfeng Yun <chunfeng.yun@mediatek.com>,
	"Eric W. Biederman" <ebiederm@xmission.com>,
	Sumit Garg <sumit.garg@linaro.org>,
	Lee Jones <lee.jones@linaro.org>, Jann Horn <jannh@google.com>,
	Jason Yan <yanaijie@huawei.com>, Arnd Bergmann <arnd@arndb.de>,
	Chuhong Yuan <hslester96@gmail.com>,
	"Gustavo A. R. Silva" <gustavoars@kernel.org>,
	"Ben Dooks (Codethink)" <ben.dooks@codethink.co.uk>,
	Saurav Girepunje <saurav.girepunje@gmail.com>,
	<linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-mediatek@lists.infradead.org>,
	Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
	Daniel Thompson <daniel.thompson@linaro.org>
Subject: [PATCH v4 06/11] usb: fotg210-hcd: convert to readl_poll_timeout_atomic()
Date: Mon, 21 Sep 2020 14:13:30 +0800	[thread overview]
Message-ID: <1600668815-12135-6-git-send-email-chunfeng.yun@mediatek.com> (raw)
In-Reply-To: <1600668815-12135-1-git-send-email-chunfeng.yun@mediatek.com>

Use readl_poll_timeout_atomic() to simplify code

Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
---
v2~v4: no changes
---
 drivers/usb/host/fotg210-hcd.c | 20 +++++++++-----------
 1 file changed, 9 insertions(+), 11 deletions(-)

diff --git a/drivers/usb/host/fotg210-hcd.c b/drivers/usb/host/fotg210-hcd.c
index 194df82..1d94fcf 100644
--- a/drivers/usb/host/fotg210-hcd.c
+++ b/drivers/usb/host/fotg210-hcd.c
@@ -32,6 +32,7 @@
 #include <linux/uaccess.h>
 #include <linux/platform_device.h>
 #include <linux/io.h>
+#include <linux/iopoll.h>
 #include <linux/clk.h>
 
 #include <asm/byteorder.h>
@@ -883,18 +884,15 @@ static int handshake(struct fotg210_hcd *fotg210, void __iomem *ptr,
 		u32 mask, u32 done, int usec)
 {
 	u32 result;
+	int ret;
 
-	do {
-		result = fotg210_readl(fotg210, ptr);
-		if (result == ~(u32)0)		/* card removed */
-			return -ENODEV;
-		result &= mask;
-		if (result == done)
-			return 0;
-		udelay(1);
-		usec--;
-	} while (usec > 0);
-	return -ETIMEDOUT;
+	ret = readl_poll_timeout_atomic(ptr, result,
+					((result & mask) == done ||
+					 result == U32_MAX), 1, usec);
+	if (result == U32_MAX)		/* card removed */
+		return -ENODEV;
+
+	return ret;
 }
 
 /* Force HC to halt state from unknown (EHCI spec section 2.3).
-- 
1.9.1

  parent reply	other threads:[~2020-09-21  6:17 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-21  6:13 [PATCH v4 01/11] usb: early: convert to readl_poll_timeout_atomic() Chunfeng Yun
2020-09-21  6:13 ` [PATCH v4 02/11] usb: early: ehci-dbgp: " Chunfeng Yun
2020-09-21  6:13 ` [PATCH v4 03/11] usb: pci-quirks: " Chunfeng Yun
2020-09-21  6:13 ` [PATCH v4 04/11] usb: xhci-rcar: " Chunfeng Yun
2020-09-23  8:47   ` Yoshihiro Shimoda
2020-09-23  8:53     ` Chunfeng Yun
2020-09-21  6:13 ` [PATCH v4 05/11] usb: oxu210hp-hcd: " Chunfeng Yun
2020-09-21  6:13 ` Chunfeng Yun [this message]
2020-09-21  6:13 ` [PATCH v4 07/11] usb: isp1760-hcd: " Chunfeng Yun
2020-09-21  6:13 ` [PATCH v4 08/11] usb: phy-ulpi-viewport: " Chunfeng Yun
2020-09-21  6:13 ` [PATCH v4 09/11] usb: phy: phy-mv-usb: " Chunfeng Yun
2020-09-21  6:13 ` [PATCH v4 10/11] usb: udc: net2280: " Chunfeng Yun
2020-09-21  6:13 ` [PATCH v4 11/11] iopoll: update kerneldoc of read_poll_timeout_atomic() Chunfeng Yun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1600668815-12135-6-git-send-email-chunfeng.yun@mediatek.com \
    --to=chunfeng.yun@mediatek.com \
    --cc=arnd@arndb.de \
    --cc=balbi@kernel.org \
    --cc=ben.dooks@codethink.co.uk \
    --cc=daniel.thompson@linaro.org \
    --cc=ebiederm@xmission.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=gustavoars@kernel.org \
    --cc=hslester96@gmail.com \
    --cc=jannh@google.com \
    --cc=lee.jones@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mathias.nyman@intel.com \
    --cc=matthias.bgg@gmail.com \
    --cc=saurav.girepunje@gmail.com \
    --cc=sergei.shtylyov@cogentembedded.com \
    --cc=sumit.garg@linaro.org \
    --cc=yanaijie@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).