linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] drm/hisilicon: Delete the unused macro
@ 2020-09-29  0:45 Tian Tao
  2020-09-29  7:24 ` Thomas Zimmermann
  0 siblings, 1 reply; 3+ messages in thread
From: Tian Tao @ 2020-09-29  0:45 UTC (permalink / raw)
  To: airlied, daniel, tzimmermann, kraxel, alexander.deucher, tglx,
	dri-devel, xinliang.liu, linux-kernel
  Cc: linuxarm

The macro PADDING is no longer used. Delete it.

Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
---
 drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_de.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_de.c b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_de.c
index 4d57ec6..b3a81da 100644
--- a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_de.c
+++ b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_de.c
@@ -52,8 +52,6 @@ static const struct hibmc_dislay_pll_config hibmc_pll_table[] = {
 	{1920, 1200, CRT_PLL1_HS_193MHZ, CRT_PLL2_HS_193MHZ},
 };
 
-#define PADDING(align, data) (((data) + (align) - 1) & (~((align) - 1)))
-
 static int hibmc_plane_atomic_check(struct drm_plane *plane,
 				    struct drm_plane_state *state)
 {
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] drm/hisilicon: Delete the unused macro
  2020-09-29  0:45 [PATCH] drm/hisilicon: Delete the unused macro Tian Tao
@ 2020-09-29  7:24 ` Thomas Zimmermann
  2020-09-29  7:29   ` tiantao (H)
  0 siblings, 1 reply; 3+ messages in thread
From: Thomas Zimmermann @ 2020-09-29  7:24 UTC (permalink / raw)
  To: Tian Tao, airlied, daniel, kraxel, alexander.deucher, tglx,
	dri-devel, xinliang.liu, linux-kernel
  Cc: linuxarm


[-- Attachment #1.1: Type: text/plain, Size: 1128 bytes --]



Am 29.09.20 um 02:45 schrieb Tian Tao:
> The macro PADDING is no longer used. Delete it.
> 
> Signed-off-by: Tian Tao <tiantao6@hisilicon.com>

Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>

> ---
>  drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_de.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_de.c b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_de.c
> index 4d57ec6..b3a81da 100644
> --- a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_de.c
> +++ b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_de.c
> @@ -52,8 +52,6 @@ static const struct hibmc_dislay_pll_config hibmc_pll_table[] = {
>  	{1920, 1200, CRT_PLL1_HS_193MHZ, CRT_PLL2_HS_193MHZ},
>  };
>  
> -#define PADDING(align, data) (((data) + (align) - 1) & (~((align) - 1)))
> -
>  static int hibmc_plane_atomic_check(struct drm_plane *plane,
>  				    struct drm_plane_state *state)
>  {
> 

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 516 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] drm/hisilicon: Delete the unused macro
  2020-09-29  7:24 ` Thomas Zimmermann
@ 2020-09-29  7:29   ` tiantao (H)
  0 siblings, 0 replies; 3+ messages in thread
From: tiantao (H) @ 2020-09-29  7:29 UTC (permalink / raw)
  To: Thomas Zimmermann, Tian Tao, airlied, daniel, kraxel,
	alexander.deucher, tglx, dri-devel, xinliang.liu, linux-kernel
  Cc: linuxarm



在 2020/9/29 15:24, Thomas Zimmermann 写道:
> 
> 
> Am 29.09.20 um 02:45 schrieb Tian Tao:
>> The macro PADDING is no longer used. Delete it.
>>
>> Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
> 
> Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
> 
Thanks a lot for the timely help with the review code!
>> ---
>>   drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_de.c | 2 --
>>   1 file changed, 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_de.c b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_de.c
>> index 4d57ec6..b3a81da 100644
>> --- a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_de.c
>> +++ b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_de.c
>> @@ -52,8 +52,6 @@ static const struct hibmc_dislay_pll_config hibmc_pll_table[] = {
>>   	{1920, 1200, CRT_PLL1_HS_193MHZ, CRT_PLL2_HS_193MHZ},
>>   };
>>   
>> -#define PADDING(align, data) (((data) + (align) - 1) & (~((align) - 1)))
>> -
>>   static int hibmc_plane_atomic_check(struct drm_plane *plane,
>>   				    struct drm_plane_state *state)
>>   {
>>
> 


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-09-29  7:30 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-29  0:45 [PATCH] drm/hisilicon: Delete the unused macro Tian Tao
2020-09-29  7:24 ` Thomas Zimmermann
2020-09-29  7:29   ` tiantao (H)

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).