From: Chunfeng Yun <chunfeng.yun@mediatek.com>
To: Rob Herring <robh@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
<linux-usb@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-mediatek@lists.infradead.org>
Subject: Re: [PATCH] dt-bindings: usb: add properties for hard wired devices
Date: Tue, 29 Sep 2020 14:06:39 +0800 [thread overview]
Message-ID: <1601359599.29336.49.camel@mhfsdcap03> (raw)
In-Reply-To: <20200928181247.GA3008733@bogus>
On Mon, 2020-09-28 at 13:12 -0500, Rob Herring wrote:
> On Mon, Sep 28, 2020 at 02:39:50PM +0800, Chunfeng Yun wrote:
> > Add some optional properties which are needed for hard wired devices
> >
> > Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> > ---
> > Documentation/devicetree/bindings/usb/usb-hcd.yaml | 11 +++++++++++
> > 1 file changed, 11 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/usb/usb-hcd.yaml b/Documentation/devicetree/bindings/usb/usb-hcd.yaml
> > index 7263b7f2b510..1194a82887e7 100644
> > --- a/Documentation/devicetree/bindings/usb/usb-hcd.yaml
> > +++ b/Documentation/devicetree/bindings/usb/usb-hcd.yaml
> > @@ -22,6 +22,17 @@ properties:
> > description:
> > Name specifier for the USB PHY
> >
> > + "#address-cells":
> > + const: 1
> > +
> > + "#size-cells":
> > + const: 0
> > +
> > +patternProperties:
> > + "^hub|device@[0-9a-f]+$":
>
> Could be any class of device, so '@[0-9a-f]+$'
You mean we will use different standard node name for each usb class?
e.g.
Use 'ethernet@*' for a usb ethernet adapter, and use 'camera@*' for a
usb camera sensor?
>
> > + type: object
> > + description: The hard wired USB devices. See usb/usb-device.txt
>
> Ideally, we'd convert usb-device.txt to schema and reference it here.
Ok, I'll try to do it.
BTW: Does the compatible support pattern? Is there any example I can
refer to?
Thanks
>
> > +
> > examples:
> > - |
> > usb {
> > --
> > 2.18.0
next prev parent reply other threads:[~2020-09-29 6:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-28 6:39 [PATCH] dt-bindings: usb: add properties for hard wired devices Chunfeng Yun
2020-09-28 18:12 ` Rob Herring
2020-09-29 6:06 ` Chunfeng Yun [this message]
2020-09-29 13:56 ` Rob Herring
2020-09-28 18:13 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1601359599.29336.49.camel@mhfsdcap03 \
--to=chunfeng.yun@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).