linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Boyd <sboyd@kernel.org>
To: David Collins <collinsd@codeaurora.org>, Mark Brown <broonie@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RESEND PATCH] spmi: prefix spmi bus device names with "spmi"
Date: Fri, 02 Oct 2020 10:48:32 -0700	[thread overview]
Message-ID: <160166091282.310579.8553391053258607173@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <20201002160324.GE5527@sirena.org.uk>

Quoting Mark Brown (2020-10-02 09:03:24)
> On Thu, Oct 01, 2020 at 05:45:00PM -0700, David Collins wrote:
> 
> > The SPMI regmap debugfs files are used extensively for testing and debug
> > purposes internally at Qualcomm and by our customers.  It would be helpful
> > if the more verbose naming scheme were accepted upstream to avoid
> > confusion and broken test scripts.
> 
> ...and doing this in the dev_name() should help other diagnostic users
> (like dev_printk() for example).

Don't thinks like dev_printk() prefix the bus name? See
dev_driver_string()? So I agree that having the bus name is useful, but
confused why there are testing scripts and things on top of regmap
debugfs

Put another way, why not introduce something similar to i2c-dev where
userspace can read/write registers for devices on the SPMI bus?
Otherwise I presume the test scripts inside Qualcomm are just reading
registers out of regmap?

  reply	other threads:[~2020-10-02 17:48 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-22 22:04 [RESEND PATCH] spmi: prefix spmi bus device names with "spmi" David Collins
2020-10-01  0:07 ` Stephen Boyd
2020-10-01 17:43   ` Mark Brown
2020-10-01 18:51     ` Stephen Boyd
2020-10-02  0:45       ` David Collins
2020-10-02 16:03         ` Mark Brown
2020-10-02 17:48           ` Stephen Boyd [this message]
2020-10-02 18:04             ` Mark Brown
2020-10-02 21:39               ` Stephen Boyd
2020-10-14  0:59                 ` David Collins

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=160166091282.310579.8553391053258607173@swboyd.mtv.corp.google.com \
    --to=sboyd@kernel.org \
    --cc=broonie@kernel.org \
    --cc=collinsd@codeaurora.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).