Re: [PATCH] [PATCH] of_reserved_mem: Increase the number of reserved regions

From: Phil Chang <phil.chang@mediatek.com>
To: Chun-Kuang Hu <chunkuang.hu@kernel.org>
Cc: Linux ARM <linux-arm-kernel@lists.infradead.org>,
	DTML <devicetree@vger.kernel.org>, Alix Wu <alix.wu@mediatek.com>,
	YJ Chiang <yj.chiang@mediatek.com>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	"Rob Herring" <robh+dt@kernel.org>,
	"moderated list:ARM/Mediatek SoC support" 
	<linux-mediatek@lists.infradead.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Joe Liu <joe.liu@mediatek.com>,
	Frank Rowand <frowand.list@gmail.com>
Subject: Re: [PATCH] [PATCH] of_reserved_mem: Increase the number of reserved regions
Date: Tue, 6 Oct 2020 01:17:17 +0800	[thread overview]
Message-ID: <1601918237.17256.3.camel@mtksdccf07> (raw)
In-Reply-To: <CAAOTY_8vCb-adkbpdmbTWLeOFt-+dHjr4HVonHX7XPkLkzy1yA@mail.gmail.com>

Hi Chun-Kuang

Sorry for typo. In fact, the dts of new SoC is not upstream yet. I'm so
sorry for couldn't show the detail now.

How about the configurable MAX_RESERVED_REGIONS size like this patch?
https://patchwork.kernel.org/patch/10692101/

On Sun, 2020-10-04 at 21:05 +0800, Chun-Kuang Hu wrote:
> Hi, Phil:
> 
> Phil Chang <phil.chang@mediatek.com> 於 2020年10月4日 週日 下午1:51寫道：
> >
> > Certain SoCs need to support large amount of reserved memory
> > regions, especially to follow the GKI rules from Google.
> > In MTK new SoC requires more than 68 regions of reserved memory
> > for each IP's usage, such as load firmware to specific sapce,
> 
> space
> 
> > so that need to reserve more regisions
> 
> regions.
> 
> I guess this requirement is from Mediatek SoC, but I find below device
> tree and just find one reserved memory region,
> 
> arch/arm64/boot/dts/mediatek/mt7622.dtsi
> arch/arm64/boot/dts/mediatek/mt8173.dtsi
> arch/arm64/boot/dts/mediatek/mt8516.dtsi
> 
> Could you show me the 68 regions?
> 
> Regards,
> Chun-Kuang.
> 
> >
> > Signed-off-by: Joe Liu <joe.liu@mediatek.com>
> > Signed-off-by: YJ Chiang <yj.chiang@mediatek.com>
> > Signed-off-by: Alix Wu <alix.wu@mediatek.com>
> > Signed-off-by: Phil Chang <phil.chang@mediatek.com>
> > ---
> >  drivers/of/of_reserved_mem.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/of/of_reserved_mem.c b/drivers/of/of_reserved_mem.c
> > index 46b9371c8a33..595f0741dcef 100644
> > --- a/drivers/of/of_reserved_mem.c
> > +++ b/drivers/of/of_reserved_mem.c
> > @@ -22,7 +22,7 @@
> >  #include <linux/slab.h>
> >  #include <linux/memblock.h>
> >
> > -#define MAX_RESERVED_REGIONS   64
> > +#define MAX_RESERVED_REGIONS   128
> >  static struct reserved_mem reserved_mem[MAX_RESERVED_REGIONS];
> >  static int reserved_mem_count;
> >
> > --
> > 2.18.0
> > _______________________________________________
> > Linux-mediatek mailing list
> > Linux-mediatek@lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/linux-mediatek